mirror of
https://github.com/certbot/certbot.git
synced 2026-07-27 08:09:10 +02:00
Fixes #5789 This PR is about allowing Certbot to respect the Retry-After HTTP header that an ACME CA server can return to a client POSTing to a challenge, to instruct him and retry the request later. However, this feature was not easily implementable in the current code of certbot.auth_handler, because the code became really hard to read. In fact, @bmw was thinking that the code was really deceiving, and a lot of supposed functionalities declared in the comments were in fact not implemented or not functional. So I took the time to understand what was going on, and effectively, most of the code is in fact not usable or not used. Then I did a refactoring against the bare ACME spec about what to do to prepare challenges, instruct the ACME CA server to perform them, then polling regularly the authorization resources until they are decided (valid or invalid). And of course this implementation takes care of Retry-After ^^ I added a lot of comments in the new implementation, to explain what is going on for a future developer. The workflow I used is relying on the relationships between authorizations and challenges states as described in section 7.1.6 of the ACME spec draft: https://datatracker.ietf.org/doc/draft-ietf-acme-acme/ * Clean auth_handler a bit, and implement retry-after. * Remove a debug logger * Correct tests * Fix mypy and lint. Setup max retries and default retry after accordingly. * Ease a comparison in tests * Update documentation * Add tests * Adapt windows coverage threshold to the global LOC reduction * Update certbot/auth_handler.py Co-Authored-By: adferrand <adferrand@users.noreply.github.com> * Corrections under review * Correction under review * Update certbot/auth_handler.py Co-Authored-By: adferrand <adferrand@users.noreply.github.com> * Corrections under review * Update auth_handler_test.py * Reimplementing user readable report for failed authorizations * Fixes two tests * Fix another test + lint + mypy * Update auth_handler.py * Update auth_handler_test.py * Fix tests * Update certbot/auth_handler.py Co-Authored-By: adferrand <adferrand@users.noreply.github.com> * Raise directly the exception on polling timout * Improve interface documentation * Move the wait on top of the loop, to be used initially or after a new loop iteration. Do not wait for negative values. * Always display the report about failed authorizations. * Clarify an exception. * Return, instead of break * Use setdefault * Remove useless assertion * Adapt tests * Improve a test about retry after value. * Update certbot/auth_handler.py Co-Authored-By: adferrand <adferrand@users.noreply.github.com> * Add a complete test on best_effort * Add entry to the changelog * Gather all failed authzrs to be reported in one unique report in case of best_effort * Build complete warn/report/raise process about failed authzrs
449 lines
18 KiB
Python
449 lines
18 KiB
Python
"""ACME AuthHandler."""
|
|
import logging
|
|
import time
|
|
import datetime
|
|
|
|
import zope.component
|
|
|
|
from acme import challenges
|
|
from acme import messages
|
|
# pylint: disable=unused-import, no-name-in-module
|
|
from acme.magic_typing import Dict, List
|
|
# pylint: enable=unused-import, no-name-in-module
|
|
from certbot import achallenges
|
|
from certbot import errors
|
|
from certbot import error_handler
|
|
from certbot import interfaces
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class AuthHandler(object):
|
|
"""ACME Authorization Handler for a client.
|
|
|
|
:ivar auth: Authenticator capable of solving
|
|
:class:`~acme.challenges.Challenge` types
|
|
:type auth: :class:`certbot.interfaces.IAuthenticator`
|
|
|
|
:ivar acme.client.BackwardsCompatibleClientV2 acme_client: ACME client API.
|
|
|
|
:ivar account: Client's Account
|
|
:type account: :class:`certbot.account.Account`
|
|
|
|
:ivar list pref_challs: sorted user specified preferred challenges
|
|
type strings with the most preferred challenge listed first
|
|
|
|
"""
|
|
def __init__(self, auth, acme_client, account, pref_challs):
|
|
self.auth = auth
|
|
self.acme = acme_client
|
|
|
|
self.account = account
|
|
self.pref_challs = pref_challs
|
|
|
|
def handle_authorizations(self, orderr, best_effort=False, max_retries=30):
|
|
"""
|
|
Retrieve all authorizations, perform all challenges required to validate
|
|
these authorizations, then poll and wait for the authorization to be checked.
|
|
:param acme.messages.OrderResource orderr: must have authorizations filled in
|
|
:param bool best_effort: if True, not all authorizations need to be validated (eg. renew)
|
|
:param int max_retries: maximum number of retries to poll authorizations
|
|
:returns: list of all validated authorizations
|
|
:rtype: List
|
|
|
|
:raises .AuthorizationError: If unable to retrieve all authorizations
|
|
"""
|
|
authzrs = orderr.authorizations[:]
|
|
if not authzrs:
|
|
raise errors.AuthorizationError('No authorization to handle.')
|
|
|
|
# Retrieve challenges that need to be performed to validate authorizations.
|
|
achalls = self._choose_challenges(authzrs)
|
|
if not achalls:
|
|
return authzrs
|
|
|
|
# Starting now, challenges will be cleaned at the end no matter what.
|
|
with error_handler.ExitHandler(self._cleanup_challenges, achalls):
|
|
# To begin, let's ask the authenticator plugin to perform all challenges.
|
|
try:
|
|
resps = self.auth.perform(achalls)
|
|
|
|
# If debug is on, wait for user input before starting the verification process.
|
|
logger.info('Waiting for verification...')
|
|
config = zope.component.getUtility(interfaces.IConfig)
|
|
if config.debug_challenges:
|
|
notify = zope.component.getUtility(interfaces.IDisplay).notification
|
|
notify('Challenges loaded. Press continue to submit to CA. '
|
|
'Pass "-v" for more info about challenges.', pause=True)
|
|
except errors.AuthorizationError as error:
|
|
logger.critical('Failure in setting up challenges.')
|
|
logger.info('Attempting to clean up outstanding challenges...')
|
|
raise error
|
|
# All challenges should have been processed by the authenticator.
|
|
assert len(resps) == len(achalls), 'Some challenges have not been performed.'
|
|
|
|
# Inform the ACME CA server that challenges are available for validation.
|
|
for achall, resp in zip(achalls, resps):
|
|
self.acme.answer_challenge(achall.challb, resp)
|
|
|
|
# Wait for authorizations to be checked.
|
|
self._poll_authorizations(authzrs, max_retries, best_effort)
|
|
|
|
# Keep validated authorizations only. If there is none, no certificate can be issued.
|
|
authzrs_validated = [authzr for authzr in authzrs
|
|
if authzr.body.status == messages.STATUS_VALID]
|
|
if not authzrs_validated:
|
|
raise errors.AuthorizationError('All challenges have failed.')
|
|
|
|
return authzrs_validated
|
|
|
|
def _poll_authorizations(self, authzrs, max_retries, best_effort):
|
|
"""
|
|
Poll the ACME CA server, to wait for confirmation that authorizations have their challenges
|
|
all verified. The poll may occur several times, until all authorizations are checked
|
|
(valid or invalid), or after a maximum of retries.
|
|
"""
|
|
authzrs_to_check = {index: (authzr, None)
|
|
for index, authzr in enumerate(authzrs)}
|
|
authzrs_failed_to_report = []
|
|
# Give an initial second to the ACME CA server to check the authorizations
|
|
sleep_seconds = 1
|
|
for _ in range(max_retries):
|
|
# Wait for appropriate time (from Retry-After, initial wait, or no wait)
|
|
if sleep_seconds > 0:
|
|
time.sleep(sleep_seconds)
|
|
# Poll all updated authorizations.
|
|
authzrs_to_check = {index: self.acme.poll(authzr) for index, (authzr, _)
|
|
in authzrs_to_check.items()}
|
|
# Update the original list of authzr with the updated authzrs from server.
|
|
for index, (authzr, _) in authzrs_to_check.items():
|
|
authzrs[index] = authzr
|
|
|
|
# Gather failed authorizations
|
|
authzrs_failed = [authzr for authzr, _ in authzrs_to_check.values()
|
|
if authzr.body.status == messages.STATUS_INVALID]
|
|
for authzr_failed in authzrs_failed:
|
|
logger.warning('Challenge failed for domain %s',
|
|
authzr_failed.body.identifier.value)
|
|
# Accumulating all failed authzrs to build a consolidated report
|
|
# on them at the end of the polling.
|
|
authzrs_failed_to_report.extend(authzrs_failed)
|
|
|
|
# Extract out the authorization already checked for next poll iteration.
|
|
# Poll may stop here because there is no pending authorizations anymore.
|
|
authzrs_to_check = {index: (authzr, resp) for index, (authzr, resp)
|
|
in authzrs_to_check.items()
|
|
if authzr.body.status == messages.STATUS_PENDING}
|
|
if not authzrs_to_check:
|
|
# Polling process is finished, we can leave the loop
|
|
break
|
|
|
|
# Be merciful with the ACME server CA, check the Retry-After header returned,
|
|
# and wait this time before polling again in next loop iteration.
|
|
# From all the pending authorizations, we take the greatest Retry-After value
|
|
# to avoid polling an authorization before its relevant Retry-After value.
|
|
retry_after = max(self.acme.retry_after(resp, 3)
|
|
for _, resp in authzrs_to_check.values())
|
|
sleep_seconds = (retry_after - datetime.datetime.now()).total_seconds()
|
|
|
|
# In case of failed authzrs, create a report to the user.
|
|
if authzrs_failed_to_report:
|
|
_report_failed_authzrs(authzrs_failed_to_report, self.account.key)
|
|
if not best_effort:
|
|
# Without best effort, having failed authzrs is critical and fail the process.
|
|
raise errors.AuthorizationError('Some challenges have failed.')
|
|
|
|
if authzrs_to_check:
|
|
# Here authzrs_to_check is still not empty, meaning we exceeded the max polling attempt.
|
|
raise errors.AuthorizationError('All authorizations were not finalized by the CA.')
|
|
|
|
def _choose_challenges(self, authzrs):
|
|
"""
|
|
Retrieve necessary and pending challenges to satisfy server.
|
|
NB: Necessary and already validated challenges are not retrieved,
|
|
as they can be reused for a certificate issuance.
|
|
"""
|
|
pending_authzrs = [authzr for authzr in authzrs
|
|
if authzr.body.status != messages.STATUS_VALID]
|
|
achalls = [] # type: List[achallenges.AnnotatedChallenge]
|
|
if pending_authzrs:
|
|
logger.info("Performing the following challenges:")
|
|
for authzr in pending_authzrs:
|
|
authzr_challenges = authzr.body.challenges
|
|
if self.acme.acme_version == 1:
|
|
combinations = authzr.body.combinations
|
|
else:
|
|
combinations = tuple((i,) for i in range(len(authzr_challenges)))
|
|
|
|
path = gen_challenge_path(
|
|
authzr_challenges,
|
|
self._get_chall_pref(authzr.body.identifier.value),
|
|
combinations)
|
|
|
|
achalls.extend(self._challenge_factory(authzr, path))
|
|
|
|
if any(isinstance(achall.chall, challenges.TLSSNI01) for achall in achalls):
|
|
logger.warning("TLS-SNI-01 is deprecated, and will stop working soon.")
|
|
|
|
return achalls
|
|
|
|
def _get_chall_pref(self, domain):
|
|
"""Return list of challenge preferences.
|
|
|
|
:param str domain: domain for which you are requesting preferences
|
|
|
|
"""
|
|
chall_prefs = []
|
|
# Make sure to make a copy...
|
|
plugin_pref = self.auth.get_chall_pref(domain)
|
|
if self.pref_challs:
|
|
plugin_pref_types = set(chall.typ for chall in plugin_pref)
|
|
for typ in self.pref_challs:
|
|
if typ in plugin_pref_types:
|
|
chall_prefs.append(challenges.Challenge.TYPES[typ])
|
|
if chall_prefs:
|
|
return chall_prefs
|
|
raise errors.AuthorizationError(
|
|
"None of the preferred challenges "
|
|
"are supported by the selected plugin")
|
|
chall_prefs.extend(plugin_pref)
|
|
return chall_prefs
|
|
|
|
def _cleanup_challenges(self, achalls):
|
|
"""Cleanup challenges.
|
|
|
|
:param achalls: annotated challenges to cleanup
|
|
:type achalls: `list` of :class:`certbot.achallenges.AnnotatedChallenge`
|
|
|
|
"""
|
|
logger.info("Cleaning up challenges")
|
|
self.auth.cleanup(achalls)
|
|
|
|
def _challenge_factory(self, authzr, path):
|
|
"""Construct Namedtuple Challenges
|
|
|
|
:param messages.AuthorizationResource authzr: authorization
|
|
|
|
:param list path: List of indices from `challenges`.
|
|
|
|
:returns: achalls, list of challenge type
|
|
:class:`certbot.achallenges.Indexed`
|
|
:rtype: list
|
|
|
|
:raises .errors.Error: if challenge type is not recognized
|
|
|
|
"""
|
|
achalls = []
|
|
|
|
for index in path:
|
|
challb = authzr.body.challenges[index]
|
|
achalls.append(challb_to_achall(
|
|
challb, self.account.key, authzr.body.identifier.value))
|
|
|
|
return achalls
|
|
|
|
|
|
def challb_to_achall(challb, account_key, domain):
|
|
"""Converts a ChallengeBody object to an AnnotatedChallenge.
|
|
|
|
:param .ChallengeBody challb: ChallengeBody
|
|
:param .JWK account_key: Authorized Account Key
|
|
:param str domain: Domain of the challb
|
|
|
|
:returns: Appropriate AnnotatedChallenge
|
|
:rtype: :class:`certbot.achallenges.AnnotatedChallenge`
|
|
|
|
"""
|
|
chall = challb.chall
|
|
logger.info("%s challenge for %s", chall.typ, domain)
|
|
|
|
if isinstance(chall, challenges.KeyAuthorizationChallenge):
|
|
return achallenges.KeyAuthorizationAnnotatedChallenge(
|
|
challb=challb, domain=domain, account_key=account_key)
|
|
elif isinstance(chall, challenges.DNS):
|
|
return achallenges.DNS(challb=challb, domain=domain)
|
|
else:
|
|
raise errors.Error(
|
|
"Received unsupported challenge of type: %s", chall.typ)
|
|
|
|
|
|
def gen_challenge_path(challbs, preferences, combinations):
|
|
"""Generate a plan to get authority over the identity.
|
|
|
|
.. todo:: This can be possibly be rewritten to use resolved_combinations.
|
|
|
|
:param tuple challbs: A tuple of challenges
|
|
(:class:`acme.messages.Challenge`) from
|
|
:class:`acme.messages.AuthorizationResource` to be
|
|
fulfilled by the client in order to prove possession of the
|
|
identifier.
|
|
|
|
:param list preferences: List of challenge preferences for domain
|
|
(:class:`acme.challenges.Challenge` subclasses)
|
|
|
|
:param tuple combinations: A collection of sets of challenges from
|
|
:class:`acme.messages.Challenge`, each of which would
|
|
be sufficient to prove possession of the identifier.
|
|
|
|
:returns: tuple of indices from ``challenges``.
|
|
:rtype: tuple
|
|
|
|
:raises certbot.errors.AuthorizationError: If a
|
|
path cannot be created that satisfies the CA given the preferences and
|
|
combinations.
|
|
|
|
"""
|
|
if combinations:
|
|
return _find_smart_path(challbs, preferences, combinations)
|
|
else:
|
|
return _find_dumb_path(challbs, preferences)
|
|
|
|
|
|
def _find_smart_path(challbs, preferences, combinations):
|
|
"""Find challenge path with server hints.
|
|
|
|
Can be called if combinations is included. Function uses a simple
|
|
ranking system to choose the combo with the lowest cost.
|
|
|
|
"""
|
|
chall_cost = {}
|
|
max_cost = 1
|
|
for i, chall_cls in enumerate(preferences):
|
|
chall_cost[chall_cls] = i
|
|
max_cost += i
|
|
|
|
# max_cost is now equal to sum(indices) + 1
|
|
|
|
best_combo = None
|
|
# Set above completing all of the available challenges
|
|
best_combo_cost = max_cost
|
|
|
|
combo_total = 0
|
|
for combo in combinations:
|
|
for challenge_index in combo:
|
|
combo_total += chall_cost.get(challbs[
|
|
challenge_index].chall.__class__, max_cost)
|
|
|
|
if combo_total < best_combo_cost:
|
|
best_combo = combo
|
|
best_combo_cost = combo_total
|
|
|
|
combo_total = 0
|
|
|
|
if not best_combo:
|
|
_report_no_chall_path(challbs)
|
|
|
|
return best_combo
|
|
|
|
|
|
def _find_dumb_path(challbs, preferences):
|
|
"""Find challenge path without server hints.
|
|
|
|
Should be called if the combinations hint is not included by the
|
|
server. This function either returns a path containing all
|
|
challenges provided by the CA or raises an exception.
|
|
|
|
"""
|
|
path = []
|
|
for i, challb in enumerate(challbs):
|
|
# supported is set to True if the challenge type is supported
|
|
supported = next((True for pref_c in preferences
|
|
if isinstance(challb.chall, pref_c)), False)
|
|
if supported:
|
|
path.append(i)
|
|
else:
|
|
_report_no_chall_path(challbs)
|
|
|
|
return path
|
|
|
|
|
|
def _report_no_chall_path(challbs):
|
|
"""Logs and raises an error that no satisfiable chall path exists.
|
|
|
|
:param challbs: challenges from the authorization that can't be satisfied
|
|
|
|
"""
|
|
msg = ("Client with the currently selected authenticator does not support "
|
|
"any combination of challenges that will satisfy the CA.")
|
|
if len(challbs) == 1 and isinstance(challbs[0].chall, challenges.DNS01):
|
|
msg += (
|
|
" You may need to use an authenticator "
|
|
"plugin that can do challenges over DNS.")
|
|
logger.critical(msg)
|
|
raise errors.AuthorizationError(msg)
|
|
|
|
|
|
_ERROR_HELP_COMMON = (
|
|
"To fix these errors, please make sure that your domain name was entered "
|
|
"correctly and the DNS A/AAAA record(s) for that domain contain(s) the "
|
|
"right IP address.")
|
|
|
|
|
|
_ERROR_HELP = {
|
|
"connection":
|
|
_ERROR_HELP_COMMON + " Additionally, please check that your computer "
|
|
"has a publicly routable IP address and that no firewalls are preventing "
|
|
"the server from communicating with the client. If you're using the "
|
|
"webroot plugin, you should also verify that you are serving files "
|
|
"from the webroot path you provided.",
|
|
"dnssec":
|
|
_ERROR_HELP_COMMON + " Additionally, if you have DNSSEC enabled for "
|
|
"your domain, please ensure that the signature is valid.",
|
|
"malformed":
|
|
"To fix these errors, please make sure that you did not provide any "
|
|
"invalid information to the client, and try running Certbot "
|
|
"again.",
|
|
"serverInternal":
|
|
"Unfortunately, an error on the ACME server prevented you from completing "
|
|
"authorization. Please try again later.",
|
|
"tls":
|
|
_ERROR_HELP_COMMON + " Additionally, please check that you have an "
|
|
"up-to-date TLS configuration that allows the server to communicate "
|
|
"with the Certbot client.",
|
|
"unauthorized": _ERROR_HELP_COMMON,
|
|
"unknownHost": _ERROR_HELP_COMMON,
|
|
}
|
|
|
|
|
|
def _report_failed_authzrs(failed_authzrs, account_key):
|
|
"""Notifies the user about failed authorizations."""
|
|
problems = {} # type: Dict[str, List[achallenges.AnnotatedChallenge]]
|
|
failed_achalls = [challb_to_achall(challb, account_key, authzr.body.identifier.value)
|
|
for authzr in failed_authzrs for challb in authzr.body.challenges
|
|
if challb.error]
|
|
|
|
for achall in failed_achalls:
|
|
problems.setdefault(achall.error.typ, []).append(achall)
|
|
|
|
reporter = zope.component.getUtility(interfaces.IReporter)
|
|
for achalls in problems.values():
|
|
reporter.add_message(_generate_failed_chall_msg(achalls), reporter.MEDIUM_PRIORITY)
|
|
|
|
|
|
def _generate_failed_chall_msg(failed_achalls):
|
|
"""Creates a user friendly error message about failed challenges.
|
|
|
|
:param list failed_achalls: A list of failed
|
|
:class:`certbot.achallenges.AnnotatedChallenge` with the same error
|
|
type.
|
|
|
|
:returns: A formatted error message for the client.
|
|
:rtype: str
|
|
|
|
"""
|
|
error = failed_achalls[0].error
|
|
typ = error.typ
|
|
if messages.is_acme_error(error):
|
|
typ = error.code
|
|
msg = ["The following errors were reported by the server:"]
|
|
|
|
for achall in failed_achalls:
|
|
msg.append("\n\nDomain: %s\nType: %s\nDetail: %s" % (
|
|
achall.domain, typ, achall.error.detail))
|
|
|
|
if typ in _ERROR_HELP:
|
|
msg.append("\n\n")
|
|
msg.append(_ERROR_HELP[typ])
|
|
|
|
return "".join(msg)
|