mirror of
https://github.com/certbot/certbot.git
synced 2026-07-27 16:30:31 +02:00
98fb9d2d93
The method `os.readlink()` has a significant behavior change with Python 3.8+ on Windows. Starting with this version, it will return the resolved path in its "extended-style" form unconditionally, a form which allows to use more than 259 characters in a Windows path, and its string representation is prepended with "\\\\?\\". See https://docs.microsoft.com/fr-fr/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#maximum-path-length-limitation Problem is that `os.readlink()` does it for any path, including paths that could be represented with the normal form. As a consequence, any string comparison with a path provided in the normal form will fail even if it represents the same path. This makes Certbot partially break on Windows with Python 3.8. My proposition in this PR is to forbid `os.readlink()`, and provide `certbot.compat.filesystem.readlink()` which serves the same purpose at resolving the pointed path of a link, and has a consistent behavior over supported Python versions. * Forbid os.readlink() * Use readlink * Raise error with long paths on Windows * Add unit tests * Update certbot/certbot/compat/filesystem.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com>