starred/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-31 10:16:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Set up ruff so that test files have at least some linting (#10399)

Browse Source 
Alternative implementation for #7908.

In this PR:
- set up ruff in CI (add to `tox.ini`, mark dep in `certbot/setup.py`)
- add a `ruff.toml` that ignores particularly annoying errors. I think
line length isn't actually necessary to set with this workflow since
we're not checking it but putting it there for future usage.
- either fix or ignore the rest of the errors that come with the default
linting configuration. fixed errors are mostly unused variables. ignored
are usually where we're doing weird import things for a specific reason.
This commit is contained in:
ohemorange
2025-08-08 08:48:43 -07:00
committed by GitHub
parent 5859e50e44
commit dea3e5f1c4
26 changed files with 102 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot-ci/src/certbot_integration_tests/utils/acme_server.py
+6 -1
View File
@@ -24,7 +24,12 @@ from certbot_integration_tests.utils import misc
from certbot_integration_tests.utils import pebble_artifacts
from certbot_integration_tests.utils import pebble_ocsp_server
from certbot_integration_tests.utils import proxy
from certbot_integration_tests.utils.constants import *
from certbot_integration_tests.utils.constants import DEFAULT_HTTP_01_PORT
from certbot_integration_tests.utils.constants import CHALLTESTSRV_PORT
from certbot_integration_tests.utils.constants import PEBBLE_DIRECTORY_URL
from certbot_integration_tests.utils.constants import PEBBLE_CHALLTESTSRV_URL
from certbot_integration_tests.utils.constants import PEBBLE_ALTERNATE_ROOTS
from certbot_integration_tests.utils.constants import MAX_SUBPROCESS_WAIT
class ACMEServer:
certbot-ci/src/certbot_integration_tests/utils/certbot_call.py
+3 -2
View File
@@ -10,8 +10,9 @@ from typing import Optional
from typing import Tuple
import certbot_integration_tests
# pylint: disable=wildcard-import,unused-wildcard-import
from certbot_integration_tests.utils.constants import *
from certbot_integration_tests.utils.constants import DEFAULT_HTTP_01_PORT
from certbot_integration_tests.utils.constants import HTTPS_PORT
from certbot_integration_tests.utils.constants import PEBBLE_DIRECTORY_URL
def certbot_test(certbot_args: List[str], directory_url: Optional[str], http_01_port: int,