mirror of
https://github.com/certbot/certbot.git
synced 2026-06-15 09:51:50 +02:00
e9dd4eb03b
fixes #10404 unfortunately, exactly what `python setup.py clean` did doesn't seem well documented so i dug into the code with a debugger. executing the `clean` subcommand is done by [this code](https://github.com/pypa/setuptools/blob/9cc2f5c05c333cd4cecd2c0d9e7c5e208f2a3148/setuptools/_distutils/command/clean.py#L54-L77) where the relevant build variables are set by the `build` subcommand [here](https://github.com/pypa/setuptools/blob/9cc2f5c05c333cd4cecd2c0d9e7c5e208f2a3148/setuptools/_distutils/command/build.py#L52) and [here](https://github.com/pypa/setuptools/blob/9cc2f5c05c333cd4cecd2c0d9e7c5e208f2a3148/setuptools/_distutils/command/build.py#L112). it turns out us running `python setup.py clean` was already redundant with `rm -rf build` on the next line i built two releases, one on the latest commit in this PR and another on https://github.com/certbot/certbot/commit/44f1dd677b75da27f12374fd34d68306ae6f615c before the switch to `python -m build`. a simple diff of the resulting tarballs and wheels fails, presumably because of metadata differences, but after untaring or unzipping the files, the contents are identical for all of our built packages