100 Commits
Author SHA1 Message Date
Dag WieersandGitHub da1bed8932 Moving ACI support to aciguru (#67348) 2020-02-13 19:36:35 +01:00
Dag Wieersandansibot 6abf59cac8 Use module references 2019-12-18 06:22:05 -05:00
Dag WieersandJordan Borean 521d6465f6 win_chocolatey: Fix error when choco.exe not found (#53115)
* win_chocolatey: Fix error when choco.exe not found

* Slight tweak to check and added changelog fragment

* Removed ignore rule that's no longer needed
2019-11-15 12:46:36 +10:00
Dag WieersandGitHub 26e0e4be01 ACI/MSO: Use get() dict lookups (#63074)
This improves the reliability of the modules somewhat.
2019-11-06 18:24:11 +01:00
Dag WieersandGitHub 4bfa3b2bf8 aci_contract_subject: Remove missing entry (#63044)
This fixes a `KeyError: 'filter'` exception.
2019-10-02 21:46:48 +02:00
Dag WieersandGitHub 2995ae4ffd Fix MSO examples (#62835)
Fix reported issues with the examples.
2019-09-25 18:29:36 +02:00
Dag Wieersandansibot 7fa1e4f70f Fix sanity checks (#62782)
This PR fixes all new ACI sanity issues.
2019-09-24 09:00:00 -04:00
Dag WieersandGitHub 7d344d00ef Fix whitespace issue in filter (#62768)
This fixes a reported issue.
2019-09-24 02:05:13 +02:00
Dag WieersandGitHub 61647731e2 Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
2019-07-05 15:02:29 +02:00
Dag Wieersandansibot fd95c7b506 Fix CI issue 2019-05-31 14:12:20 -04:00
Dag WieersandAlicia Cozine e381135ace Update BOTMETA with latest community changes (#57064)
This is the requested change from #56816 for 'dch'
2019-05-29 13:43:12 -05:00
Dag WieersandAlicia Cozine fe1f1c4541 Update BOTMETA with latest community changes (#57063)
This is the requested change for 'koladiya'
2019-05-29 11:16:44 -05:00
Dag WieersandAlicia Cozine a3b13bcf0d Update BOTMETA with latest community changes (#57053)
These have all confirmed in #56816
2019-05-28 09:59:14 -05:00
Dag WieersandGitHub f6e8492942 Update BOTMETA with latest community changes (#57049)
This reflects #56816 but only affects me.
2019-05-28 13:30:30 +02:00
Dag WieersandGitHub 4f89c1d508 Revert "ACI: Implement encoded query_string" (#56783)
This reverts commit 1690af04fe.
2019-05-22 15:44:22 +02:00
Dag WieersandAlicia Cozine eac7f1fb58 dev_guide: Various small updates (#53273)
* Document the clarifications that I usually remark when doing reviews
* Update docs/docsite/rst/dev_guide/developing_modules_documenting.rst

Co-Authored-By: dagwieers <dag@wieers.com>
2019-05-09 18:44:28 -05:00
Dag WieersandGitHub beca3661a4 Fix some index-references and warn about remaining (#55727)
The ACI MultiSite PATCH API has a deficiency requiring some objects to be referenced by index.
This can cause silent corruption on concurrent access when changing/removing on object as
the wrong object may be referenced.

This PR removes some references by index, and documents this issue for
others.
2019-05-07 15:00:04 +02:00
Dag WieersandGitHub fcca1a124d Fix non-signature authentication (#56038)
Apparently everyone is using signature authentication these days.
2019-05-03 01:47:29 +02:00
Dag WieersandGitHub 9495ddbc21 ACI: Cleanup deprecated boolean behaviour (#55207)
* ACI: Cleanup deprecated boolean behaviour

* Remove from sanity ignore list
2019-04-16 14:13:24 +02:00
Dag WieersandGitHub b6bf910bf4 A static leaf is build from the pod id and leaf id (#55120) 2019-04-11 06:03:57 +02:00
Dag WieersandGitHub 9ac57dff61 MSO: Remove parameters to specify object ids (#55107)
MSO: Remove parameters to specify object ids
2019-04-10 23:06:02 +02:00
Dag WieersandGitHub 524a418a08 mso_st_deploy: Add state 'undeploy' (#55093)
This adds undeploy support to mso_schema_template_deploy.
2019-04-10 19:28:15 +02:00
Dag WieersandJordan Borean 025e9afe58 Windows pslint: Re-enable PSPossibleIncorrectComparisonWithNull (#55065)
* pslint fixes

* Fix up remaining sanity issues

* now fix silly errors I made
2019-04-10 15:30:38 +10:00
Dag WieersandJordan Borean e6935a285b Allow pslint as user (#55066) 2019-04-10 13:06:22 +10:00
Dag WieersandRené Moser 2ae1bdf863 win_region: Fix example (#55058) 2019-04-10 00:06:05 +02:00
Dag WieersandAlicia Cozine e6aff4dc3b Reduce ansible/ansible README to essentials (#52878)
* Reduce intro to essentials
2019-04-04 16:41:53 -05:00
Dag WieersandGitHub 2ef0946370 Warn on incorrect use of parameter, and remove fix for now (#54336)
* Fix wrong example, remove strictness and fix tests

It was obvious that (because of an incorrect example) people were using
the **xml** module incorrectly, specifying the `attribute` parameter
where it was not supported (i.e. ignored).

While this functionality would have been useful, it currently returns as
if the information was requested from the parent, so we cannot simply
make it to what would be expected.

Therefor the real solution is to provide a warning when we find
incorrect use, and deprecate this use. Then later we could implement
this functionality correctly.

While troubleshooting this issue, I found that in some cases our
integration tests were not being run when we expected it.

This fixes #53459

* Change warning

* Fix weird sanity test error

* Add a comment to the deprecate-test
2019-03-29 15:13:19 +01:00
Dag WieersandSam Doran e152b277cf Use locking for concurrent file access (#52567)
* Use locking for concurrent file access

This implements locking to be used for modules that are used for
concurrent file access, like lineinfile or known_hosts.

* Reinstate lock_timeout

This commit includes:
- New file locking infrastructure for modules
- Enable timeout tests
- Madifications to support concurrency with lineinfile

* Rebase, update changelog and tests

We need to specify ansible_python_interpreter to avoid running interpreter discovery and selecting the incorrect interpreter.

Remove the import of lock in known_hosts since it is not used.
2019-03-27 20:20:18 -04:00
Dag WieersandJohn R Barker a4cdf0d698 BOTMETA: Add Cisco integration/unit tests (#53654) 2019-03-19 23:13:29 +00:00
Dag WieersandGitHub c87efe1447 Fix typo 2019-03-12 13:34:52 +01:00
Dag WieersandGitHub f47191674e utilities: Clean up parameter types and add seealso (#53063)
* utilities: Clean up parameter types and add seealso

* Add inventory modules

* Add more references, clarify with-loops
2019-03-07 00:25:59 +01:00
Dag WieersandAlicia Cozine 6a845eca77 Windows: Improve the file-related seealso references (#53099) 2019-03-06 13:40:02 -06:00
Dag WieersandAlicia Cozine b011ec4638 Windows: Add parameter types (#53325)
This PR also includes:
-  Added missing seealso sections
2019-03-06 13:22:58 -06:00
Dag WieersandJohn R Barker c44e83ee13 rhevm: Fix validate-modules issues (#52436)
This PR includes:

* Adding parameter types
* Fix validate-modules issue
* Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
2019-03-06 14:05:14 +00:00
Dag WieersandGitHub a7eae0ae94 BOTMETA: Add $team_hcloud (#52694)
* BOTMETA: Add $team_hcloud

* fix github handle of lukas
2019-03-05 14:34:47 +01:00
Dag WieersandJohn R Barker 7fef7136e7 BOTMETA: Various fixes (#53303)
This PR includes:
- Add missing labels to YAML anchors
- Fix ACI YAML anchor (did not include modules)
- Add missing cisco label to ACI
- Fix networking label for nso
- Add missing YAML anchor for ios cfr. iosxr
2019-03-05 12:29:33 +00:00
Dag WieersandGitHub 1937c5301b MSO: Clarify the site-local modules in the index (#53301) 2019-03-05 00:41:50 +01:00
Dag WieersandGitHub 1a4e983364 mso_st_contract_filter: Add support for directives (#53300)
This PR also fixes an issue introduced in the previous commit.
2019-03-05 00:26:45 +01:00
Dag WieersandGitHub 4e7a3df1e6 MSO: New module to manage local site VRF region CIDR subnets (#53254)
This adds a new module to manage local site VRF region CIDR subnets on ACI MultiSite schema templates.
2019-03-04 02:13:03 +01:00
Dag WieersandGitHub 121c2d90dc MSO: New module to manage local site VRF region CIDRs (#53253)
This adds a new module to manage local site VRF region CIDRs on ACI MultiSite schema templates.
2019-03-04 02:11:20 +01:00
Dag WieersandGitHub 38afee0937 MSO: New module to manage local site VRFs (#53251)
This adds a new module to manage local site VRFs on ACI MultiSite schema templates.
2019-03-04 02:11:01 +01:00
Dag WieersandGitHub 9294943f6c MSO: New module to manage local site VRF regions (#53252)
This adds a new module to manage local site VRF regions on ACI MultiSite schema templates.
2019-03-04 02:10:38 +01:00
Dag WieersandGitHub 095eb59f5a MSO: New module to manage local site EPG subnets (#53250)
This adds a new module to manage local site EPG subnets on ACI MultiSite schema templates.
2019-03-04 02:02:58 +01:00
Dag WieersandGitHub 6551b4640c MSO: New module to manage local site BD l3outs (#53249)
This adds a new module to manage local site BD l3outs on ACI MultiSite schema templates.
2019-03-04 01:55:55 +01:00
Dag WieersandGitHub b5e1f1bf18 MSO: New module to manage local site BDs (#53248)
This adds a new module to manage local site BDs on ACI MultiSite schema templates.
2019-03-04 01:54:25 +01:00
Dag WieersandGitHub eeccf0e2e6 MSO: New module to manage local site EPG subnets (#53247)
This adds a new module to manage local site EPG subnets on ACI MultiSite schema templates.
2019-03-04 01:49:58 +01:00
Dag WieersandGitHub e1b79d0aae MSO: New module to manage local site static ports (#53246)
This adds a new module to manage local site EPG static ports on ACI MultiSite schema templates.
2019-03-04 01:47:04 +01:00
Dag WieersandGitHub e6275c7f12 MSO: New module to manage local site static leafs (#53245)
This adds a new module to manage local site static leafs on ACI MultiSite schema templates.
2019-03-04 01:44:50 +01:00
Dag WieersandGitHub 9b5741090f MSO: New module to manage local site EPGs (#53244)
This adds a new module to manage local site EPGs on ACI MultiSite schema templates.
2019-03-04 01:42:13 +01:00
Dag WieersandGitHub cd3890b4e7 MSO: New module to manage local site ANPs (#53243)
This adds a new module to manage local site ANPs on ACI MultiSite schema
templates.
2019-03-04 01:38:15 +01:00
Dag WieersandGitHub 8c659c35ec mso_st_bd_subnet: Fix various issues (#53240)
This PR includes:
- Rename 'ip' to 'subnet' as that's what we're managing
- Small improvement in logic
2019-03-04 01:27:14 +01:00
Dag WieersandGitHub 12a949229d mso_stae_subnet: Fix various issues (#53239)
This PR includes:
- Rename 'ip' to 'subnet' as that's what we're managing
- Use the correct module name in the examples
- Small improvement in logic
2019-03-04 01:26:58 +01:00
Dag WieersandGitHub 85eb8c30a6 MSO: Clean up internal references (#53242)
During the development of the new site modules the use of references is
more common and this urged making the mechanism more simple overall.
2019-03-04 01:26:47 +01:00
Dag WieersandGitHub e4093fbad4 mso_st_filter_entry: Fix various issues (#53241)
This PR includes:
- Use the correct module name in the examples
- Small improvement in logic
- Fix an issue where updating an existing entry could reset to defaults
2019-03-04 01:20:02 +01:00
Dag WieersandGitHub 9c2879d8e6 mso_s_t_anp_epg: Fix incompatibility with newer MSO (#53238)
Due to a change with the backend contractRelationships is required.
2019-03-04 01:13:30 +01:00
Dag WieersandGitHub 33ae15e070 mso_schema_template: Fix examples (#53237)
The examples were using the wrong module.
2019-03-04 01:13:16 +01:00
Dag Wieersandansibot 4e6c113bf0 uri/win_uri: Make method a free text field (#49719)
* uri/win_uri: Make method a free text field

Since various interfaces introduce their own HTTP method (e.g. like
PROPFIND, LIST or TRACE) it's better to leave this up to the user.

* Fix HTTP method check in module_utils urls

* Add integration test for method UNKNOWN

* Clarify the change as requested during review
2019-02-28 15:55:18 -05:00
Dag Wieersandansibot aaec8e6b47 Fix types 2019-02-27 19:15:13 -05:00
Dag Wieersandansibot ccc94c0660 Fix types 2019-02-27 19:15:03 -05:00
Dag Wieersandansibot 80bdd21317 Fix types 2019-02-27 18:58:46 -05:00
Dag Wieersandansibot d5ef4d1e33 Fix types 2019-02-27 18:58:37 -05:00
Dag Wieersandansibot 9abee0385d Fix type 2019-02-27 18:58:29 -05:00
Dag WieersandJohn R Barker fe2b159106 Reorganize Cisco technologies (#52876) 2019-02-27 16:43:53 +00:00
Dag WieersandGitHub 4e058a77ad MSO: Clean up argspec (#53067)
This PR includes:
- Removing aliases (these are now modules in 2.8)
- Cleaning up argspec
2019-02-27 17:14:58 +01:00
Dag WieersandBrian Coca 8f671e6cff Squash redundant tasks (#52628)
This PR includes some changes to reduce the number of tasks.
2019-02-26 15:09:42 -05:00
Dag WieersandGitHub 2561fd7000 ACI: Add seealso sections to various modules (#52988) 2019-02-26 15:44:18 +01:00
Dag WieersandGitHub 076562e5c2 ACI: Various changes and doc updates (#52957)
* ACI: Various changes and doc updates

* Fix typos
2019-02-26 14:55:40 +01:00
Dag WieersandGitHub b808b06607 ACI: Fix examples in documentation (#52958)
* ACI: Fix examples in documentation

* Fix typo
2019-02-26 03:00:00 +01:00
Dag WieersandGitHub 3ced545d06 validate-modules: Fix some files modules (#52440)
This PR includes:
- fixes to validate-modules issues

All modules already include parameter types.

The remaining files-modules have action plugins, so comparing to the arg_spec only is incorrect.
2019-02-25 13:29:31 +01:00
Dag WieersandGitHub 4670e41a30 validate-modules: Fix net_tools modules (#52489)
This PR includes:

* Fixes to open validate-modules issues
* Adding parameter types
2019-02-25 13:27:35 +01:00
Dag WieersandJordan Borean 3d1dd0e599 Windows: Add backup parameter to modules (#50033)
* Windows: Add backup parameter to modules

This PR adds a backup infrastructure for modules.

* Fixes based on review feedback

* Various fixes to check-mode and backup

* Add integration tests

* Fix win_xml integration test

* Add backup support to copy action plugin

* Added integration tests

* Improve test efficiencies and other minor impv
2019-02-25 11:37:25 +10:00
Dag WieersandAlicia Cozine c476ab942b BOTMETA: Update $team_aci (#52715) 2019-02-22 16:54:39 -06:00
Dag Wieersandansibot 4e6ca4b21b BOTMETA: Add ProxySQL to $team_mysql (#52054)
ProxySQL uses mysql module_utils so becomes part of MySQL WG.
2019-02-22 13:40:58 -05:00
Dag WieersandJohn R Barker cd77ea3eb3 serverless: Fix validate-modules issues (#52435)
This PR includes:

* Adding parameter types
* Fix validate-modules issue
* Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
2019-02-22 11:35:48 +00:00
Dag WieersandJohn R Barker 365ded2df6 nmcli: Fix known validate-modules issues (#52493)
This PR includes:
- Adding parameter types
- Fix validate-modules issue
- Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
2019-02-22 11:28:57 +00:00
Dag WieersandJohn R Barker 1f9da61bce cyberark_user: Fix validate-modules issue (#52515)
This PR includes:
- validate-modules fixes
- fix parameter types
- code bugfix
2019-02-22 11:28:04 +00:00
Dag WieersandJohn R Barker 0d1aebe064 kubernetes: Clean up parameter types (#52543)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-22 11:27:11 +00:00
Dag WieersandJohn R Barker 7654d6e9a8 BOTMETA: Updated $team_macos (#52723)
Add new macOS WG member.
2019-02-22 10:14:48 +00:00
Dag WieersandSandra McCann 04a2a22c0f zabbix: Clean up parameter types (#52516)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:56:58 -05:00
Dag WieersandSandra McCann e435c71c16 validate: Clean up parameter types (#52521)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:52:10 -05:00
Dag WieersandSandra McCann 2cb9d9da14 return_common: Clean up parameter types (#52524)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:50:11 -05:00
Dag WieersandSandra McCann 1d3eb0bafd online: Clean up parameter types (#52527)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:48:30 -05:00
Dag WieersandSandra McCann 953d4c8a7f oneview: Clean up parameter types (#52537)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:47:45 -05:00
Dag WieersandSandra McCann 4dce9c4da9 manageiq: Clean up parameter types (#52538)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:47:13 -05:00
Dag WieersandSandra McCann a7846391a9 ldap: Clean up parameter types (other) (#52541)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:46:22 -05:00
Dag WieersandSandra McCann 4c97481337 keycloak: Clean up parameter types (#52542)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 15:44:41 -05:00
Dag WieersandSandra McCann aa83307c68 doc_fragments: Clean up parameter types (other) (#52182)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:23:26 -05:00
Dag WieersandGitHub 8c74df5e67 validate-modules: Fix all system modules (#52384)
This PR includes validate-modules fixes for all system modules.
Except a few that are deliberately implemented like this.
2019-02-19 15:42:14 +01:00
Dag WieersandJohn R Barker 409345ee97 utm: Clean up parameter types (#52517)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 12:19:32 +00:00
Dag WieersandJohn R Barker 5ee378430b tower: Clean up parameter types (#52522)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 12:18:38 +00:00
Dag WieersandJohn R Barker e7df487a6c rabbitmq: Clean up parameter types (#52525)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement

This breaks out PR #52182
2019-02-19 12:17:28 +00:00
Dag WieersandGitHub 75ed19a561 BOTMETA: Time to move on 2019-02-18 23:22:40 +01:00
Dag WieersandMatt Martz d3bebb661c validate-modules: Harmonize error messages (#52385)
When fixing known errors, the error messages did not make it easy to
find what parameter was having issues (because it was not in the errpr).

Now it consistently starts with the parameter name, and then shows first
the argspec and then the documentation values.

This helps quick assessments.
2019-02-18 09:38:14 -06:00
Dag WieersandGitHub b4802350ec Fix one issue (#52370) 2019-02-15 22:33:31 +01:00
Dag WieersandGitHub 677c04c01d Sanity fixes to parameter types (#52325) 2019-02-15 16:58:58 +01:00
Dag WieersandMatt Clay c2fb581414 Fix various sonarcloud issues
This fixes various reported bugs through sonarcloud at:
https://sonarcloud.io/project/issues?id=Rodney-Reis_ansible&resolved=false&types=BUG
2019-02-15 07:19:04 -08:00
Dag WieersandMatt Clay f9ab9b4d68 Assorted pylint fixes 2019-02-15 06:54:47 -08:00
Dag WieersandJohn R Barker 25323155d2 doc_fragments: Clean up parameter types (cloud) (#52177)
* module_utils: Clean up parameter types (cloud)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* More cloud stuff

* Fix reported issue

* Fix quotes

* Use correct type

* Fix quotes

* Fix quotes

* Fix quotes

* Fix typo

* Fix boolean
2019-02-15 12:21:20 +00:00
Dag WieersandGitHub 203caf2570 Fix module issues (#52209) 2019-02-15 12:57:20 +01:00
Dag WieersandGitHub cedd9d9926 crypto: Fix known issues in modules (#52302)
* crypto: Fix known issues in modules

This fixes a few issues reported by 'validate-modules'.

* Fix whitespace
2019-02-15 11:46:44 +01:00