Commit Graph
100 Commits
Author SHA1 Message Date
Peter Eckersley 9aa93c05c1 Simplify the ocsp_revoked() return type
- we weren't reacting to None, so call it False instead
2016-12-22 15:35:29 -08:00
Peter Eckersley 19143d8303 Increase test coverage 2016-12-22 13:07:00 -08:00
Peter Eckersley 7014ab5fd0 lint 2016-12-21 23:20:19 -08:00
Peter Eckersley 61e822a897 Add a few more tests 2016-12-21 21:50:19 -08:00
Peter Eckersley e2d8630f5e py3fix 2016-12-21 14:42:35 -08:00
Peter Eckersley 0ed3213989 Remove --check-ocsp flag
- Might have been occasionally useful, but simplicity
 - Add some missing tests, remove some obsolete ones
2016-12-21 14:38:26 -08:00
Peter Eckersley 76b8c53566 Tests for ocsp.py, and associated fixes 2016-12-21 14:38:26 -08:00
Peter Eckersley f495863da9 Check --check-ocsp flags, and test those checks 2016-12-21 14:38:26 -08:00
Peter Eckersley 509f4029bb more py3 fixes 2016-12-21 14:38:26 -08:00
Peter Eckersley 7d02b8dbd5 py3fix 2016-12-21 14:38:26 -08:00
Peter Eckersley fcf7387c3d Don't crash if openssl is missing 2016-12-21 14:38:26 -08:00
Peter Eckersley 011f6055d4 Better message 2016-12-21 14:38:26 -08:00
Peter Eckersley bf6084db61 With mixed staging/prod lineages, it might not be correct to stop OCSPing
- One lineage might fail, and a later one succeed
2016-12-21 14:38:26 -08:00
Peter Eckersley 15ed372df6 Fix existing tests 2016-12-21 14:38:26 -08:00
Peter Eckersley 03f312e653 Allow filtering of "certbot certificates output" with --config-name or -d 2016-12-21 14:38:26 -08:00
Peter Eckersley e5e5db24d7 CLI flag for controlling ocsp checking now works 2016-12-21 14:38:26 -08:00
Peter Eckersley 840c584cbd Make the OCSP checker a class
(Since it contains a reasonable amount of system state)
2016-12-21 14:38:26 -08:00
Peter Eckersley 7a18a124ce Better error handling 2016-12-21 14:38:26 -08:00
Peter Eckersley fe36e336a8 Run with both old and new versions of openssl 2016-12-21 14:38:26 -08:00
Peter Eckersley 245b84ab78 Format CLI to keep modern openssls happy
- This is somewhat ominous
2016-12-21 14:38:26 -08:00
Peter Eckersley ac02cd9cb8 ocsp checking needs -verify_other
https://community.letsencrypt.org/t/unable-to-verify-ocsp-response/7264
2016-12-21 14:38:26 -08:00
Peter Eckersley 40e29bb95f begin implementing OCSP checking for "certificates" 2016-12-21 14:38:20 -08:00
Peter Eckersley e28017a110 Lint 2016-09-21 16:45:42 -07:00
Peter Eckersley f6c605cd15 Add tests for the --preferred-challenges cli parser 2016-09-21 16:43:35 -07:00
Peter Eckersley 107a3e6aa9 Allow & document --preferred-challenges dns,http 2016-09-21 16:17:31 -07:00
Peter Eckersley 6c066ef10c Better section link 2016-09-21 15:24:15 -07:00
Peter Eckersley 9219617b0c Nicer table formatting 2016-09-21 15:20:06 -07:00
Peter Eckersley 741a57c976 Accept --preferred-challenges "dns-01, http-01" 2016-09-21 15:02:03 -07:00
Peter Eckersley a18a8f051d Improve documentation for --preferred-challenges 2016-09-21 15:01:01 -07:00
Peter Eckersley df61b0e349 Check for comments more accurately 2016-08-18 13:56:15 -07:00
Peter Eckersley 015d103f8d Unbreak using.html#plugins links
Fixes: #3422
2016-08-16 18:46:19 -07:00
Peter Eckersley cfefda7267 Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 18:30:29 -07:00
Peter Eckersley 7da7d47e8a Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 17:40:49 -07:00
Peter Eckersley 1e0bd2129f Merge remote-tracking branch 'origin/master' into filepath_refactor 2016-08-10 12:25:41 -07:00
Peter Eckersley 9c168017ae That was not the correct magic 2016-08-08 18:17:02 -07:00
Peter Eckersley b5fa0fbad7 This is reportedly the correct magic 2016-08-08 18:08:11 -07:00
Peter Eckersley 712bd9ee6b Copy nginx options file into integration testing environment 2016-08-08 17:58:22 -07:00
Peter Eckersley 0504882e08 Always newline config edits
Even if they're transient
2016-08-08 17:50:20 -07:00
Peter Eckersley f0c2ed3059 Lint, improve coverage, rm unused code 2016-08-08 15:45:49 -07:00
Peter Eckersley 262eb778fe Update Apache plugin supported OSes 2016-08-08 15:29:23 -07:00
Peter Eckersley da7e429125 Work around horrible spaciness API usage bug 2016-08-08 15:14:06 -07:00
Peter Eckersley 7deb1f0ad6 Fix bug with UnpsacedList.insert to final position
- which only applied when the list actually contained spaces
2016-08-08 12:15:18 -07:00
Peter Eckersley 0ade03b7bf Merge remote-tracking branch 'origin/master' into no-conflicting-declarations3 2016-08-05 15:41:54 -07:00
Peter Eckersley 460f49778f Fix tests for our new spacey, commented world 2016-08-05 15:37:01 -07:00
Peter Eckersley cdc894601c Tolerate our own added newlines 2016-08-05 15:36:40 -07:00
Peter Eckersley 3a2df72bce Add newlines to the ends of blocks more correctly 2016-08-05 15:36:24 -07:00
Peter Eckersley a8abde7d8d Merge remote-tracking branch 'origin/no-conflicting-declarations3' into no-conflicting-declarations3 2016-08-05 14:47:41 -07:00
Peter Eckersley 61b81b877d Merge remote-tracking branch 'origin/master' into no-conflicting-declarations3 2016-07-29 17:28:29 -07:00
Peter Eckersley 89758decbb Fix a test 2016-07-29 17:28:22 -07:00
Peter Eckersley fbf8a27157 Slight tweaks 2016-07-28 19:05:08 -07:00
Peter Eckersley 9e9c4dfcf5 fix test 2016-07-27 16:55:23 -07:00
Peter Eckersley d55580025f Extra newlines & spacing 2016-07-27 16:29:30 -07:00
Peter Eckersley 2feeb50109 Fix spacing of nginx redirect blocks 2016-07-27 16:00:43 -07:00
Peter Eckersley fbadf7550c Also put -q in certonly 2016-07-26 19:20:02 -07:00
Peter Eckersley df42f69d8c Address review comments 2016-07-26 18:08:21 -07:00
Peter Eckersley e1f560dca3 Neaten 2016-07-26 17:23:24 -07:00
Peter Eckersley 85d9ab4d5c UnspacedList._spaced_position: support the slice at the end fo the list
- Which is needed for .insert()ing at the end, for instance.
2016-07-21 13:39:13 -07:00
Peter Eckersley e5cb04ee7d A couple of fixes 2016-07-21 13:26:57 -07:00
Peter Eckersley a49d26f607 Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-07-20 16:56:23 -07:00
Peter Eckersley e3ab49a93b Rework "value" parser:
- Now handles any${VAR_SUBSTITUTION}inthemiddle/of/values
  - Don't use a single giant janky Regex; use small ones and have PyParsing
    combine them
2016-07-15 17:11:04 -07:00
Peter Eckersley b6966fc05e lint 2016-07-15 17:11:04 -07:00
Peter Eckersley 7183896ed7 Preserve spaces before comments at the beginning of a file 2016-07-15 17:11:04 -07:00
Peter Eckersley b7cf928852 Parse charset_map correctly
(though we still don't emit it correctly...)
2016-07-13 17:17:45 -07:00
Peter Eckersley 68500cd436 Don't allow dollar_var to swalllow characters like "{" 2016-07-09 15:13:09 -07:00
Peter Eckersley 894af91777 Fix test 2016-07-08 14:09:26 -07:00
Peter Eckersley 0bedeb449a Refactor path_surgery into plugins.util so that nginx can call it 2016-07-08 14:03:21 -07:00
Peter Eckersley 757a8ddae7 Fixes & tests 2016-07-08 13:21:37 -07:00
Peter Eckersley cecac803a0 Do this more cleanly 2016-07-08 13:21:37 -07:00
Peter Eckersley a322f44f2b Implement PATH fallback for apachectl search 2016-07-08 13:21:37 -07:00
Peter Eckersley 754b7956b3 Make the error even more informative 2016-07-08 13:21:37 -07:00
Peter Eckersley c3244df951 more doc improvements 2016-07-08 10:12:57 -07:00
Peter Eckersley ecd1ca4645 grammatical improvement 2016-07-08 10:05:56 -07:00
Peter Eckersley 204c3f0dfb Start using multi-topic CLI flag documentation 2016-07-07 15:33:29 -07:00
Peter Eckersley d96278505e Fix test 2016-07-06 20:08:01 -07:00
Peter Eckersley 4a9846b911 Begin work on multi-topic help listings 2016-07-06 20:02:40 -07:00
Peter Eckersley 83857baf30 Update / cleanup installer error message
Closes: #1756
Updating since we landed #788 and have shipped Apache support almost
everywhere
2016-07-06 15:39:59 -07:00
Peter Eckersley 4b84538c8c Address review comments 2016-07-06 12:57:16 -07:00
Peter Eckersley fd35a1c724 Explain why Apache [appears] not to be installed
Would help debug #3244
2016-07-06 12:43:48 -07:00
Peter Eckersley be8f0bc53b Do a better job of parsing map patterns 2016-06-30 15:29:38 -07:00
Peter Eckersley db8ddac4e2 lint & tweak 2016-06-30 15:13:35 -07:00
Peter Eckersley 8c3e443de9 First attempt at mitigating #3206 2016-06-30 15:07:28 -07:00
Peter Eckersley 7b50960ac0 Address review comments 2016-06-29 13:57:58 -07:00
Peter Eckersley bdbdd826de Extra comment & concision 2016-06-27 12:50:06 -07:00
Peter Eckersley 3e9bf2f35f Tests for UnspacedList.is_dirty() 2016-06-27 12:50:06 -07:00
Peter Eckersley 6017a6cb6d Only write nginx config files if we've modified them 2016-06-27 12:44:36 -07:00
Peter Eckersley 184f54cbc7 cosmetic improvements 2016-06-27 12:36:28 -07:00
Peter Eckersley fdbb69930b Tweak the NotImplementedError cases 2016-06-27 12:00:41 -07:00
Peter Eckersley 23f0ccbc8e Address review issues 2016-06-25 12:28:47 -07:00
Peter Eckersley e93ace79cc Test coverage & fix 2016-06-25 12:06:43 -07:00
Peter Eckersley e0691ede2c Provide clear log messages when Apache tries a default vhost 2016-06-25 10:59:41 -07:00
Peter Eckersley f6069c2297 Explain what is happening when the user cancels vhost selection 2016-06-25 10:59:41 -07:00
Peter Eckersley 98d261596c Raise NotImplemented for all problematic list methods 2016-06-24 19:16:05 -07:00
Peter Eckersley 0dc4639cbf Be more explicit about range policing
(rather than doing it in some roundabout crazy way)
2016-06-24 18:56:30 -07:00
Peter Eckersley 880cb03191 Make assertions about index policing 2016-06-24 18:50:18 -07:00
Peter Eckersley 6a938f2ee7 Fix docstring nit 2016-06-24 16:52:02 -07:00
Peter Eckersley 8f0a5fdc66 Fix a bug in the new index calculations 2016-06-24 16:48:30 -07:00
Peter Eckersley 20b92a3c1f Add some test coverage 2016-06-24 16:48:22 -07:00
Peter Eckersley 9da533d92e Be more succinct 2016-06-24 16:13:12 -07:00
Peter Eckersley e415a4d402 For now, instead, consider this NotImplemented 2016-06-24 14:36:23 -07:00
Peter Eckersley ad13b525b2 For reference, a buggy attempt to implement slicing
but slice assignment seems to mangle the .spaced list in some cases
2016-06-24 14:35:42 -07:00