starred/certbot-certbot-1
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-06 13:32:04 +02:00
Code Issues Packages Projects Releases Wiki Activity
3,413 Commits 879 Branches 157 Tags
762e9e578f3f31760e151c00c8d2dff9510ba483
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Peter Eckersley db1f0a6688 Fix pip / nginx heisenbug 
Closes: #1072
 2015-10-21 13:54:29 -07:00
Peter Eckersley f130cb470c Don't find "-v" in "--version" 
Fixes #1065
 2015-10-21 10:58:36 -07:00
Peter Eckersley e7182848a0 Keep @bmw's sense of aesthetics happy :) 2015-10-20 14:04:58 -07:00
Peter Eckersley b01bf571ca more typos 2015-10-20 14:03:06 -07:00
Peter Eckersley 05293cd597 typosquash 2015-10-20 14:01:29 -07:00
Peter Eckersley dde3e685f0 Fix stray --standalone help 
And a few layout nits
 2015-10-20 13:49:44 -07:00
Peter Eckersley 738684d437 Revert to "run" as the default in all cases 2015-10-20 13:28:56 -07:00
Peter Eckersley 719cbdb488 --apache etc should be documented in the "plugins" section 2015-10-20 10:58:47 -07:00
Peter Eckersley 2c4d4a8169 "letsencrypt everything" is not yet implemented :/ 2015-10-20 10:35:17 -07:00
Peter Eckersley efe51e02be Explain the --standalone change in defaults 2015-10-20 10:34:31 -07:00
Peter Eckersley 54a738492b Fix typo 2015-10-20 01:22:04 -07:00
Peter Eckersley adcb0052a1 Implement --standalone as specified. 
Closes #1036
 2015-10-20 00:30:44 -07:00
Peter Eckersley 363dffd8a6 Comment out a test that requires slightly doubtful infrastructure 2015-10-19 19:51:02 -07:00
Peter Eckersley 51ed2b681f We're not mocking out plugins 
So we don't need infrastructure for it
 2015-10-19 19:41:37 -07:00
Peter Eckersley e384a1fe28 Catch some excessive policing of installers 2015-10-19 19:35:53 -07:00
Peter Eckersley 72589bcae3 Lint 2015-10-19 19:31:09 -07:00
Peter Eckersley 6460a3b50e Dial back the "authenticator doesn't make sense in install mode" message 
Since it was breaking integration tests
 2015-10-19 19:27:36 -07:00
Peter Eckersley eeeb66e58a document -d domain 
Closes: #285 #787

we may want to implement the other thing soon, but for now documenting what we
have
 2015-10-19 19:15:11 -07:00
Peter Eckersley 484e8ef6fe Not trying to mock out plugins just yet 2015-10-19 19:11:05 -07:00
Peter Eckersley eac513d73b Offer more specific help if no installer is present 
Fixes: #896
 2015-10-19 17:21:47 -07:00
Peter Eckersley 26e7037794 Fix a mock type error 2015-10-19 12:15:11 -07:00
Peter Eckersley 39ae9bdf43 Document a somewhat cryptic function 2015-10-19 12:06:39 -07:00
Peter Eckersley 6e69e58402 Make more tests run regardless of local plugin state 2015-10-19 12:03:11 -07:00
Peter Eckersley e05073c33e debugging 2015-10-19 10:37:39 -07:00
Peter Eckersley 63f4f11360 Test "install --nginx" w/ misconfiguration 2015-10-18 11:05:58 -07:00
Peter Eckersley 995c1dfb83 More sphinxiness, more clarity 2015-10-18 11:05:46 -07:00
Peter Eckersley d6345a47c5 Fix some bugs & immprove test cases 2015-10-18 02:34:24 -07:00
Peter Eckersley 4996e9b678 Installers are actually useful in auth mode 2015-10-17 14:28:38 -07:00
Peter Eckersley c89e192ee7 Concision is beautiful 2015-10-17 14:01:54 -07:00
Peter Eckersley f4f6b98f31 Use new plugin selection logic for install 2015-10-17 13:57:52 -07:00
Peter Eckersley 7c92db095f Use new selection logic for "auth" 
Also: why was auth selecting installers?
 2015-10-17 13:43:49 -07:00
Peter Eckersley a841c4fc5d More nits 2015-10-17 13:13:00 -07:00
Peter Eckersley f7bfb5ba8d Sphinxify docstrings, plugins plumbing 2015-10-17 12:54:56 -07:00
Peter Eckersley 8d4f414e09 Move ConfiguratorError to errors.py 2015-10-17 12:47:05 -07:00
Peter Eckersley f0faf91b82 lint! 2015-10-16 18:34:57 -07:00
Peter Eckersley 57e15c52d7 Test actually works now :) 2015-10-16 18:28:38 -07:00
Peter Eckersley 36432e35f7 keep cover happy 2015-10-16 18:19:22 -07:00
Peter Eckersley 9efdd095ca Merge branch '919' into cli 2015-10-16 17:46:43 -07:00
Peter Eckersley dcf8ea4e97 Logic for setting configurators assumed they were really being set 
(They might not be)
 2015-10-16 17:38:17 -07:00
Peter Eckersley 3d6ecc114b lintmonster 2015-10-16 10:41:05 -07:00
Peter Eckersley 9bde3b7084 Support for --apache and --nginx now working. 
- Along with much better error messages for misconfigured plugins
 2015-10-16 10:34:29 -07:00
Peter Eckersley 64385cbd80 Disable nginx in bootstrap/venv.sh too 2015-10-15 00:09:42 -07:00
Peter Eckersley 0fb8e3c479 Move augeaus & venv references 2015-10-15 00:07:26 -07:00
Peter Eckersley 0fb00ca039 Try to make the dependencies link work 2015-10-15 00:03:49 -07:00
Peter Eckersley 4ef385d3ad Protect quotes on the way to the actual command 2015-10-14 23:56:56 -07:00
Peter Eckersley be77909ef2 Further fixes to the docs 2015-10-14 23:53:50 -07:00
Peter Eckersley 2794b762d6 Add a subtle progress bar 2015-10-14 23:43:05 -07:00
Peter Eckersley ab036e98e0 Do not ship letsencrypt-nginx until it's somewhat plausibly working 2015-10-14 23:06:20 -07:00
Peter Eckersley 39e489d03c Do not assume sudo is present 
- On Digital Ocean and perhaps other platforms, the user is root by default
  and sudo is uninstalled
 2015-10-14 23:03:18 -07:00
Peter Eckersley ecd987b8ca letsencrypt-auto now knows about -vvvv 2015-10-14 22:30:18 -07:00
Peter Eckersley 87000ac5c6 Move docker back into "using" 
It seems the changes removing bootstrap from "using" weren't commited earlier,
either
 2015-10-14 22:24:57 -07:00
Peter Eckersley 8a5d199ddf Try to make the "using" instructions as simple and accurate as possible 
Some of the verbose stuff we had before is really of historical/developer
interest only
 2015-10-14 18:35:34 -07:00
Peter Eckersley 2e0dc4fc50 Remove misleading Docker suggestion from the quick-install docs 
But keep it around in case anyone needs this?
 2015-10-14 18:25:14 -07:00
Peter Eckersley 7a1c37968c Make the UX clearer before sudo 2015-10-14 17:46:11 -07:00
Peter Eckersley 99793c54d6 More portability 2015-10-14 17:46:11 -07:00
Peter Eckersley b85e13de3f Add bootstrapping to letsencrypt-auto 2015-10-14 17:46:11 -07:00
Peter Eckersley 47eaf297fb Start a letsencrypt-auto script 
Which handles all venv-related tasks for installing from pip, and gives us
auto-updating.
 2015-10-14 15:57:09 -07:00
Peter Eckersley 4083cd42ad Explain email recovery better 2015-10-14 15:09:55 -07:00
Peter Eckersley c7732114cb Only test CLI for nginx plugin if it is present 
- Fixes 919
 2015-10-13 14:50:23 -07:00
Peter Eckersley 78be30d457 Basic support for --apache and --nginx 
- Also begin to clean up the code that integrates --configurator,
   --installer, and --authenticator inputs.
 2015-10-13 14:38:31 -07:00
Peter Eckersley 53d532cfe3 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-08 11:32:19 -07:00
Peter Eckersley 0ecfec56e2 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-05 12:05:27 -07:00
Peter Eckersley 321ae99035 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-05 11:53:57 -07:00
Peter Eckersley 289e8f441a Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-05 11:53:04 -07:00
Peter Eckersley 5b26ac14d2 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-03 01:33:00 -07:00
Peter Eckersley ecd0087df5 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt 2015-10-01 13:08:42 -07:00
Peter Eckersley 8041b35f99 Make sure the LICENSE file is accurate for first pre-relase 
- In general copyrights remain with their respective authors or authors'
   organizations, but with license granted by clause 5 of the Apache License.
 - Presently the plurality of the copyright in the client is held by EFF as a result of
   work-for-hire by jdkasten, bmw, schoen, pde, rolandshoemaker and jsha;
   or by Jakub Warmuz or his employer, Google.
 2015-09-30 19:23:17 -07:00
Peter Eckersley 7a7971ff8d Make sure the LICENSE file is accurate for first pre-relase 
- In general copyrights remain with their respective authors or authors'
   organizations, but with license granted by clause 5 of the Apache License.
 - Presently the plurality of the copyright in the client is held by EFF as a result of
   work-for-hire by jdkasten, jdkasten, bmw, schoen, pde, rolandshoemaker and jsha;
   or by Jakub Warmuz or his employer, Google.
 2015-09-30 19:06:16 -07:00
Peter Eckersley 43cb36807a Also test top level help 2015-09-30 17:00:09 -07:00
Peter Eckersley 11ca1108c2 Test cases for command line help 2015-09-30 16:53:08 -07:00
Peter Eckersley 2406fc0486 Go back to VERBS as a list 
The dictionary was destroying the ordering, which was important.
 2015-09-30 16:07:16 -07:00
Peter Eckersley 5ca1a27200 Keep the acme/ subtree compatible with strict pylinting 2015-09-30 15:31:32 -07:00
Peter Eckersley d85f42d71f Plugins don't need to be in HELP_TOPICS 
They're already added as topics automatically, though they do need to be in
the hand-written top level help.
 2015-09-30 15:29:29 -07:00
Peter Eckersley 2d578468bd Use a verb -> function table instead of eval() 
- plugins_cmd() not plugins() broke the more minimalist eval() approach
 - more wrangling was required to mock out calls via the VERBS table
 2015-09-30 12:32:44 -07:00
Peter Eckersley 2a3a111d62 Disable pylint invalid-name 
It's clearly making our code harder to read and write
 2015-09-30 12:10:16 -07:00
Peter Eckersley 1e3c92c714 Cleanup the verb -> subparser mapping 2015-09-30 11:49:46 -07:00
Peter Eckersley 627fca37b4 We didn't actually need to define --help as a verb 2015-09-29 18:55:59 -07:00
Peter Eckersley 18dacc528d Preserve all argparse parameters 
Try to restore all variants that applied to the different subcomannds
 2015-09-29 18:55:59 -07:00
Peter Eckersley 6b6bc03882 --cert-path was required for install and revoke 
Oops
 2015-09-29 17:14:40 -07:00
Peter Eckersley 2297349b95 lintian 2015-09-29 16:56:36 -07:00
Peter Eckersley 4437ec5586 Merge remote-tracking branch 'origin/master' into subargs 2015-09-29 14:49:32 -07:00
Peter Eckersley 05d439a339 Update cli tests 
We don't expect to error out if called with no args
 2015-09-29 14:48:40 -07:00
Peter Eckersley a0af023b14 --key-path is mandatory for install, optional for revoke 2015-09-29 14:48:26 -07:00
Peter Eckersley 2e0fd36c28 Improve flag and help processing 
* letsencrypt --help $SUBCOMMAND now works.
   Fixes #787 #819
 * subcommand arguments are now actually argument groups, so that all flags
   can be placed before or after subcommand verbs as the user wishes
   Fixes: #820

A limitation:

 * args like --cert-path were previously present for multiple verbs
   (auth/install/revoke) with separate docs; they are now in the "paths"
   topic.  That's fine, though it would be good to *also* list them when the
   user types letsencrypt --help install.
 2015-09-29 21:01:02 +00:00
Peter Eckersley ddc04c755b work in progress 2015-09-27 07:56:38 +00:00
Peter Eckersley a29afcc3bd Merge remote-tracking branch 'origin/master' into subargs 2015-09-27 07:54:30 +00:00
Peter Eckersley f3c2a096b5 Move the verb/subcommand to the end of the argparse line 2015-09-27 02:48:44 +00:00
Peter Eckersley 001d37f965 "-h" is also a ver. 2015-09-27 02:41:55 +00:00
Peter Eckersley e93593528d Merge branch 'master' of https://github.com/letsencrypt/letsencrypt 2015-09-27 02:09:48 +00:00
Peter Eckersley e7cbdc4f9a Revert reversion 
Revert "Revert "ManualAuthenticator -> Authenticator""

(commit required a pip reinstall but was not inherently broken)

This reverts commit 6f1b1570b1.
 2015-09-26 18:20:13 -07:00
Peter Eckersley 405bc99235 --help is effectively a verb for CLI purposes 2015-09-26 18:19:56 -07:00
Peter Eckersley 31fef196c0 --help is effectively a verb for CLI purposes... 2015-09-27 01:15:35 +00:00
Peter Eckersley 63e1c652e1 Undo damage from PEP8ification 2015-09-26 18:05:34 -07:00
Peter Eckersley 6f1b1570b1 Revert "ManualAuthenticator -> Authenticator" 
This reverts commit 81f0a973a3.

This was breaking the client.  Not sure if/how it passed any tests?
 2015-09-26 17:48:45 -07:00
Peter Eckersley 6c4d9e9324 Satisfy the lintmonster 2015-09-17 13:00:03 -07:00
Peter Eckersley 7c67df1076 traceback actually provides that \n 2015-09-17 12:48:07 -07:00
Peter Eckersley 0e3eae153e Hide tracebacks, but not the ultimate error itself 2015-09-17 12:29:42 -07:00
Peter Eckersley 18adec0bf2 Fix paths in test cases 2015-09-16 19:43:57 -07:00
Peter Eckersley 740f516561 Make boulder-start.sh more robust & helpful 2015-09-16 19:09:04 -07:00
Peter Eckersley 43a73f9a09 neaten 
neaten
 2015-09-16 17:26:27 -07:00