starred/certbot-certbot-1
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-28 08:44:24 +02:00
Code Issues Packages Projects Releases Wiki Activity
10,728 Commits 879 Branches 157 Tags
7a6752a68ed77e73c2b29ab20d3ca8927f4fa7b0
Commit Graph
10728 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Will GreenbergandGitHub 7a6752a68e Merge pull request #9601 from certbot/yaml/merge-notifications 
Create Workflow for Merge Notifications
 2023-03-08 14:07:53 -08:00
AlexisandGitHub 40486f3ab4 Fix indentation error 2023-03-08 09:22:17 -08:00
Brad WarrenandGitHub e3880b8912 Merge pull request #9608 from certbot/candidate-2.4.0 
Candidate 2.4.0
 2023-03-07 14:59:14 -08:00
Will Greenberg 242c96527b Bump version to 2.5.0 2023-03-07 13:18:07 -08:00
Will Greenberg 336ca91c26 Add contents to certbot/CHANGELOG.md for next version 2023-03-07 13:18:07 -08:00
Will Greenberg eeb88c0855 Release 2.4.0 v2.4.0 2023-03-07 13:18:06 -08:00
Will Greenberg b586672f78 Update changelog for 2.4.0 release 2023-03-07 13:17:25 -08:00
AlexisandGitHub 6c22e29875 Update to include sanitization for JSON file 2023-03-07 12:42:39 -08:00
alexzorinandGitHub 397f6bc20a docs: link for certbot-standalone-nfq plugin (#9607) 2023-03-07 05:40:39 -08:00
Will GreenbergandGitHub 48b499a38f Merge pull request #9600 from certbot/yaml/github-notify-weekly 
Create Weekly Notification Message for Certbot Team
 2023-03-06 12:18:15 -08:00
AlexisandGitHub 9f5e666702 Add a space for link selection 2023-03-03 11:09:56 -08:00
AlexisandGitHub 077cfb7861 Update .github/workflows/merged.yaml 
Escape any double quotes in the Title that may come in
 2023-03-03 11:06:27 -08:00
Brad WarrenandGitHub da01846d34 Remove unnecessary unittest (#9596) 
Now that we're using pytest more aggressively, I think we should start transitioning our tests to that style rather than continuing to use unittest. This PR removes some unnecessary uses of unittest I found.

I kept the test classes (while removing the inheritance from unittest.TestCase) where I felt like it added structure or logical grouping of tests.

I verified that pytest still finds all the tests in both this branch and master by running commands like:
```
pytest $(git diff --name-only master | grep -v windows_installer_integration_tests)
```
 2023-03-02 06:48:40 -08:00
Brad WarrenandGitHub cd467f2ce1 remove nose cruft (#9603) 2023-03-02 10:28:20 +11:00
alexzorinGitHubBrad Warren
 		bdd81a5961 google: ignore declare_namespace deprecation warnings (#9604) 
Fixes the nopin build on master.

---------

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
 2023-03-01 22:41:00 +00:00
AlexisandGitHub 87f8eca033 Update .github/workflows/notify_weekly.yaml 
Remove trailing char
 2023-02-28 17:39:17 -08:00
AlexisandGitHub 10b0fb6da0 Update .github/workflows/notify_weekly.yaml 2023-02-28 17:38:43 -08:00
AlexisandGitHub 44be66eed9 Update .github/workflows/notify_weekly.yaml 2023-02-28 17:38:23 -08:00
AlexisandGitHub bd3e3d1af1 Update .github/workflows/merged.yaml 2023-02-28 17:35:56 -08:00
AlexisandGitHub 97dd95329d Update merged.yaml 2023-02-28 13:31:06 -08:00
AlexisandGitHub 676863760a Create Workflow for Merge Notifications 
Sent to Mattermost Channel for Certbot Team to check and be generally aware of more granular merge events.
 2023-02-28 13:15:41 -08:00
AlexisandGitHub 173b832a8f Create Weekly Notification Message for Certbot Team 
Composes Mattermost message to team channel
 2023-02-28 12:38:53 -08:00
Mads JensenandGitHub 34e6b1e74d Remove redundant OCSPTestOpenSSL.tearDown (#9599) 2023-02-27 15:45:19 -08:00
Will GreenbergandGitHub 72be7999ed Merge pull request #9597 from certbot/revert-nginx-lua-detection 
nginx: fix performance regression caused by #9475
 2023-02-27 11:32:57 -08:00
Alex Zorin 1cb8c389b7 note the issue in the CHANGELOG 2023-02-25 09:32:38 +11:00
Alex Zorin 7c840a7dfd Revert "nginx: on encountering lua directives, produce a better warning (#9475)" 
This reverts commit c178fa8c0b.
 2023-02-25 08:45:19 +11:00
humanoid2050GitHubhumanoid2050Brad Warren
 		a42cffc351 generate multiarch images for non-architecture tags (#9586) 
* generate multiarch images for non-architecture tags

* lock docker build to legacy docker buider, and bugfix

* rename deploy.sh to deploy_by_arch.sh

* Update documentation related to multiarch Docker

* Consistent IFS value with respect to other scripts

Co-authored-by: humanoid2050 <humanoid2050@monolith>
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
 2023-02-22 17:53:45 -08:00
ohemorangeandGitHub 1cb48eca58 Remove update symlinks (#9592) 
* Add deprecation warning when update_symlinks is run

* Remove information about update_symlinks from help

* ignore our own warning and remove unused imports

* Update changelog
 2023-02-22 12:16:28 -08:00
Brad WarrenandGitHub 2a7eeef176 Polish snap_build.py (#9584) 
I wanted to try to make our tooling's messaging about it a little clearer.

While fixing my typo/bad English, we happened to hit a "Chroot problem" failure! See the logs for the CI first attempt at https://dev.azure.com/certbot/certbot/_build/results?buildId=6416&view=results.

Looking at these logs, I noticed three things:

1. This message I added is sometimes printed many times because we're still processing output from snapcraft. See https://dev.azure.com/certbot/certbot/_build/results?buildId=6416&view=logs&j=f44d40a4-7318-5ffe-762c-ae4557889284&s=1dfbc15b-7d0f-52a9-b1da-b17592bf94f8&t=07786725-57f8-5198-4d13-ea77f640bd5c&l=565.
2. snapcraft is complaining that we should be using --build-for now instead of --build-on. See https://dev.azure.com/certbot/certbot/_build/results?buildId=6416&view=logs&j=f44d40a4-7318-5ffe-762c-ae4557889284&s=1dfbc15b-7d0f-52a9-b1da-b17592bf94f8&t=07786725-57f8-5198-4d13-ea77f640bd5c&l=472.
3. Us canceling the Certbot build due to a "Chroot problem" happened 3 times in 3 seconds which seems very unlikely. See https://dev.azure.com/certbot/certbot/_build/results?buildId=6416&view=logs&j=f44d40a4-7318-5ffe-762c-ae4557889284&s=1dfbc15b-7d0f-52a9-b1da-b17592bf94f8&t=07786725-57f8-5198-4d13-ea77f640bd5c&l=587. I looked at the builds on launchpad and I only saw one Certbot build. I think what's happening is this code is causing the old build state to be reported so we error immediately.
I fixed all of these things in my follow up commits.

* polish chroot problem messaging

* only execute branch once
 2023-02-16 11:17:47 -08:00
Brad WarrenandGitHub a3c9371dc5 Use pytest assertions (#9585) 
* run unittest2pytest

The command used here was `unittest2pytest -nw acme/tests certbot*/tests`.

* fix with pytest.raises

* add parens to fix refactoring

* <= not <
 2023-02-16 16:02:02 +11:00
Brad WarrenandGitHub fedb0b5f9d Merge pull request #9581 from certbot/candidate-2.3.0 
Release candidate 2.3.0
 2023-02-14 15:13:44 -08:00
Will GreenbergandGitHub 1b904b62c9 Enable stale issue tracker (#9580) 2023-02-14 15:13:13 -08:00
Will Greenberg 941119f05b Bump version to 2.4.0 2023-02-14 12:44:32 -08:00
Will Greenberg 5d34a4d982 Add contents to certbot/CHANGELOG.md for next version 2023-02-14 12:44:32 -08:00
Will Greenberg d4b2d3202b Release 2.3.0 v2.3.0 2023-02-14 12:44:31 -08:00
Will Greenberg 1fe2d671cb Update changelog for 2.3.0 release 2023-02-14 12:42:21 -08:00
Will GreenbergandGitHub 9960c1907b Merge pull request #9577 from certbot/update-stale 
Disable stale for PRs
 2023-02-14 12:28:09 -08:00
Brad Warren 1da113d7d6 tweak comment 2023-02-14 08:55:07 -08:00
Brad Warren 64800c2b1f disable stale for PRs 2023-02-14 08:51:17 -08:00
Brad WarrenandGitHub dc07dfd07b Automatically run test files with pytest (#9576) 
* Switch to pytest

git grep -l unittest.main | xargs sed -i 's/unittest.main()/sys.exit(pytest.main([__file__]))/g'
git ls-files -m | xargs -I {} sh -c "echo 'import sys\nimport pytest' >> '{}'"
isort --float-to-top .

* add pytest dep

* use sys.argv
 2023-02-14 06:44:42 +11:00
alexzorinandGitHub 057524aa52 certbot-ci: fix crash in and simplify manual_http_hooks (#9570) 
There is a typo (`request` instead of `requests`) in the `auth.py` generated by this function:

https://github.com/certbot/certbot/blob/d792d398134f4f8b67debaf82e6e75635409c627/certbot-ci/certbot_integration_tests/utils/misc.py#L184-L191

that has [never ever succeeded](https://gist.github.com/alexzorin/ff2686b7123cea49f1e4107d1e7d95f5#file-master-log-L203-L208).

Moreover, this polling code is not necessary because `create_http_server` already polls until the HTTP server to come up, and the file we wrote to disk is guaranteed is immediately visible by the web server anyway.

* certbot-ci: fix crash in and simplify manual_http_hooks

* remove superfluous format argument

* remove unused argument
 2023-02-10 11:15:42 -08:00
Brad WarrenandGitHub 1bb09da270 Update and run isort (#9573) 
I want to use isort as part of https://github.com/certbot/certbot/issues/9572 because I want to do it programmatically, however, I felt like the config needed to be tweaked a bit due to it not understanding what is and is not our own code.

This PR updates the isort config so it recognizes our own modules and runs `isort .` from the root of the repo to update everything.

* update isort config

* run "isort ."
 2023-02-10 10:51:20 -08:00
Will GreenbergandGitHub d8d177ce72 Merge pull request #9575 from certbot/no-more-1.x 
Simplify release process and push everyone to 2.0
 2023-02-10 10:10:13 -08:00
Brad Warren 7d4535a836 tweak cloudxns condition 2023-02-09 19:35:37 -08:00
Brad Warren c32da71e8a fail faster if we try to use candidate 2023-02-09 18:56:43 -08:00
Brad Warren ca5f13d0e3 update snapcraft credentials 2023-02-09 18:55:29 -08:00
Brad Warren 91005a0422 always push to beta 2023-02-09 18:45:06 -08:00
Brad Warren f91d3ca828 remove 1.32.x deps 2023-02-09 18:42:41 -08:00
Brad Warren 3512d15dff Remove most progressive release tooling 2023-02-09 18:41:16 -08:00
Will GreenbergandGitHub caad4d93d0 Merge pull request #9574 from certbot/remove-test-test-code 
Remove code testing testing code
 2023-02-09 12:03:06 -08:00