secrets are now inherited; no need to be able to pass them into a workflow and we should not do so

This commit is contained in:
Erica Portnoy
2026-04-24 11:39:44 -07:00
parent a267b704e6
commit e9de9fdf76
+3 -12
View File
@@ -14,15 +14,6 @@ on:
description: 'Upload coverage to Codecov'
type: boolean
default: false
AWS_ACCESS_KEY_ID:
description: 'access key ID for AWS'
type: string
AWS_SECRET_ACCESS_KEY:
description: 'access key for AWS'
type: string
AWS_TEST_FARM_PEM:
description: 'contents of AWS PEM file to be placed in $AWS_EC2_PEM_FILE from environment'
type: string
test_name:
type: string
permissions:
@@ -80,14 +71,14 @@ jobs:
- name: Create test farm pem file
if: contains(inputs.TOXENV, 'test-farm')
env:
PEM_CONTENTS: "${{ inputs.AWS_TEST_FARM_PEM }}"
PEM_CONTENTS: "${{ secrets.AWS_TEST_FARM_PEM }}"
run: |-
echo "${PEM_CONTENTS}" >> $AWS_EC2_PEM_FILE
shell: bash
- name: Run tox
env:
AWS_ACCESS_KEY_ID: "${{ inputs.AWS_ACCESS_KEY_ID }}"
AWS_SECRET_ACCESS_KEY: "${{ inputs.AWS_SECRET_ACCESS_KEY }}"
AWS_ACCESS_KEY_ID: "${{ secrets.AWS_ACCESS_KEY_ID }}"
AWS_SECRET_ACCESS_KEY: "${{ secrets.AWS_SECRET_ACCESS_KEY }}"
PIP_USE_PEP517: "${{ inputs.PIP_USE_PEP517 }}"
TOXENV: "${{ inputs.TOXENV }}"
run: |-