starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-28 08:05:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

only schedule sessions for testing if they aren't already scheduled for testing

Browse Source
This commit is contained in:
Seth Schoen
2012-10-05 17:47:54 -07:00
parent 9cebf1e268
commit ed9a02af65
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server-ca/chocolate.py
+9 -3
View File
@@ -109,9 +109,15 @@ class session(object):
def request_test(self):
"""Ask a daemon to test challenges."""
# TODO: check whether this session is already in pending-testchallenge?
sessions.lpush("pending-testchallenge", self.id)
sessions.publish("requests", "testchallenge")
# There is a race condition between testing for membership and
# adding it, but it's quite difficult to "exploit" and the result
# of triggering it is just that the same session will be scheduled
# for testing twice. We use locking in the daemon to exclude the
# possibility of two daemon processes testing the same session at
# once, and check the session's state before beginning to test it.
if self.id not in sessions.lrange("pending-testchallenge", 0, -1):
sessions.lpush("pending-testchallenge", self.id)
sessions.publish("requests", "testchallenge")
def request_made(self):
"""Has there already been a signing request made in this session?"""