mirror of
https://github.com/certbot/certbot.git
synced 2026-07-28 08:05:31 +02:00
fix apache unit tests (#9490)
Fixes https://github.com/certbot/certbot/issues/9481. I poked around our other uses of this function and they seem OK to me for now, however, I opened https://github.com/certbot/certbot/issues/9489 to track the bigger refactor I think we should do here.
This commit is contained in:
@@ -58,8 +58,13 @@ class CentOSConfigurator(configurator.ApacheConfigurator):
|
||||
"rhel", "redhatenterpriseserver", "red hat enterprise linux server",
|
||||
"scientific", "scientific linux",
|
||||
]
|
||||
# It is important that the loose version comparison below is not made
|
||||
# if the OS is not RHEL derived. See
|
||||
# https://github.com/certbot/certbot/issues/9481.
|
||||
if not rhel_derived:
|
||||
return False
|
||||
at_least_v9 = util.parse_loose_version(os_version) >= util.parse_loose_version('9')
|
||||
return rhel_derived and at_least_v9
|
||||
return at_least_v9
|
||||
|
||||
def _override_cmds(self) -> None:
|
||||
super()._override_cmds()
|
||||
|
||||
@@ -21,6 +21,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
|
||||
have started erroring with `AttributeError` in Certbot v2.0.0.
|
||||
- Plugin authors can find more information about Certbot 2.x compatibility
|
||||
[here](https://github.com/certbot/certbot/wiki/Certbot-v2.x-Plugin-Compatibility).
|
||||
* A bug causing our certbot-apache tests to crash on some systems has been resolved.
|
||||
|
||||
More details about these changes can be found on our GitHub repo.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user