Commit Graph
92 Commits
Author SHA1 Message Date
Sagi KedmiandBrad Warren 26a7023b8d Change QSA to NE in HTTPS redirection (#4204)
* Change QSA to NE in HTTPS redirection

* Seamless transition to new HTTPS redirection RewriteRule
2017-03-02 16:49:34 -08:00
sagi 0e9622322a typo 2016-07-01 22:17:41 +00:00
sagi 7459360780 Add more test cases 2016-07-01 22:08:37 +00:00
sagi 15ba12ed46 Parsing State Machine + some tests 2016-07-01 21:06:16 +00:00
sagi a9abc7b39e typo 2016-07-01 15:17:37 +00:00
sagi d57353a6fe Add missing space. 2016-05-25 22:01:43 +00:00
sagi 20be730a92 Revert client, client_test back 2016-05-25 21:56:15 +00:00
sagi b77d288adb Use cli.py to set .staple given .must_staple 2016-05-25 21:49:53 +00:00
sagi efcd0090da Add a specific must-staple test 2016-05-25 21:20:13 +00:00
sagi 5a3397cf63 Fix tests 2016-05-25 21:07:47 +00:00
sagi 59b567b1de Merge remote-tracking branch 'upstream/master' into must_staple 2016-05-25 20:07:25 +00:00
sagi b3aeeefe20 Autoconfigure OCSP Stapling with --must-staple 2016-05-25 20:03:45 +00:00
sagi d1df72d63c Add the chain_cert is None case 2016-05-25 19:06:25 +00:00
sagi e93aeb88dd Fix docs 2016-05-25 04:19:18 +00:00
sagi b54497d814 Fix chain filename 2016-05-24 19:33:13 +00:00
sagi 4e41e65bfc Merge remote-tracking branch 'upstream/master' into fix_cert_path 2016-05-23 23:13:43 +00:00
sagi 7689de2ad8 Fix tests 2016-05-20 01:18:50 +00:00
Sagi KedmiandJacob Hoffman-Andrews ad76de2502 OCSP Stapling Enhancement for Apache (#2723)
Currently supports only Apache >=2.3.3.
letsencrypt --staple-ocsp -d dumpbits.com [no problem to set it on for apache => 2.3.3]
To check OCSP Stapling:
[~]$ echo QUIT | openssl s_client -connect dumpbits.com:443 -status 2>/dev/null | grep -A 31 'OCSP Resp'
OCSP Response Data:
    OCSP Response Status: successful (0x0)
    Response Type: Basic OCSP Response
    Version: 1 (0x0)
    Responder Id: C = US, O = Let's Encrypt, CN = Let's Encrypt Authority X3
    Produced At: Mar 26 17:54:00 2016 GMT
    Responses:
    Certificate ID:
      Hash Algorithm: sha1
      Issuer Name Hash: 7EE66AE7729AB3FCF8A220646C16A12D6071085D
      Issuer Key Hash: A84A6A63047DDDBAE6D139B7A64565EFF3A8ECA1
      Serial Number: 032A2108AAA650E6EE2E6B041C03C2612A19
    Cert Status: good
    This Update: Mar 26 17:00:00 2016 GMT
    Next Update: Apr  2 17:00:00 2016 GMT

    Signature Algorithm: sha256WithRSAEncryption
         64:f2:71:02:6a:97:d9:eb:13:c1:5c:7a:f5:eb:26:89:3b:40:
         e3:08:82:f7:71:d4:fa:61:4a:8e:4a:7d:e9:53:84:e9:3a:89:
         67:66:08:d9:0e:79:65:9a:8d:dc:fb:07:cc:93:4f:eb:4e:3c:
         cc:7f:cd:fd:db:8f:c3:25:c3:54:87:a9:9c:35:6f:c1:39:31:
         e0:b1:f6:b1:3d:52:5d:db:bb:69:0f:23:05:fe:33:29:1f:ff:
         c6:af:17:a5:98:58:50:3a:48:93:5c:09:4b:f3:91:36:48:31:
         ed:ee:47:4d:66:c3:25:cf:56:b7:f4:48:80:eb:b8:f0:27:b1:
         97:18:b4:88:71:c6:55:5d:bb:25:16:48:98:85:8a:12:8d:64:
         bf:51:df:39:b1:44:91:e1:f2:c6:c3:7d:23:2b:d2:0f:4c:7f:
         57:b1:c9:ae:ec:32:b5:6a:87:bd:83:43:f1:f7:3c:8c:11:5c:
         9d:a5:12:fa:e6:79:87:45:c6:1d:46:c8:14:1e:8d:d1:de:7a:
         0d:e4:53:f2:c9:b6:e5:6e:cb:91:14:bb:04:38:36:4f:71:55:
         e1:ff:71:c7:a6:31:ed:db:6c:0f:d7:f5:ef:0c:6e:08:6b:e0:
         37:cf:ca:a5:67:89:c2:de:8e:36:6d:2f:41:7f:9f:10:c6🇩🇪
         4d:b1:2d:09
======================================
2016-05-19 16:04:18 -07:00
sagi 3589b25dc3 Make lint happy 2016-05-19 19:35:38 +00:00
sagi 501c19ef2a Syntax 2016-05-19 19:33:04 +00:00
sagi e1eb3eff16 Improve code reuse 2016-05-19 19:27:18 +00:00
sagi fde151848d Use set_by_cli for fullchain_path and chain_path 2016-05-19 19:11:25 +00:00
sagi e737481129 WIP 2016-05-19 18:20:27 +00:00
sagi 7e3c9399e5 Use cli.set_by_cli to detect if the user explicitly set cert_path 2016-05-17 22:12:11 +00:00
sagi 886776d741 Make lint happy 2016-05-17 18:29:39 +00:00
sagi 3cf3e5b685 Detect RewriteEngine directives that originate in VirtualHosts 2016-05-17 18:07:52 +00:00
sagi c0228ef1aa Boulder integration scripts provides a cert_path 2016-05-16 22:11:15 +00:00
sagi f092669347 If cert_path provided - do not randomize it 2016-05-16 21:19:44 +00:00
sagi b28b5b08d7 More tests; Make Nose happy 2016-01-11 20:59:19 +00:00
sagi 4645bf8329 Make lint happy 2016-01-11 20:58:52 +00:00
sagi 9c2a0362a7 Add rewrite tests: normal, small, quoted, etc. 2016-01-11 19:55:55 +00:00
sagi a43e7b11f1 Add colon 2016-01-11 19:55:15 +00:00
sagi 82a58fec48 Dequote possible quoted target 2016-01-11 19:48:17 +00:00
sagi ae572fe084 Make lint happy 2016-01-11 19:20:29 +00:00
sagi 6c18a7d318 Revise RewriteRule sifting algorithm 2016-01-11 19:15:23 +00:00
sagi bf74b2cc64 Change test RewriteRule so that it conforms with Apaches spec. 2016-01-11 19:12:30 +00:00
sagi 20433db0bb Merge remote-tracking branch 'upstream/master' into bugfix_skeleton 2016-01-11 17:36:45 +00:00
sagi a718cfede0 Copy only relevant lines from http vhost to ssl vhost skeleton 2016-01-03 22:03:47 +00:00
sagi 06643b35a0 Merge remote-tracking branch 'upstream/master' into bugfix_redirect 2015-12-11 12:14:02 +00:00
sagi 2edfc1cd59 simplified augeas get, with parsers get_arg func 2015-12-11 11:59:26 +00:00
sagi 5f05c5104e make lint happy 2015-12-11 11:13:32 +00:00
sagi ab1e75e426 Change dir_dict to rewrite_args_dict 2015-12-11 10:17:46 +00:00
sagi 23a97b8281 Change iteration on dir_dict 2015-12-11 10:09:16 +00:00
sagi ad5817c7a9 reason about dir_dict 2015-12-11 10:05:09 +00:00
sagi 4748e1dd1e Name the list of two redirect argument lists 2015-12-11 09:57:08 +00:00
sagi 681de292b7 Switch to using defaultdict(list) 2015-12-11 09:29:02 +00:00
sagi c594a258fe Change comment on possibility of redirection loops 2015-12-11 09:26:55 +00:00
sagi b4746e555a typo: an other -> another 2015-12-11 09:18:36 +00:00
sagi 0348f62ffa add more tests 2015-12-04 02:00:24 +00:00
sagi a6a61fee34 Merge remote-tracking branch 'upstream/master' into bugfix_redirect 2015-12-03 22:12:49 +00:00
sagi 7c00dba79b fix verification of letsencrypt redirect 2015-12-03 22:11:34 +00:00
sagi 379506739d add tests 2015-12-03 01:40:12 +00:00
sagi 253f2f3768 make lint happy; delete trailing whitespaces 2015-12-02 23:07:54 +00:00
sagi b97fc124e0 add ver>=2.3.9 check to the case where there is no vhost config 2015-12-02 23:05:49 +00:00
sagi 19e1911945 make lint happy; delete trailing whitespaces 2015-12-02 22:48:14 +00:00
sagi f285f3947d mock get_version in configurator_test 2015-12-02 22:00:07 +00:00
sagi a7ebeddb78 add check for apache 2.3.9, warn of possible conflicting rewrite rules 2015-12-02 01:37:07 +00:00
sagi 1a9e6b1a8a add _is_rewrite_exists() 2015-12-02 01:06:48 +00:00
sagi 5d0337bdf2 change verify_no_redirects to verify_no_letsencrypt_redirect 2015-12-02 00:34:15 +00:00
sagi fdd9cf7610 change map() to a list comprehension. Long live GvR. 2015-12-02 00:28:18 +00:00
sagi 005be60d91 delete unneeded tests 2015-12-02 00:16:13 +00:00
sagi bd9ac51fa6 alter redirect_verification to raise only when an exact Letsencrypt redirction rewrite rule is encountered 2015-12-02 00:05:15 +00:00
sagi 917f7aa33e remove check for Redirect header; the existence of a Redirect header does not imply a HTTP->HTTPS redirection 2015-12-01 23:38:53 +00:00
sagi 090a9a0e46 add PluginEnhancementAlreadyPresent and use it 2015-11-25 01:56:49 +00:00
sagi 7467496984 change enhancement http-header to ensure-http-header 2015-11-24 23:33:21 +00:00
sagi 72fcee4264 change Error to PluginError in comment 2015-11-23 23:58:58 +00:00
sagi 7df7228a53 add regex to detect header_substring in header directive definition 2015-11-23 22:41:02 +00:00
sagi 4ed5277e5f Merge remote-tracking branch 'upstream/master' into hsts 2015-11-23 20:57:17 +00:00
sagi b75354add0 change verify_no_http_header to verify_no_matching_http_header 2015-11-23 20:13:08 +00:00
sagi f8a3216082 change header_name to header_substring 2015-11-23 20:11:47 +00:00
sagi eb5e345c3e change vhost to ssl_vhost, add header_name explanation in comments. 2015-11-22 18:40:19 +00:00
sagi 67e9470179 Merge remote-tracking branch 'upstream/master' into hsts 2015-11-22 18:27:23 +00:00
sagi 58110a69f4 more elegant enhance_config, add --no- flags to hsts and uir 2015-11-17 07:23:19 +00:00
sagi 17ea7bb316 comment and simplify things 2015-11-16 20:41:39 +00:00
sagi 1098126b7b tests hsts, redirect and uir 2015-11-16 20:31:49 +00:00
sagi ddf5b28f7d fix tests and make linter happy 2015-11-16 20:06:16 +00:00
sagi 175ef4f50d merge with letsencrypt master br 2015-11-15 07:18:26 +00:00
sagi b76ef3a293 make lint happy 2015-11-12 05:25:44 +00:00
sagi 796eef802d add apply_enhancement comment 2015-11-12 05:20:10 +00:00
sagi 8185ea931c make hsts and uri cli args actually work 2015-11-12 05:08:30 +00:00
sagi b1e3c89048 add a general apply_enhancement to replace redirect_to_ssl 2015-11-12 04:49:31 +00:00
sagi 68d956f659 make redirect work again 2015-11-12 03:04:23 +00:00
sagi e787147eea dissect namespace config in enhance_config 2015-11-12 02:24:57 +00:00
sagi 17ef874c04 change args to config in enhance_config 2015-11-12 02:15:42 +00:00
sagi 9ad38e9b37 Pass args to enhance_config instead of just a redirect flag 2015-11-11 19:04:07 +00:00
sagi 1880689065 Add --hsts and --uir CLI flags 2015-11-10 06:41:59 +00:00
sagi de338c7309 Add tests for Upgrade-Insecure-Requests 2015-11-09 22:36:00 +00:00
sagi ffe32c6ca4 Add tests and comments 2015-11-08 15:21:36 +00:00
sagi 04136cfbf2 Generalized http-header enhancement 2015-11-08 04:37:57 +00:00
sagi 2988a09087 Make lint happy, delete trailing whitespaces 2015-11-07 05:24:55 +00:00
sagi 93e2023f87 Add HSTS enhancement basic tests 2015-11-06 22:32:02 +00:00
sagi 0473c67c48 Add HSTS header enhancement to Apache 2015-11-06 22:31:30 +00:00