Commit Graph
100 Commits
Author SHA1 Message Date
Peter Eckersley cfefda7267 Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 18:30:29 -07:00
Peter Eckersley 7da7d47e8a Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 17:40:49 -07:00
Peter Eckersley 1e0bd2129f Merge remote-tracking branch 'origin/master' into filepath_refactor 2016-08-10 12:25:41 -07:00
Peter Eckersley 0504882e08 Always newline config edits
Even if they're transient
2016-08-08 17:50:20 -07:00
Peter Eckersley 262eb778fe Update Apache plugin supported OSes 2016-08-08 15:29:23 -07:00
Peter Eckersley fbf8a27157 Slight tweaks 2016-07-28 19:05:08 -07:00
Peter Eckersley 9e9c4dfcf5 fix test 2016-07-27 16:55:23 -07:00
Peter Eckersley d55580025f Extra newlines & spacing 2016-07-27 16:29:30 -07:00
Peter Eckersley 2feeb50109 Fix spacing of nginx redirect blocks 2016-07-27 16:00:43 -07:00
Peter Eckersley fbadf7550c Also put -q in certonly 2016-07-26 19:20:02 -07:00
Peter Eckersley df42f69d8c Address review comments 2016-07-26 18:08:21 -07:00
Peter Eckersley a49d26f607 Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-07-20 16:56:23 -07:00
Peter Eckersley e3ab49a93b Rework "value" parser:
- Now handles any${VAR_SUBSTITUTION}inthemiddle/of/values
  - Don't use a single giant janky Regex; use small ones and have PyParsing
    combine them
2016-07-15 17:11:04 -07:00
Peter Eckersley b6966fc05e lint 2016-07-15 17:11:04 -07:00
Peter Eckersley 7183896ed7 Preserve spaces before comments at the beginning of a file 2016-07-15 17:11:04 -07:00
Peter Eckersley b7cf928852 Parse charset_map correctly
(though we still don't emit it correctly...)
2016-07-13 17:17:45 -07:00
Peter Eckersley 68500cd436 Don't allow dollar_var to swalllow characters like "{" 2016-07-09 15:13:09 -07:00
Peter Eckersley 894af91777 Fix test 2016-07-08 14:09:26 -07:00
Peter Eckersley 0bedeb449a Refactor path_surgery into plugins.util so that nginx can call it 2016-07-08 14:03:21 -07:00
Peter Eckersley 757a8ddae7 Fixes & tests 2016-07-08 13:21:37 -07:00
Peter Eckersley cecac803a0 Do this more cleanly 2016-07-08 13:21:37 -07:00
Peter Eckersley a322f44f2b Implement PATH fallback for apachectl search 2016-07-08 13:21:37 -07:00
Peter Eckersley 754b7956b3 Make the error even more informative 2016-07-08 13:21:37 -07:00
Peter Eckersley c3244df951 more doc improvements 2016-07-08 10:12:57 -07:00
Peter Eckersley ecd1ca4645 grammatical improvement 2016-07-08 10:05:56 -07:00
Peter Eckersley 204c3f0dfb Start using multi-topic CLI flag documentation 2016-07-07 15:33:29 -07:00
Peter Eckersley d96278505e Fix test 2016-07-06 20:08:01 -07:00
Peter Eckersley 4a9846b911 Begin work on multi-topic help listings 2016-07-06 20:02:40 -07:00
Peter Eckersley 83857baf30 Update / cleanup installer error message
Closes: #1756
Updating since we landed #788 and have shipped Apache support almost
everywhere
2016-07-06 15:39:59 -07:00
Peter Eckersley 4b84538c8c Address review comments 2016-07-06 12:57:16 -07:00
Peter Eckersley fd35a1c724 Explain why Apache [appears] not to be installed
Would help debug #3244
2016-07-06 12:43:48 -07:00
Peter Eckersley be8f0bc53b Do a better job of parsing map patterns 2016-06-30 15:29:38 -07:00
Peter Eckersley db8ddac4e2 lint & tweak 2016-06-30 15:13:35 -07:00
Peter Eckersley 8c3e443de9 First attempt at mitigating #3206 2016-06-30 15:07:28 -07:00
Peter Eckersley 7b50960ac0 Address review comments 2016-06-29 13:57:58 -07:00
Peter Eckersley bdbdd826de Extra comment & concision 2016-06-27 12:50:06 -07:00
Peter Eckersley 3e9bf2f35f Tests for UnspacedList.is_dirty() 2016-06-27 12:50:06 -07:00
Peter Eckersley 6017a6cb6d Only write nginx config files if we've modified them 2016-06-27 12:44:36 -07:00
Peter Eckersley 184f54cbc7 cosmetic improvements 2016-06-27 12:36:28 -07:00
Peter Eckersley fdbb69930b Tweak the NotImplementedError cases 2016-06-27 12:00:41 -07:00
Peter Eckersley 23f0ccbc8e Address review issues 2016-06-25 12:28:47 -07:00
Peter Eckersley e93ace79cc Test coverage & fix 2016-06-25 12:06:43 -07:00
Peter Eckersley e0691ede2c Provide clear log messages when Apache tries a default vhost 2016-06-25 10:59:41 -07:00
Peter Eckersley f6069c2297 Explain what is happening when the user cancels vhost selection 2016-06-25 10:59:41 -07:00
Peter Eckersley 98d261596c Raise NotImplemented for all problematic list methods 2016-06-24 19:16:05 -07:00
Peter Eckersley 0dc4639cbf Be more explicit about range policing
(rather than doing it in some roundabout crazy way)
2016-06-24 18:56:30 -07:00
Peter Eckersley 880cb03191 Make assertions about index policing 2016-06-24 18:50:18 -07:00
Peter Eckersley 6a938f2ee7 Fix docstring nit 2016-06-24 16:52:02 -07:00
Peter Eckersley 8f0a5fdc66 Fix a bug in the new index calculations 2016-06-24 16:48:30 -07:00
Peter Eckersley 20b92a3c1f Add some test coverage 2016-06-24 16:48:22 -07:00
Peter Eckersley 9da533d92e Be more succinct 2016-06-24 16:13:12 -07:00
Peter Eckersley e415a4d402 For now, instead, consider this NotImplemented 2016-06-24 14:36:23 -07:00
Peter Eckersley ad13b525b2 For reference, a buggy attempt to implement slicing
but slice assignment seems to mangle the .spaced list in some cases
2016-06-24 14:35:42 -07:00
Peter Eckersley 6930523c14 Refactor to simplify indenation handling 2016-06-23 17:59:26 -07:00
Peter Eckersley a29c6e3102 Try simplifying handling of spacey sublists
- this was causing test failures but they may all have been fixed by other
   changes...
2016-06-23 14:06:32 -07:00
Peter Eckersley db66050a7a Make atomicity comment more accurate 2016-06-23 11:41:31 -07:00
Peter Eckersley 4ef7131a4b Name all of nginxparser's magic regexps 2016-06-23 11:06:11 -07:00
Peter Eckersley 26fdc4683b Merge remote-tracking branch 'origin/master' into nginx-space-preservation 2016-06-22 16:39:27 -07:00
Peter Eckersley 8a28cb7352 Implement Brad's more systematic solution for this 2016-06-22 15:50:21 -07:00
Peter Eckersley e231dae2c1 Merge remote-tracking branch 'origin/master' into dialog-escape 2016-06-22 15:35:07 -07:00
Peter Eckersley 24cc6b208a Avoid newline 2016-06-22 15:24:33 -07:00
Peter Eckersley 7ea0ce5a17 Remove warning about nginx options file
- This would be a security issue if we ran as setuid root at the request of
   non-privileged users, but we don't
2016-06-21 15:34:26 -07:00
Peter Eckersley 098d23ac98 Comment a couple of things 2016-06-21 15:33:57 -07:00
Peter Eckersley 884b21ffbe fix docstring typo 2016-06-21 15:11:32 -07:00
Peter Eckersley 56488b1899 Explain the most likely cause of a missing replay nonce error 2016-06-20 18:18:25 -07:00
Peter Eckersley 5960376d36 Cleanups 2016-06-20 18:17:47 -07:00
Peter Eckersley 14ea8d8cdf Fix server_name spaciness 2016-06-20 17:45:02 -07:00
Peter Eckersley 02844904f0 Improve coverage 2016-06-20 16:11:32 -07:00
Peter Eckersley e2fd1369f3 Update test for fancier semantics 2016-06-20 16:08:40 -07:00
Peter Eckersley ef31a837f7 Lint 2016-06-20 15:56:19 -07:00
Peter Eckersley d2b4ae5740 Consistently coerce inbound data to Unspacines 2016-06-18 15:17:59 -07:00
Peter Eckersley b663ec039e lint 2016-06-18 15:05:48 -07:00
Peter Eckersley 1e59bf8112 fixup 2016-06-18 14:53:17 -07:00
Peter Eckersley e4f88506cc Fix TLS_SNI & associated tests 2016-06-18 14:52:07 -07:00
Peter Eckersley 7bcc23d9f5 Debugging 2016-06-17 18:30:12 -07:00
Peter Eckersley 679101cfb0 Object printing improvements 2016-06-17 18:29:45 -07:00
Peter Eckersley b2c36f8527 Lint & test fix 2016-06-17 14:39:55 -07:00
Peter Eckersley ba0a0e9c26 Tests for UnspacedList 2016-06-17 14:32:24 -07:00
Peter Eckersley efd1ff46c6 Lint 2016-06-16 18:18:33 -07:00
Peter Eckersley 9459daa6d0 Delete new.conf files after tests
Not least, to prevent git conflicts with old branches
2016-06-16 18:04:13 -07:00
Peter Eckersley da250a4f4b Experimentally delete these output files 2016-06-16 17:59:49 -07:00
Peter Eckersley e76e3a953a Fix test cases
- but we're still mangling files in place...
2016-06-16 17:58:05 -07:00
Peter Eckersley b82ebd9180 Fix desyncronisation with .spaced when modifying sublists
- we now actually write directives again!
2016-06-16 17:17:13 -07:00
Peter Eckersley 72ba5b72cc Try to preserve the exact form of end-of-file whitespace 2016-06-16 12:25:11 -07:00
Peter Eckersley e5ce03b312 More test wrangling 2016-06-16 12:24:36 -07:00
Peter Eckersley ff7addefb3 Start fixing tests 2016-06-15 17:57:24 -07:00
Peter Eckersley 2cbd680bd5 Hide .spaced from users outside nginxparser.py 2016-06-15 17:36:53 -07:00
Peter Eckersley 4f46289c1b Start cleanup 2016-06-15 17:26:38 -07:00
Peter Eckersley c867e1e0d5 Merge remote-tracking branch 'origin/master' into nginx-space-preservation 2016-06-15 16:43:58 -07:00
Peter Eckersley 5e59b8ad46 Woohoo! it works 2016-06-15 16:42:47 -07:00
Peter Eckersley 98a2e0c6d6 Another waypoint 2016-06-15 16:02:33 -07:00
Peter Eckersley 8147c671e4 Now handles some conf files in whitespace-preserving mode
(but not all of them)
2016-06-08 17:52:35 -07:00
Peter Eckersley 44edbecba0 Merge remote-tracking branch 'origin/master' into nginx-space-preservation 2016-06-08 16:55:18 -07:00
Peter Eckersley 443f2ebb58 WIP 2016-06-07 18:19:58 -07:00
Peter Eckersley 80a52d8f01 Vaguely close to working? 2016-06-07 17:55:53 -07:00
Peter Eckersley 9be5f7d7d9 Further WIP 2016-06-07 17:17:17 -07:00
Peter Eckersley ac220976f1 work in progress 2016-06-07 14:46:49 -07:00
Peter Eckersley e12dd09465 Merge remote-tracking branch 'origin/master' into nginx-space-preservation 2016-06-07 14:41:43 -07:00
Peter Eckersley ec49afb7c0 UnspacedList: infrastructure for parsing but hiding nginx whitespace 2016-06-03 16:45:24 -07:00
Peter Eckersley 24915f6d00 Lint 2016-05-27 16:45:12 -07:00