Peter Eckersley
bcf38476fa
Fix bugs, clean up plumbing.
2016-02-08 16:59:11 -08:00
Peter Eckersley
994c96180a
Don't catch the wrong exception by accident
2016-02-08 16:48:21 -08:00
Peter Eckersley
0946ea8e04
Bleh.
2016-02-08 16:42:13 -08:00
Peter Eckersley
b61bfdc468
Don't set default="" for store_false args...
2016-02-08 16:18:30 -08:00
Peter Eckersley
de43a4b052
Split default detection into its own method
2016-02-08 15:20:04 -08:00
Peter Eckersley
c5c72de959
Cleanup default detection a little, and handle an extra weird case
...
- Noah spotted a theoretical issue with store_false args, so handle that
prospectively
- overall probably not really making anything neater
2016-02-08 15:09:47 -08:00
Peter Eckersley
edb07aeecb
Tweak changelog
...
(but really, provoke a re-run of travis)
2016-02-08 10:24:09 -08:00
Peter Eckersley
d2ea078422
Remove some commented debugging statements
2016-02-07 20:12:01 -08:00
Peter Eckersley
317557086c
sys.argv[1:] does not work in tests
2016-02-07 20:08:32 -08:00
Peter Eckersley
c9df10a87e
Debugging / work in progress
2016-02-07 19:04:43 -08:00
Peter Eckersley
5693ec5c93
Merge remote-tracking branch 'origin/master' into issue_2347
2016-02-05 18:26:33 -08:00
Peter Eckersley
7906b31f55
Cleanup and refactor a little
2016-02-05 18:25:38 -08:00
Noah Swartz
f70605f5bc
Merge pull request #2338 from letsencrypt/renew_verb
...
Renew verb
2016-02-05 17:57:57 -08:00
Peter Eckersley
56fc99380d
Merge remote-tracking branch 'origin/renew_verb' into issue_2347
2016-02-05 17:34:45 -08:00
Seth Schoen
fd3d2fa822
Make _no_force_renew not force renewal
2016-02-05 17:19:39 -08:00
Seth Schoen
8b02f485b0
Have a way not to force renewal in integration test
2016-02-05 17:13:30 -08:00
Seth Schoen
09337517d3
Try to distinguish renew and non-renew in integration test
2016-02-05 16:57:41 -08:00
Peter Eckersley
fd76b32aed
Slightly better renewal debuggery
2016-02-05 16:42:41 -08:00
Peter Eckersley
32e0faa7b6
Detect any setting of arguments as non-default
...
Even if the user set the argument to the default value.
This involves a hack (empty_defaults=True) where we shim all the arguments
so that their default values evaluate to false. This hack may be buggy...
2016-02-05 16:35:55 -08:00
Seth Schoen
954da7052b
Merge remote-tracking branch 'origin/renew_verb' into renew_verb
2016-02-05 16:35:35 -08:00
Brad Warren
7eb2bb4d03
Fix renew + noninteractive
2016-02-05 16:30:19 -08:00
Brad Warren
0b5c8e8d71
Merge branch 'master' into renew_verb
2016-02-05 16:26:50 -08:00
Seth Schoen
eeea177fe5
Merge remote-tracking branch 'origin/master' into renew_verb
2016-02-05 16:04:08 -08:00
schoen
063d22225e
Merge pull request #2385 from letsencrypt/noninteractive-implies-stderr-logging
...
Non-interactive implies stderr logging
2016-02-05 16:03:56 -08:00
Brad Warren
6ef0f71e0e
-n implies -t for logging
2016-02-05 15:53:54 -08:00
Seth Schoen
772d424fc7
log_dir → logs_dir
2016-02-05 15:38:10 -08:00
Seth Schoen
21fe41c53b
call .restart() on installer after renew if possible
2016-02-05 15:37:50 -08:00
Seth Schoen
5c31b000b4
Error handling around obtain_cert()
2016-02-05 14:51:14 -08:00
Seth Schoen
5c14c09027
@bmw noticed we were iterating over the wrong thing!
2016-02-05 13:10:00 -08:00
Seth Schoen
b7717bbc8e
Fixes for comments from PR review
2016-02-05 13:06:50 -08:00
Noah Swartz
c8de329d2c
merge with a recent branch of renew_verb
2016-02-05 10:07:39 -08:00
Noah Swartz
5dd8b6f45f
don't override non-default commandline flags
2016-02-05 09:37:34 -08:00
Peter Eckersley
3260efd519
Be consistent about using logger.debug for tracebacks
2016-02-04 19:31:05 -08:00
Peter Eckersley
0b62495581
Move noninteractivity to the place Brad suggests
2016-02-04 19:25:50 -08:00
Peter Eckersley
6081467517
Merge remote-tracking branch 'origin/denest' into renew_verb
2016-02-04 19:18:15 -08:00
Peter Eckersley
9f57236bb1
Try things the EvenMoreProper way
2016-02-04 19:14:36 -08:00
Peter Eckersley
9cd0d5497f
Remove older workarounds, comment newer ones
2016-02-04 18:58:57 -08:00
Peter Eckersley
2e05d33d3b
Merge remote-tracking branch 'origin/denest' into experiment
2016-02-04 18:50:06 -08:00
Brad Warren
8933c51e22
Satisfied OCD by keeping comment capitalization consistent
2016-02-04 18:32:39 -08:00
Brad Warren
8c47215318
More unnesting
2016-02-04 18:28:10 -08:00
Brad Warren
b4f1d94d09
less nesting + fixed argument order
2016-02-04 18:21:36 -08:00
Brad Warren
36a42d1830
Tracebacks are useful
2016-02-04 18:15:39 -08:00
Brad Warren
b2dae6cae2
Fixed it?
2016-02-04 18:10:39 -08:00
Brad Warren
7dd1ea4dcf
Kill this now plz
2016-02-04 17:30:52 -08:00
Seth Schoen
77fbb1433f
Merge remote-tracking branch 'origin/master' into renew_verb
2016-02-04 16:53:06 -08:00
bmw
70ab18203d
Merge pull request #2374 from letsencrypt/use-namespace-4-now-plz
...
Fixes missing account/email problems
2016-02-04 16:48:51 -08:00
Brad Warren
dace0aecfa
I missed these
2016-02-04 16:23:39 -08:00
Seth Schoen
71c90bef5e
Merge remote-tracking branch 'origin/renew_verb' into renew_verb
...
Conflicts:
letsencrypt/cli.py
2016-02-04 16:11:30 -08:00
Noah Swartz
8dfb2a1d4c
check verb
2016-02-04 16:09:42 -08:00
Seth Schoen
893918de00
Check for config.verb == "renew" rather than config.renew
2016-02-04 16:07:56 -08:00
Peter Eckersley