move save command up to tls_sni

letsencrypt-apache/letsencrypt_apache/configurator.py

@@ -557,11 +557,8 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
 
         # search for NameVirtualHost directive for ip_addr
         # note ip_addr can be FQDN although Apache does not recommend it
-        if self.version >= (2, 4):
-            return True
-        else:
-            self.save("don't lose config changes", True)
-            return self.parser.find_dir("NameVirtualHost", str(target_addr))
+        return (self.version >= (2, 4) or
+                self.parser.find_dir("NameVirtualHost", str(target_addr)))
 
     def add_name_vhost(self, addr):
         """Adds NameVirtualHost directive for given address.

letsencrypt-apache/letsencrypt_apache/tls_sni_01.py

@@ -76,6 +76,7 @@ class ApacheTlsSni01(common.TLSSNI01):
 
         # Setup the configuration
         addrs = self._mod_config()
+        self.configurator.save("Don't lose mod_config changes", True)
         self.configurator.make_addrs_sni_ready(addrs)
 
         # Save reversible changes