Merge pull request #286 from letsencrypt/fix_272

Fix 272

letsencrypt/client/auth_handler.py

@@ -203,7 +203,8 @@ class AuthHandler(object):  # pylint: disable=too-many-instance-attributes
 
     def _path_satisfied(self, dom):
         """Returns whether a path has been completely satisfied."""
-        return all(self.responses[dom][i] is not None for i in self.paths[dom])
+        # Make sure that there are no 'None' or 'False' entries along path.
+        return all(self.responses[dom][i] for i in self.paths[dom])
 
     def _get_chall_pref(self, domain):
         """Return list of challenge preferences.

letsencrypt/client/tests/auth_handler_test.py

@@ -481,7 +481,7 @@ class PathSatisfiedTest(unittest.TestCase):
         self.handler.responses[dom[0]] = [None, "sat", "sat2", None]
 
         self.handler.paths[dom[1]] = [0]
-        self.handler.responses[dom[1]] = ["sat", None, None, None]
+        self.handler.responses[dom[1]] = ["sat", None, None, False]
 
         self.handler.paths[dom[2]] = [0]
         self.handler.responses[dom[2]] = ["sat"]
@@ -496,7 +496,7 @@ class PathSatisfiedTest(unittest.TestCase):
             self.assertTrue(self.handler._path_satisfied(dom[i]))
 
     def test_not_satisfied(self):
-        dom = ["0", "1", "2"]
+        dom = ["0", "1", "2", "3"]
         self.handler.paths[dom[0]] = [1, 2]
         self.handler.responses[dom[0]] = ["sat1", None, "sat2", None]
 
@@ -506,6 +506,9 @@ class PathSatisfiedTest(unittest.TestCase):
         self.handler.paths[dom[2]] = [0]
         self.handler.responses[dom[2]] = [None]
 
+        self.handler.paths[dom[3]] = [0]
+        self.handler.responses[dom[3]] = [False]
+
         for i in xrange(3):
             self.assertFalse(self.handler._path_satisfied(dom[i]))