incorporate brad's comments

certbot-apache/certbot_apache/configurator.py

@@ -1080,7 +1080,7 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
         if not use_stapling_aug_path:
             self.parser.add_dir(ssl_vhost.path, "SSLUseStapling", "on")
 
-        ssl_vhost_aug_path = parser.get_aug_path(ssl_vhost.filep)
+        ssl_vhost_aug_path = self._escape(parser.get_aug_path(ssl_vhost.filep))
 
         # Check if there's an existing SSLStaplingCache directive.
         stapling_cache_aug_path = self.parser.find_dir('SSLStaplingCache',

certbot-apache/certbot_apache/tests/configurator_test.py

@@ -1,4 +1,4 @@
-# pylint: disable=too-many-public-methods, protected-access
+# pylint: disable=too-many-public-methods
 """Test for certbot_apache.configurator."""
 import os
 import shutil
@@ -1188,6 +1188,7 @@ class MultipleVhostsTest(util.ApacheTest):
 
 class AugeasVhostsTest(util.ApacheTest):
     """Test vhosts with illegal names dependant on augeas version."""
+    # pylint: disable=protected-access
 
     def setUp(self):  # pylint: disable=arguments-differ
         td = "debian_apache_2_4/augeas_vhosts"

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/000-default.conf

@@ -1 +0,0 @@
-../sites-available/000-default.conf

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/certbot.conf

@@ -1 +0,0 @@
-../sites-available/certbot.conf

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/encryption-example.conf

@@ -1 +0,0 @@
-../sites-available/encryption-example.conf

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/mod_macro-example.conf

@@ -1 +0,0 @@
-../sites-available/mod_macro-example.conf

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/ocsp-ssl.conf

@@ -1 +0,0 @@
-../sites-available/ocsp-ssl.conf