starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 19:02:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change comment on possibility of redirection loops

Browse Source
This commit is contained in:
sagi
2015-12-11 09:26:55 +00:00
parent b4746e555a
commit c594a258fe
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
letsencrypt-apache/letsencrypt_apache/configurator.py
+4 -2
View File
@@ -886,8 +886,10 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
# Note: if code flow gets here it means we didn't find the exact # Note: if code flow gets here it means we didn't find the exact
# letsencrypt RewriteRule config for redirection. So if we find # letsencrypt RewriteRule config for redirection. Finding
# another RewriteRule it may induce a loop / config mismatch. # another RewriteRule is likely to be fine in most or all cases,
# but redirect loops are possible in very obscure cases; see #1620
# for reasoning.
if self._is_rewrite_exists(general_vh): if self._is_rewrite_exists(general_vh):
logger.warn("Added an HTTP->HTTPS rewrite in addition to " logger.warn("Added an HTTP->HTTPS rewrite in addition to "
"other RewriteRules; you may wish to check for " "other RewriteRules; you may wish to check for "