Commit Graph
2125 Commits
Author SHA1 Message Date
Erica PortnoyandBrad Warren 77ed0c35ea Match socket testing behavior to ACME standalone socket reuse behavior. Aggressively reuse ports, ignoring TIME_WAIT. (#3631) 2016-10-13 13:53:17 -07:00
Peter EckersleyandJacob Hoffman-Andrews 3615b9030c Improve description of what email is used for.
Specifically, it's not currently used for account recovery.
2016-10-12 16:37:55 -07:00
Blake GriffithandPeter Eckersley 7773568332 Update ACME error namespace to match the new draft. (#3469)
* Update error namespace in acme package.

* Use new error namespace in certbot.

* fix lint and py26 errors.

* Update with_code docstring.

* @pde's suggestions
2016-10-12 14:46:02 -07:00
Brad WarrenandPeter Eckersley f5bf66ba36 Check version requirements on optional dependencies (#3618)
* Add and test activate function to acme.

This function can be used to check if our optional dependencies are
available and they meet our version requirements.

* use activate in dns_resolver

* use activate in dns_available() in challenges_test

* Use activate in dns_resolver_test

* Use activate in certbot.plugins.util_test

* Use acme.util.activate for psutil

* Better testing and handling of missing deps

* Factored out *_available() code into a common function

* Delayed exception caused from using acme.dns_resolver without
  dnspython until the function is called. This makes both
  production and testing code simpler.

* Make a common subclass for already_listening tests

* Simplify mocking of USE_PSUTIL in tests
2016-10-11 17:50:11 -07:00
Erica PortnoyandPeter Eckersley e1da0efb8a Match psutil port open checking behavior to that of socket test, and update tests. (#3589)
* Match psutil port open checking behavior to that of socket test, and update tests.

* Update docstring
2016-10-11 12:22:58 -07:00
Brad WarrenandPeter Eckersley a5df9e5a0e Only verify required ports are available (#3608)
* only verify port is available when you actually need it

* refactor code to create achalls

* Test port checks are based on achall

* test that only the port for the requested challenge is checked in standalone
2016-10-10 18:44:39 -07:00
Brad WarrenandPeter Eckersley cb613ba7d3 Create symlinks at runtime and don't use relative paths (#3600)
* Create symlinks at runtime in cli_test.py

* use test_util.vector_path rather than hardcoding path

* Reference #2716 in comment about too many lines in cli.py
2016-10-10 13:17:49 -07:00
Brad WarrenandPeter Eckersley 0864f4e692 Make --quiet reduce the logging level (#3593)
* reduce logging level and ignore verbose flags in quiet mode

* Simplify setup_logging parameters

The extra parameters were there in the past when the letsencrypt-renewer was a
separate executable that also used this function. This is cruft that can be
removed.

* Add basic tests for setup_logging
2016-10-06 14:14:43 -07:00
Brad WarrenandPeter Eckersley 76a92d4cde Release Certbot 0.9.0 (#3583)
* Release 0.9.0

* Bump version to 0.10.0
2016-10-05 10:13:28 -07:00
Brad WarrenandGitHub da22e64563 Allow tests to pass without dnspython (#3581)
* move skipUnless to test_util

* add skip_unless to acme test_util

* Make dns_resolver_tests work with and without dnspython

* make acme.challenges_test pass when dns is unavailable
2016-10-04 16:49:51 -07:00
Peter EckersleyandBrad Warren bde1d9fdb1 Renew symlink safety (#3560)
Re-do the fix for #3497 to ensure it works in all cases.

* If lineages are in an inconsistent (non-deployed) state, deploy them

* Test new _handle_identical_cert case

* Move lineage.has_pending_deployment() check up to _auth_from_domains

Less conceptually nice, but in the "renew" verb case it wasn't being called :(

* Swap _auth_from_domains return type

 * It now matches _treat_as_renewal & _handle_identical_cert_request etc

* Revert "Move lineage.has_pending_deployment() check up to _auth_from_domains"

This reverts commit a7fe734d73.

* Move test back to handle_identical_cert_request

* We need to check for non-deployment on two separate code paths

 - Once high up in "renew" (because failure to be deployed stops us from
   divind down the stack)
 - Once way down in _handle_identical_cert_request (because that's where it
   makes the most sense for run / certonly)
 - So refactor that work into storage.py

* We don't necessarily reinstall
2016-10-04 10:18:05 -07:00
Brad WarrenandPeter Eckersley 769ebfce5e Remove pointless question (#3526)
* remove unhelpful question about servernames and default vhosts

* add prefix about names found in config files

* test we include configuration files prefix

* Tell the user what kind of conf files were missing domains

* Revert "Tell the user what kind of conf files were missing domains"

This reverts commit 1066a88dae.
2016-09-28 15:52:08 -07:00
Peter EckersleyandGitHub 3b9a87cd2f If lineages are in an inconsistent (non-deployed) state, deploy them (#3533)
* If lineages are in an inconsistent (non-deployed) state, deploy them

* Test new _handle_identical_cert case

* Lint

* Fix find & replace SNAFU
2016-09-23 17:48:50 -07:00
Peter EckersleyandGitHub 7b269183c6 Merge pull request #3500 from aidin36/issue-3239
Issue #3239: Checking signal's default action before handling it.
2016-09-23 16:51:37 -07:00
Peter EckersleyandGitHub 2434b4a549 Merge pull request #3507 from certbot/only-suggest-valid-names
Only suggest names LE will accept
2016-09-22 14:23:19 -07:00
Peter EckersleyandGitHub 1584ee8ac6 Merge pull request #3466 from certbot/all-together-now
DNS challenge support in the manual plugin and general purpose --preferred-challenges flag
2016-09-22 14:15:25 -07:00
Peter EckersleyandGitHub 4660c0da7b Merge pull request #3523 from certbot/nginx-ocsp-stapling
Tie Nginx OCSP stapling to enhancements system
2016-09-22 14:10:36 -07:00
Brad Warren 74ac006f14 fix spacing 2016-09-21 17:48:17 -07:00
Brad Warren 0165269c05 denit cli.py 2016-09-21 17:37:47 -07:00
Peter Eckersley e28017a110 Lint 2016-09-21 16:45:42 -07:00
Peter Eckersley f6c605cd15 Add tests for the --preferred-challenges cli parser 2016-09-21 16:43:35 -07:00
Peter Eckersley 107a3e6aa9 Allow & document --preferred-challenges dns,http 2016-09-21 16:17:31 -07:00
Peter Eckersley 741a57c976 Accept --preferred-challenges "dns-01, http-01" 2016-09-21 15:02:03 -07:00
Peter Eckersley a18a8f051d Improve documentation for --preferred-challenges 2016-09-21 15:01:01 -07:00
Peter EckersleyandGitHub a03834ffcd Merge pull request #3516 from certbot/increase-log-count
Include log retention count to 1000.
2016-09-19 16:51:49 -07:00
Jacob Hoffman-Andrews 2bdf1258ad Include log retention count to 1000.
This is a quick fix to https://github.com/certbot/certbot/issues/3382, so that
Python log rotation is less likely to delete files before logrotate can get to
them. Specifically, if logrotate's config says to preserve fewer than 1000 logs,
it will do the right thing.
2016-09-19 15:43:26 -07:00
Brad Warren dff1368765 add staple-ocsp test 2016-09-19 15:05:16 -07:00
Brad Warren fea079400f Provide chain_path for enhance config 2016-09-19 14:55:26 -07:00
Brad Warren 3a8a5598a3 update constants.py 2016-09-19 14:44:34 -07:00
Aidin Gharibnavaz 7c79e96249 Issue #3239: SIGTERM was added twice by mistake. 2016-09-17 21:55:36 +04:30
Jacob Hoffman-Andrews 3eaafcecad Use cli_command to print. 2016-09-16 18:45:21 -07:00
Brad Warren 307b2e5307 Reject domains with only one label 2016-09-16 16:53:25 -07:00
Brad Warren f2e0afc96c add enforce_le_validity function 2016-09-16 16:08:51 -07:00
Brad Warren 72ca219097 fix typo -- domains should be domain 2016-09-16 15:05:39 -07:00
Jacob Hoffman-Andrews 6e0a68f844 Improve error message for "no installer plugin." 2016-09-16 14:21:13 -07:00
Aidin Gharibnavaz b7853f2031 Issue #3239: Checking signal's default action before handling it. 2016-09-15 18:34:27 +04:30
Brad Warren a8b2880963 fix ip logging prompt for manual-test-mode 2016-08-29 18:45:16 -07:00
Brad Warren 021313acd1 make port flags more visible with better help 2016-08-29 17:08:46 -07:00
Brad Warren 5d8127177c correct challenge domain name 2016-08-29 16:48:31 -07:00
Brad Warren eb88e7a577 Remove standalone_supported_challenges value from manual test 2016-08-29 16:34:43 -07:00
Brad Warren 456f3527cd Only log one warning when missing dnspython 2016-08-29 16:31:58 -07:00
Brad Warren 55e86983e7 fix test mock after moving getUtility call 2016-08-29 16:30:17 -07:00
Brad Warren b854d10795 reduce number of ip_logging_permission checks 2016-08-29 16:18:23 -07:00
Brad Warren 26467d4233 update manual plugin info 2016-08-29 15:57:03 -07:00
Brad Warren b73bdcd518 Use DNS01 not DNS 2016-08-29 15:48:17 -07:00
Brad Warren 322546b8d1 make manual use --preferred-challenges flag 2016-08-29 15:44:31 -07:00
Brad Warren 7b7477ab94 Merge branch 'prettify' into all-together-now 2016-08-29 15:20:00 -07:00
Brad Warren 0f575cf80d test that pref_challs is respected 2016-08-29 14:34:03 -07:00
Brad Warren 606636766e Test preferred challenges not supported 2016-08-29 14:13:52 -07:00
Brad Warren 24cc03d1f6 only print deprecation warning when --standalone-supported-challenges is set 2016-08-29 13:32:19 -07:00