Commit Graph
100 Commits
Author SHA1 Message Date
Peter EckersleyandBrad Warren 595745e044 Clarify domain name <-> cert name docs 2017-06-30 13:58:18 -04:00
Peter EckersleyandBrad Warren 2613a8b579 Continue work on Apache multivhost
* Apache: do not assume directives will be CamelCased

* Fixup

* Elaborate

* Simplify the definition of vh_p
2017-05-02 15:38:49 -07:00
Peter Eckersley 72b6179e0e Remove vestigial thingy 2017-04-28 18:46:01 -07:00
Peter Eckersley f6c02728e4 Address review comments 2017-04-28 18:42:03 -07:00
Peter Eckersley 0a4ee306a9 Fix UA flag setting (and set more of them) 2017-04-28 18:02:34 -07:00
Peter Eckersley 5be0811bdc Replace removed "renewing" with potential future substitutes :/ 2017-04-13 20:07:03 -07:00
Peter Eckersley cb66ba95e1 Revert "Also report if we're renewing"
This reverts commit 6fa521bc5f.
2017-04-13 20:00:31 -07:00
Peter Eckersley c35ca9775b tweak comment 2017-04-06 14:41:40 -07:00
Peter Eckersley 23a2ecb36e Fixup 2017-04-05 15:28:14 -07:00
Peter Eckersley 2f0ec5c388 Set renewing: correctly for the "renew" case. 2017-04-05 12:40:26 -07:00
Peter Eckersley b614fe8491 Merge remote-tracking branch 'origin/master' into more-ua 2017-04-05 11:58:03 -07:00
Peter Eckersley 572b9fe5be Merge remote-tracking branch 'origin/master' into more-ua 2017-04-05 11:57:51 -07:00
Peter Eckersley a313eebc7f Conform to RFC 1945 2017-04-05 11:54:23 -07:00
Peter Eckersley 4846217445 Make config.renewing always a string. 2017-03-17 15:20:24 -07:00
Peter Eckersley f259a17549 Lint 2017-03-16 01:14:34 -07:00
Peter Eckersley 6fa521bc5f Also report if we're renewing 2017-03-15 18:02:03 -07:00
Peter Eckersley 9aca5d2a79 Merge remote-tracking branch 'alex/user-agent-python-version' into more-ua 2017-03-15 17:51:34 -07:00
Peter Eckersley 64a7608956 Add auto-ness to the UA 2017-03-15 17:19:00 -07:00
Peter Eckersley e05d537ff5 Avoid code repetition 2017-01-05 12:16:03 -08:00
Peter Eckersley 707b27418f Explicitly handle "unknown" responses from openssl 2017-01-05 12:06:51 -08:00
Peter Eckersley 3c757aec9b Merge remote-tracking branch 'origin/ocsp' into ocsp 2017-01-05 11:57:28 -08:00
Peter Eckersley abd062cb94 Handle warnings in "revoked" responses too 2017-01-05 11:55:19 -08:00
Peter Eckersley b1be49c14f Openssl black magic
* With _some_ versions of openssl, when checking OCSP for staging certs
   only, we need this -trust_other flag
2017-01-05 11:04:01 -08:00
Peter Eckersley 4d312d8ffe Better logging 2017-01-05 11:03:53 -08:00
Peter Eckersley 3e7f64dfe8 Pre-release variant of OCSP testing 2017-01-04 17:53:41 -08:00
Peter Eckersley 7f686b15c7 Merge remote-tracking branch 'origin/subset-renewal' into dev/3844-preserve-must-staple 2017-01-04 17:22:09 -08:00
Peter Eckersley f4baf1fc39 Fix test 2016-12-23 10:48:14 -08:00
Peter Eckersley c29878ace9 lint 2016-12-23 01:03:38 -08:00
Peter Eckersley c5bda903f2 Another instance of overlogging 2016-12-23 00:42:17 -08:00
Peter Eckersley 2fdbb8430a Don't log errors twice
- They're already being logged down in util.run_script
2016-12-23 00:40:10 -08:00
Peter Eckersley 21287b414f Finish unit tests for OCSP warning states 2016-12-23 00:24:47 -08:00
Peter Eckersley b02ce53354 Test farm tests for openssl-based revocation checking 2016-12-23 00:20:38 -08:00
Peter Eckersley 0bcbf1d0a7 WIP 2016-12-22 23:07:00 -08:00
Peter Eckersley 97081452e9 fixup 2016-12-22 18:52:20 -08:00
Peter Eckersley 0011a3b7d8 Start handling some weirder OCSP states 2016-12-22 18:51:17 -08:00
Peter Eckersley aaffe2f9ca Add openssl installation to some bootstrappers
- The others seem to either be platforms where openssl is part of the
   base system, or where I can't quickly confirm that it's safe to ask
   for installation of something called "openssl".

 - If we miss any platforms, the OCSP checking code in "certbot
   certificates" should fail gracefully.
2016-12-22 15:53:32 -08:00
Peter Eckersley 9aa93c05c1 Simplify the ocsp_revoked() return type
- we weren't reacting to None, so call it False instead
2016-12-22 15:35:29 -08:00
Peter Eckersley 19143d8303 Increase test coverage 2016-12-22 13:07:00 -08:00
Peter Eckersley 7014ab5fd0 lint 2016-12-21 23:20:19 -08:00
Peter Eckersley ac17f98b0c Refactor post_hook storage during "renew" 2016-12-21 23:02:27 -08:00
Peter Eckersley 61e822a897 Add a few more tests 2016-12-21 21:50:19 -08:00
Peter Eckersley e2d8630f5e py3fix 2016-12-21 14:42:35 -08:00
Peter Eckersley 0ed3213989 Remove --check-ocsp flag
- Might have been occasionally useful, but simplicity
 - Add some missing tests, remove some obsolete ones
2016-12-21 14:38:26 -08:00
Peter Eckersley 76b8c53566 Tests for ocsp.py, and associated fixes 2016-12-21 14:38:26 -08:00
Peter Eckersley f495863da9 Check --check-ocsp flags, and test those checks 2016-12-21 14:38:26 -08:00
Peter Eckersley 509f4029bb more py3 fixes 2016-12-21 14:38:26 -08:00
Peter Eckersley 7d02b8dbd5 py3fix 2016-12-21 14:38:26 -08:00
Peter Eckersley fcf7387c3d Don't crash if openssl is missing 2016-12-21 14:38:26 -08:00
Peter Eckersley 011f6055d4 Better message 2016-12-21 14:38:26 -08:00
Peter Eckersley bf6084db61 With mixed staging/prod lineages, it might not be correct to stop OCSPing
- One lineage might fail, and a later one succeed
2016-12-21 14:38:26 -08:00
Peter Eckersley 15ed372df6 Fix existing tests 2016-12-21 14:38:26 -08:00
Peter Eckersley 03f312e653 Allow filtering of "certbot certificates output" with --config-name or -d 2016-12-21 14:38:26 -08:00
Peter Eckersley e5e5db24d7 CLI flag for controlling ocsp checking now works 2016-12-21 14:38:26 -08:00
Peter Eckersley 840c584cbd Make the OCSP checker a class
(Since it contains a reasonable amount of system state)
2016-12-21 14:38:26 -08:00
Peter Eckersley 7a18a124ce Better error handling 2016-12-21 14:38:26 -08:00
Peter Eckersley fe36e336a8 Run with both old and new versions of openssl 2016-12-21 14:38:26 -08:00
Peter Eckersley 245b84ab78 Format CLI to keep modern openssls happy
- This is somewhat ominous
2016-12-21 14:38:26 -08:00
Peter Eckersley ac02cd9cb8 ocsp checking needs -verify_other
https://community.letsencrypt.org/t/unable-to-verify-ocsp-response/7264
2016-12-21 14:38:26 -08:00
Peter Eckersley 40e29bb95f begin implementing OCSP checking for "certificates" 2016-12-21 14:38:20 -08:00
Peter Eckersley 6a67ce5567 Ensure that path_surgery doesn't happen until we have a logger 2016-12-19 17:00:09 -08:00
Peter Eckersley 186a8c888f Path surgery makes sense for hooks that may be called from cron 2016-12-17 15:02:13 -08:00
Peter Eckersley 64daefea6b util.exe_exists and hooks._which were almost identical; merge them 2016-12-17 15:02:10 -08:00
Peter Eckersley 99482e8047 Document subtle new semantics 2016-12-15 17:41:34 -08:00
Peter Eckersley de77dd74ad Unbreak repeated insertion logic 2016-12-15 17:31:32 -08:00
Peter Eckersley 33de782fba Make post hooks run in deterministic order 2016-12-15 17:28:16 -08:00
Peter Eckersley 0c2dc60484 Integration tests for hooks 2016-12-15 17:28:16 -08:00
Peter Eckersley 6f9abde894 Support intricate combinations of pre-hooks in different lineages 2016-12-15 17:28:16 -08:00
Peter Eckersley 0bea6c7350 Log when we run renew hooks (why weren't we doing this already?) 2016-12-15 17:28:16 -08:00
Peter Eckersley 876a760a91 Begin implementing pre / post-hook preservation 2016-12-15 17:28:16 -08:00
Peter Eckersley e28017a110 Lint 2016-09-21 16:45:42 -07:00
Peter Eckersley f6c605cd15 Add tests for the --preferred-challenges cli parser 2016-09-21 16:43:35 -07:00
Peter Eckersley 107a3e6aa9 Allow & document --preferred-challenges dns,http 2016-09-21 16:17:31 -07:00
Peter Eckersley 6c066ef10c Better section link 2016-09-21 15:24:15 -07:00
Peter Eckersley 9219617b0c Nicer table formatting 2016-09-21 15:20:06 -07:00
Peter Eckersley 741a57c976 Accept --preferred-challenges "dns-01, http-01" 2016-09-21 15:02:03 -07:00
Peter Eckersley a18a8f051d Improve documentation for --preferred-challenges 2016-09-21 15:01:01 -07:00
Peter Eckersley df61b0e349 Check for comments more accurately 2016-08-18 13:56:15 -07:00
Peter Eckersley 015d103f8d Unbreak using.html#plugins links
Fixes: #3422
2016-08-16 18:46:19 -07:00
Peter Eckersley cfefda7267 Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 18:30:29 -07:00
Peter Eckersley 7da7d47e8a Merge remote-tracking branch 'origin/master' into multi-topic-help 2016-08-12 17:40:49 -07:00
Peter Eckersley 1e0bd2129f Merge remote-tracking branch 'origin/master' into filepath_refactor 2016-08-10 12:25:41 -07:00
Peter Eckersley 9c168017ae That was not the correct magic 2016-08-08 18:17:02 -07:00
Peter Eckersley b5fa0fbad7 This is reportedly the correct magic 2016-08-08 18:08:11 -07:00
Peter Eckersley 712bd9ee6b Copy nginx options file into integration testing environment 2016-08-08 17:58:22 -07:00
Peter Eckersley 0504882e08 Always newline config edits
Even if they're transient
2016-08-08 17:50:20 -07:00
Peter Eckersley f0c2ed3059 Lint, improve coverage, rm unused code 2016-08-08 15:45:49 -07:00
Peter Eckersley 262eb778fe Update Apache plugin supported OSes 2016-08-08 15:29:23 -07:00
Peter Eckersley da7e429125 Work around horrible spaciness API usage bug 2016-08-08 15:14:06 -07:00
Peter Eckersley 7deb1f0ad6 Fix bug with UnpsacedList.insert to final position
- which only applied when the list actually contained spaces
2016-08-08 12:15:18 -07:00
Peter Eckersley 0ade03b7bf Merge remote-tracking branch 'origin/master' into no-conflicting-declarations3 2016-08-05 15:41:54 -07:00
Peter Eckersley 460f49778f Fix tests for our new spacey, commented world 2016-08-05 15:37:01 -07:00
Peter Eckersley cdc894601c Tolerate our own added newlines 2016-08-05 15:36:40 -07:00
Peter Eckersley 3a2df72bce Add newlines to the ends of blocks more correctly 2016-08-05 15:36:24 -07:00
Peter Eckersley a8abde7d8d Merge remote-tracking branch 'origin/no-conflicting-declarations3' into no-conflicting-declarations3 2016-08-05 14:47:41 -07:00
Peter Eckersley 61b81b877d Merge remote-tracking branch 'origin/master' into no-conflicting-declarations3 2016-07-29 17:28:29 -07:00
Peter Eckersley 89758decbb Fix a test 2016-07-29 17:28:22 -07:00
Peter Eckersley fbf8a27157 Slight tweaks 2016-07-28 19:05:08 -07:00
Peter Eckersley 9e9c4dfcf5 fix test 2016-07-27 16:55:23 -07:00
Peter Eckersley d55580025f Extra newlines & spacing 2016-07-27 16:29:30 -07:00
Peter Eckersley 2feeb50109 Fix spacing of nginx redirect blocks 2016-07-27 16:00:43 -07:00