Commit Graph
7514 Commits
Author SHA1 Message Date
Jacob Hoffman-AndrewsandBrad Warren 018a304cd6 Remove Link rel=next for authzs and new-certs. (#4303)
An early version of the spec indicated that clients should process issuance
sequentially, following Link rel=next from an account URL to an authz URL, to a
new-cert URL. However, the spec has long since moved to putting these URLs in
the directory.

Certbot nominally supports either; This change consolidates on always using the
directory, simplifying things and making the transition to the latest ACME spec
easier.

* Revert "Revert "Remove Link rel=next for authzs and new-certs." (#4277)"

This reverts commit 11ec1eb911.

* Save new_authzr_uri with account for older clients.

* Add test that new_authzr_uri exists in regr.

* Restore backwards compatibility for new_authzr_uri.

* Fix account_test.

* Add test for deprecated URI argument to request_challenges.

* Review feedback.

* Fix test

* Add omitempty to new_cert_uri.
2017-03-14 21:44:57 -07:00
Noah SwartzandGitHub f11d7b3f0c Merge pull request #4269 from osirisinferi/docs-update-standalone-manual-plugins
Deprecated standalone-preferred-challenges
2017-03-14 10:52:01 -07:00
Brad WarrenandGitHub 7b34e73752 Merge pull request #4295 from certbot/dockerfile++
Rewrite our Dockerfile
2017-03-13 20:25:45 -07:00
Noah SwartzandGitHub 25bda6177e Merge branch 'master' into docs-update-standalone-manual-plugins 2017-03-13 13:48:48 -07:00
Amjad MashaalandBrad Warren 0e735e360c remove unnecessary whitespace from tools/release.sh 2017-03-10 18:09:39 -08:00
Brad WarrenandGitHub 91f4b2b571 Improve macOS contributor instructions (#4327)
* remove instructions about removed Vagrantfile

* rewrite docker instructions

* say where docker-compose can be run

* give better intro for macOS devs

* prompt people for permission to install OS packages

* reword awkward sentence

* Change WORKDIR to /opt/certbot/src

This change is OK because all paths used in Dockerfile-dev are absolute paths.

* remove 'cd src' instructions for Dockerfile-dev

* Improve docker-compose testing instructions
2017-03-10 17:27:09 -08:00
Brad WarrenandGitHub 662c323b55 Build wheels correctly for Python 2.6 (#4313)
* stop conditionally pinning mock version in acme

* stop conditionally pinning mock version in certbot

* stop conditionally pinning mock version in apache

* stop conditionally pinning mock version in nginx

* stop conditionally pinning mock version in letshelp

* stop conditionally pinning mock version in compatibility-test
2017-03-10 10:58:03 -08:00
Erik RoseandBrad Warren 8f10103496 Make argparse dependency unconditional. (#2249)
The primary motivation is to avoid a branch, giving bugs one fewer place to hide. But, as a bonus, more people get a more bugfixed version of argparse. (To use the example from the argparse docs, people stuck on Python 3.2.3 can get bugfixes that made it into the stdlib only in 3.2.4.)
2017-03-08 17:10:12 -08:00
陈三andBrad Warren 6669b95a4e Updated the deprecated arguments (#4306) 2017-03-07 11:19:55 -08:00
Brad Warren ca42e99222 add certbot wrapper to Dockerfile-old 2017-03-06 19:31:42 -08:00
Brad Warren eb1e3c4cb3 add docker-warning script 2017-03-06 19:31:42 -08:00
Brad Warren fb9b62a282 add Dockerfile-old 2017-03-06 19:31:38 -08:00
Brad Warren 3d5c0842cb Merge branch 'master' into dockerfile++ 2017-03-06 19:31:13 -08:00
Brad Warren f94c4eeff1 only copy necessary files in Dockerfile 2017-03-06 19:31:09 -08:00
Brad Warren 6f8bf74c53 sort directives that never change in Dockerfile 2017-03-06 19:31:05 -08:00
Brad Warren b23a259390 Don't install unnecessary packages in Dockerfile 2017-03-06 19:30:49 -08:00
sedrubalandJacob Hoffman-Andrews 5d75906b27 Fix print for python3 in certbot-auto (#4263)
Use printfunction from __future__ in order to get letsencrypt installed on a python3 only system.
2017-03-06 17:34:03 -08:00
Brad WarrenandJacob Hoffman-Andrews 82736e21d4 Improve path_surgery warning (#4293)
Stops output like:

Failed to find certbot.log in PATH: ...
renew-hook command certbot.log exists, but is not executable.
2017-03-06 17:32:49 -08:00
Brad WarrenandJacob Hoffman-Andrews 4a2582dda4 Remove broken known issues link (#4294) 2017-03-06 17:31:28 -08:00
Shiloh HeurichandBrad Warren 2862ade0b1 docs(ciphers): newer keylength.com recommendations (#4266) 2017-03-03 10:44:12 -08:00
Jacob Hoffman-AndrewsandBrad Warren ea578870da ipdb can now be run without pip installing. (#4257) 2017-03-03 10:37:31 -08:00
Alex BowersandBrad Warren 80326511bb Improve error reporting for hooks (#4235)
* Improve error reporting for hooks

* My bad

* Whitespace.
2017-03-03 10:28:05 -08:00
yonjahandBrad Warren 1507b6b731 Added documentation about renew exit status #Fixes #4090 (#4234)
* Added documentation about renew exit status #Fixes #4090

* recommend using post-hook instead of renew-hook
2017-03-03 08:34:30 -08:00
Blake GriffithandJacob Hoffman-Andrews 12a6e49cf1 Remove use of sha1 (#4271)
These are not security critical uses of sha1 but they should still be removed.
2017-03-02 21:16:19 -08:00
yomnaandBrad Warren 93908a33bc [#3451] small changes to the standalone documentation (#4247) 2017-03-02 17:28:45 -08:00
Jacob Hoffman-AndrewsandBrad Warren 53117b0ce0 Remove UnexpectedUpdate exceptions. (#4197)
* Remove UnexpectedUpdate exceptions.

These exceptions trigger when the server sends the client back an object with a
field that doesn't exactly match what the client previously sent.

This causes unnecessary breakage in various cases, doesn't prevent any problems,
and isn't required by spec.

* Back out all UnexpectedUpdate removals except registration update.
2017-03-02 17:27:29 -08:00
Sagi KedmiandBrad Warren 26a7023b8d Change QSA to NE in HTTPS redirection (#4204)
* Change QSA to NE in HTTPS redirection

* Seamless transition to new HTTPS redirection RewriteRule
2017-03-02 16:49:34 -08:00
Erica PortnoyandBrad Warren d66b25bf5c update changelog (#4287) 2017-03-02 15:46:16 -08:00
Erica PortnoyandBrad Warren 5e671682ca Candidate 0.12.0 (#4286)
* Release 0.12.0

* Bump version to 0.13.0
2017-03-02 15:26:24 -08:00
Noah SwartzandBrad Warren b040717e4d Changelog (#4252)
* made a changelog

* fix date for 0.6.0

* fix brad nits

* fix typo
2017-03-02 10:31:55 -08:00
Brad WarrenandGitHub 5e6a6f51d3 Fix test_leauto_upgrades.sh (#4278)
* fix-test-leauto-upgrades

* redirect stderr

* redirect stderr part 2
2017-03-02 10:31:37 -08:00
Brad WarrenandGitHub 11ec1eb911 Revert "Remove Link rel=next for authzs and new-certs." (#4277) 2017-03-02 10:31:15 -08:00
Noah SwartzandGitHub 33f43512db Merge pull request #4230 from certbot/jsha-patch-1
Remove reference to #certbot on OFTC
2017-02-28 18:33:41 -08:00
Brad WarrenandGitHub 0d8a4b4ebd Make mod-check more flexible (#4268)
* fixes #4166

* Run mod-check from anywhere

* pass TRAVIS_BRANCH through in tox
2017-02-28 15:17:07 -08:00
Damien TournoudandBrad Warren 44a6ec29c5 Fix direct usages of the root logger (#4236)
Some code uses `logging.debug` and `logging.info` instead of
the file-specific logger in `logger.debug` and `logger.info`.
2017-02-27 18:13:06 -08:00
Brad WarrenandGitHub 402ad8b353 bump requests requirement to >=2.10 (#4248) 2017-02-27 17:17:08 -08:00
Brad WarrenandGitHub 80055ec770 Cleanup issue template (#4256) 2017-02-27 15:15:19 -08:00
Erica PortnoyandBrad Warren e5909d379c Don't crash on listen unix: (#4259)
Fixes #4225.

* don't crash on listen unix:

* correctly merge #4221
2017-02-27 13:35:29 -08:00
Osiris Inferi bb35126a2c Deprecated standalone-preferred-challenges 2017-02-27 20:39:42 +01:00
Yen Chi HsuanandBrad Warren 7d02e129f9 Fix certbot-apache tests on Python 3 (#4172) 2017-02-24 18:21:21 -08:00
Noah SwartzandBrad Warren d066f8b38b created an issue template (#4201)
* created an issue template

* bmw changes
2017-02-24 13:08:25 -08:00
Joona HoikkalaandJacob Hoffman-Andrews e02d641490 Docker changes for easier testing (#4249)
These changes allow developers to run tests directly from the host machine using Docker, and to enable ipdb inside the container.

docker-compose.yml is upgraded to version 2 format. This means that you need docker-engine version >= 1.10.0 instead of previous requirement of version >= 1.9.1. The reason for this is to be able to use custom Dockerfile (Dockerfile-dev in this case) in build context.

ipdb has been added to dev dependencies to be able to be able to debug the code without installing it on every docker run. This is also what we recommend for debugging in the developer documentation, so there really is no reason not to install it with the dev dependencies.

setuptools is being upgraded to a newer version to be able to run coverage tests. This was using the older version of setuptools for some reason, and without the upgrade, coverage tests would fail horribly. Upgrading remedies the situation.

Few examples: 

Run unit tests for certbot-apache
`docker-compose run --rm --service-ports development bash -c 'cd src;nosetests -v certbot-apache'`

Run coverage tests
`docker-compose run --rm --service-ports development bash -c 'cd src;./tox.cover.sh'`

Run linter
`docker-compose run --rm --service-ports development bash -c 'cd src;tox -e lint'`
2017-02-24 11:40:03 -08:00
Joona HoikkalaandBrad Warren 28cbd6e7d3 Fix for case sensitivity when looking for vhosts (#4193) 2017-02-23 20:28:36 -08:00
Erica PortnoyandBrad Warren 52ce335ff0 lineage_for_certname should return None if there is no existing renewal file (#4243)
* lineage_for_certname should return None if there is no existing renewal file

* add unit test

* add regression test to integration test

* revent boulder-start to boulder-fetch
2017-02-23 18:31:23 -08:00
silverwindandBrad Warren b1a4280519 Show error details for the nginx config parser (#4221)
Nginx parser errors now include helpful details on where parsing has
actually failed.

Related: https://github.com/certbot/certbot/issues/3798
2017-02-22 18:50:56 -08:00
Jacob Hoffman-AndrewsandBrad Warren a92ca8e97c Add default timeout to ClientNetwork. (#4217)
In https://community.letsencrypt.org/t/letsencrypt-cli-hangs-on-certificate-request/27211,
a community member pointed out that Certbot seems to hang when there are
routing problems.
2017-02-22 18:48:01 -08:00
Erica PortnoyandBrad Warren 5bab6b512f Refactor main (#4127)
* Refactor main to simplify logic

* Update tests and comments

* Correct main test

* increase timeout limit

* reset timeout limit

* call renew_cert in appropriate main test

* Update docstrings and revert signatures of _report_new_cert and _suggest_donation_of_appropriate

* replace renew_cert logic

* update tests

* rename _csr_obtain_cert and add a check to _report_new_cert
2017-02-22 13:08:56 -08:00
Jacob Hoffman-AndrewsandGitHub ebf5170d12 Update testing docs. (#4211)
Recommend faster-running commands with clearer output first, building up to
slow, noisy, `tox` last.

Remove outdated Boulder testing advice, and outdated Boulder testing scripts
(Vagrantfile, mac-bootstrap.sh, boulder-start.sh). Update Boulder testing
section.

Fill out "directory structure" section of contributing guide a little better.
2017-02-16 12:39:17 -08:00
Jacob Hoffman-AndrewsandGitHub 6a8113fa87 Remove reference to #certbot on OFTC
The #letsencrypt channel on Freenode is much more active, and is the defacto place for questions about Certbot. Users posting questions on #certbot on OFTC are not getting prompt answers.
2017-02-16 10:24:48 -08:00
Jacob Hoffman-AndrewsandGitHub 94aa562cf2 Use latest Boulder for Travis tests. (#4180) 2017-02-14 21:19:18 -08:00