Commit Graph
6707 Commits
Author SHA1 Message Date
Blake Griffith 156ea46a09 Compare initial and final signals in tests. 2016-07-09 16:27:49 -05:00
Blake Griffith ed73c55b7b Instantiate exception_raised in test. 2016-07-08 16:03:40 -05:00
Blake Griffith 4b4a02a7af Remove extra tracking of prev_handlers. 2016-07-07 20:07:13 -05:00
Blake Griffith e28560514a Test that ErrorHandler resets default signals. 2016-07-06 16:56:11 -05:00
Blake Griffith 2e7f02805c Call _call_signals after _reset_signals. 2016-07-06 15:59:51 -05:00
Blake Griffith 40983d67d7 Alphabetize imports in error_handler_test.py 2016-07-06 13:19:58 -05:00
Blake Griffith 3d3908c8b3 Update _call_signals docstring. 2016-07-06 13:19:03 -05:00
Blake Griffith ece1f6a24d Don't use _private functions in tests. 2016-07-05 23:32:22 -05:00
Blake Griffith e9f879a443 Use assertTrue and index in _SIGNALS 2016-07-05 23:32:22 -05:00
Blake Griffith 7ade835476 import module instead of function 2016-07-05 23:32:22 -05:00
Blake Griffith 8333829bbe Check that ErrorHandler raises exception. 2016-07-05 23:32:22 -05:00
Blake Griffith 5e4f250110 Stylize _signal_handler docstring. 2016-07-05 23:32:22 -05:00
Blake Griffith 815887d4e4 Refactor ErrorHandler.__exit__
also call_signal -> call_signals
2016-07-05 23:32:22 -05:00
Blake Griffith 277b7a89f1 Update ErrorHandler docstring. 2016-07-05 23:32:22 -05:00
Blake Griffith 79c602ffc8 Make non-public methods as private. 2016-07-05 23:14:53 -05:00
Blake Griffith 15336d45bd Reset self.body_executed in __enter__ 2016-07-05 23:14:53 -05:00
Blake Griffith 777a654d90 Move SignalExit to errors.py 2016-07-05 23:14:53 -05:00
Blake Griffith 92870f0bbb Better docstring for _signal_handler 2016-06-30 10:22:12 -05:00
Blake Griffith e652141449 Use lambda instead of closure. 2016-06-28 16:55:46 -05:00
Blake Griffith 1356941f97 Test signal handling in error handler. 2016-06-28 16:31:21 -05:00
Blake Griffith bbd5ce45e9 Defer signals in ErrorHandler. 2016-06-28 16:31:21 -05:00
schoenandGitHub adeb39a7f2 Merge pull request #3218 from certbot/nginx-dirty-write-only
Only write nginx config files if they've been modified
2016-06-27 14:07:51 -07:00
schoenandGitHub eaf339632a Merge pull request #3184 from certbot/nginx-space-preservation
Nginx space preservation
2016-06-27 12:50:34 -07:00
Peter Eckersley bdbdd826de Extra comment & concision 2016-06-27 12:50:06 -07:00
Peter Eckersley 3e9bf2f35f Tests for UnspacedList.is_dirty() 2016-06-27 12:50:06 -07:00
Peter Eckersley 6017a6cb6d Only write nginx config files if we've modified them 2016-06-27 12:44:36 -07:00
Peter Eckersley 184f54cbc7 cosmetic improvements 2016-06-27 12:36:28 -07:00
Peter Eckersley fdbb69930b Tweak the NotImplementedError cases 2016-06-27 12:00:41 -07:00
Peter Eckersley 98d261596c Raise NotImplemented for all problematic list methods 2016-06-24 19:16:05 -07:00
Peter Eckersley 0dc4639cbf Be more explicit about range policing
(rather than doing it in some roundabout crazy way)
2016-06-24 18:56:30 -07:00
Peter Eckersley 880cb03191 Make assertions about index policing 2016-06-24 18:50:18 -07:00
Peter EckersleyandGitHub 236e3e611a Merge pull request #3208 from certbot/how2plugin
Better document plugins and reversion
2016-06-24 16:54:15 -07:00
Peter EckersleyandGitHub fbde8eff18 Merge pull request #3209 from certbot/remove-a-word
Fix typo
2016-06-24 16:53:33 -07:00
Peter Eckersley 6a938f2ee7 Fix docstring nit 2016-06-24 16:52:02 -07:00
Peter Eckersley 8f0a5fdc66 Fix a bug in the new index calculations 2016-06-24 16:48:30 -07:00
Peter Eckersley 20b92a3c1f Add some test coverage 2016-06-24 16:48:22 -07:00
Peter Eckersley 9da533d92e Be more succinct 2016-06-24 16:13:12 -07:00
Peter Eckersley e415a4d402 For now, instead, consider this NotImplemented 2016-06-24 14:36:23 -07:00
Peter Eckersley ad13b525b2 For reference, a buggy attempt to implement slicing
but slice assignment seems to mangle the .spaced list in some cases
2016-06-24 14:35:42 -07:00
Peter Eckersley 6930523c14 Refactor to simplify indenation handling 2016-06-23 17:59:26 -07:00
Brad Warren bac988a404 Fix typo 2016-06-23 17:24:05 -07:00
Brad Warren 02c61cffb7 Consistent capitialization with installer 2016-06-23 17:17:17 -07:00
Brad Warren 7aa6becc5b Suggest reverter for installers 2016-06-23 17:16:58 -07:00
Brad Warren 7e5e016982 Document that only save should make checkpoints 2016-06-23 17:10:03 -07:00
schoenandGitHub fd35ca5be4 Merge pull request #3207 from vszakats/patch-1
cli-help: fix spelling
2016-06-23 17:09:11 -07:00
Brad Warren 38feb37d3e Further document reverter 2016-06-23 17:03:01 -07:00
Peter EckersleyandGitHub 2daa081402 Merge pull request #3204 from certbot/nginx-reversion
Fix Nginx reversion
2016-06-23 16:29:10 -07:00
Brad Warren cb441606d5 Explictly state assumptions made by certbot 2016-06-23 16:14:34 -07:00
Viktor SzakatsandGitHub 3178a9f0f3 cli-help: fix spelling 2016-06-24 00:24:53 +02:00
Peter Eckersley a29c6e3102 Try simplifying handling of spacey sublists
- this was causing test failures but they may all have been fixed by other
   changes...
2016-06-23 14:06:32 -07:00