Commit Graph
100 Commits
Author SHA1 Message Date
Peter Eckersley d8a32eeeb5 Chase all the mock threads all over the place 2015-11-13 17:38:55 -08:00
Peter Eckersley 2433de8cba Attempt to update revoke() cases [not yet working] 2015-11-13 12:48:44 -08:00
Peter Eckersley 7e1a59ab29 Address review comments 2015-11-13 12:48:38 -08:00
Peter Eckersley e8cf095ef3 Fix merge glitch
(somehow this was lost from the previous commit)
2015-11-13 09:56:50 -08:00
Peter Eckersley a45de558de Merge remote-tracking branch 'origin/master' into useragent 2015-11-13 01:39:27 -08:00
Peter Eckersley 3551ffbd64 Replace "which" with "command -v"
Since the latter is at least semi-POSIX compliant:

http://pubs.opengroup.org/onlinepubs/009696899/utilities/command.html

Avoids the need for #1486
2015-11-13 01:31:14 -08:00
Peter Eckersley 3687197db8 Move user agent selection into client.py
Along the way refactoring revocation and recording of chosen plugins.
2015-11-12 19:52:32 -08:00
Peter Eckersley 1bfd44ea34 Address review comments:
- make --user-agent a general CLI option
 - get_os_info return type
2015-11-12 17:31:32 -08:00
Peter Eckersley eda5b71a78 Merge remote-tracking branch 'origin/master' into comment 2015-11-11 23:53:42 -08:00
Peter Eckersley 9d68cda93f Merge remote-tracking branch 'origin/master' into auto 2015-11-11 23:53:21 -08:00
Peter Eckersley 79646dc42d Fix misplaced verbosity from pip 2015-11-11 12:59:36 -08:00
Peter Eckersley b26a87a33c Comments on SUDO 2015-11-11 12:57:32 -08:00
Peter Eckersley 5ce9240200 Improve comments for letsencrypt-auto 2015-11-11 12:42:07 -08:00
Peter Eckersley 0a72ebb379 get_os_info review fixes
- handle broken platform.linux_distribution()
 - document return type
2015-11-10 20:13:44 -08:00
Peter Eckersley 7dcf8a32f4 Only send the major version of OS X 2015-11-10 16:50:58 -08:00
Peter Eckersley 8b9a271900 "Really" finalise User Agent tests
- Add an extra test for the default UA string
 - Fixes: get_os_info() is returning a tuple, not a string
 - Workaround: Argument preprocessing is dangerous for test cases
2015-11-10 16:50:58 -08:00
Peter Eckersley a4885e491a Finish user agent changes:
- revert changes to acme/, instead living with its current baroque API
 - add an extremely mockable test case
2015-11-10 16:50:57 -08:00
Peter Eckersley baaeab5fa1 Fix lints & glitches 2015-11-09 22:44:26 -08:00
Peter Eckersley 88cc01301a Creation & plumbing for user agent 2015-11-09 22:17:38 -08:00
Peter Eckersley 7b352d3d80 Handle FreeBSD and Windows 2015-11-09 18:21:39 -08:00
Peter Eckersley 6c3ea0d2a1 Merge branch 'config_sanity' 2015-11-09 16:19:21 -08:00
Peter Eckersley d29ab2a523 Make final tweaks for landing #1421 2015-11-09 16:18:51 -08:00
Peter Eckersley 01c733bed1 Fix ExperimentalBootstrap on Mac
Fixes: #1408
2015-11-07 20:36:30 -08:00
Peter Eckersley a6a00c108b Update test to reflect name change. 2015-11-07 03:02:32 -08:00
Peter Eckersley 63135be7c2 Downgrade a very excitable security comment to an XXX
Resolves: #1400

Also note that this function will need to become more sophisticated as we
support autoupdating of config options (eg those changed in #1390)
2015-11-06 19:36:22 -08:00
Peter Eckersley 291c5c7132 Remove nonsensical Apache config directives
- AcceptPathInfo Off was breaking things (fixes: #1274)
- Enabling DEFLATE compression for HTML and XML may make the site vulnerable to BREACH!
2015-11-06 12:42:13 -08:00
Peter Eckersley 24651e6b3f Handle py2.6 correctly ; be precise in documentation 2015-11-05 19:42:13 -08:00
Peter Eckersley c0dd6e1dc8 Document --debug voodoo :) 2015-11-05 19:09:40 -08:00
Peter Eckersley 987840a539 Archlinux is tested 2015-11-05 19:09:38 -08:00
Peter Eckersley 573f32c748 React badly to python <= 2.5; let the user set LE_PYTHON 2015-11-04 18:09:05 -08:00
Peter Eckersley 167cf008d0 Merge the streams fully: python2.6 triggers --debug requirement 2015-11-04 17:13:38 -08:00
Peter Eckersley 3faa93ab28 Merge remote-tracking branch 'kuba/auto-2.6-squeeze' into both
Combining the --debug gating changes with Kuba's 2.6 support
2015-11-04 17:09:44 -08:00
Peter Eckersley abfa6db83f elif nit 2015-11-04 16:51:13 -08:00
Peter Eckersley d2f1ae9c38 Require --debug for letsencrypt-auto on platforms thare aren't regularly tested
Mitigates: #1270 #1196
2015-11-04 13:59:50 -08:00
Peter Eckersley 21bfe5b983 Remove stray variable 2015-11-01 22:48:58 -08:00
Peter Eckersley a5e815008e Factor out all the stdout wrangling from help tests 2015-10-30 15:22:05 -07:00
Peter Eckersley f00280f71a Testiness 2015-10-30 15:12:54 -07:00
Peter Eckersley e4b10f76f9 Delint 2015-10-30 14:59:30 -07:00
Peter Eckersley 3356ce7558 This is a pretty silly lint warning that we're hitting a lot 2015-10-30 14:59:30 -07:00
Peter Eckersley fa7aed4d63 Ensure that mandatory flags are displayed under the relevant verb help topics
Closes: #996

In part our problem was trying to pick a single topic ("paths") for flags that
become essential in some cases.  But we were also calling _paths_parser before
all the topic groups had been created.
2015-10-30 14:58:43 -07:00
Peter Eckersley 0d12ded6fe Alias "everything" correctly 2015-10-28 19:19:06 -07:00
Peter Eckersley 28071a3e72 Fix stray ref 2015-10-28 19:19:06 -07:00
Peter Eckersley 8476efe86b Inversion: make certonly the real verb, and "auth" an alias for it 2015-10-28 19:19:06 -07:00
Peter Eckersley 7e717a7a15 lint 2015-10-28 19:19:06 -07:00
Peter Eckersley 60a0b01d59 Don't initialise plugins super early
Also extra unit testing
2015-10-28 19:19:06 -07:00
Peter Eckersley 01fabbe893 Also make apache docs conditional? 2015-10-28 19:19:06 -07:00
Peter Eckersley ed69ae0292 Don't suggest that --nginx is available if it isn't
Fixes: #932
2015-10-28 19:19:05 -07:00
Peter Eckersley 00dcff6de9 Also slip in some extra conditional plugin cli unit tests 2015-10-28 19:19:05 -07:00
Peter Eckersley 9a6ecbe669 Test case for new verb variant 2015-10-28 19:19:05 -07:00
Peter Eckersley 84dad86d61 Update the help for modern verbiage 2015-10-28 19:19:05 -07:00
Peter Eckersley ec25612d60 For now, use the absolutely minimal implementation of verb synonyms
Under the hood, everything can remain "run" and "auth" for now.
2015-10-28 19:19:05 -07:00
Peter Eckersley 585e6cee6c Make "everything" a synonym for "run" 2015-10-28 19:19:05 -07:00
Peter Eckersley c93512d2e1 Make "certonly" a synonym for "auth", and document it
Closes: #657
2015-10-28 19:19:05 -07:00
Peter Eckersley 195f36e4e1 plugin_ep.problem unittests
and some misc style things
2015-10-24 14:09:34 -07:00
Peter Eckersley 4def79d306 Display the Exception as well as the error message 2015-10-24 13:38:03 -07:00
Peter Eckersley e3d56b51c4 Fix nit. 2015-10-24 13:14:19 -07:00
Peter Eckersley ce32d87ad6 Document the requirement for SANs in CSRs if using --csr 2015-10-23 19:19:09 -07:00
Peter Eckersley efa1d6d38e Reintroduce a bit more verbosity about virtualenv? 2015-10-23 17:27:55 -07:00
Peter Eckersley 6b6a20b5e5 typo 2015-10-23 17:24:17 -07:00
Peter Eckersley aa3f493341 Fix fragment link nit 2015-10-23 17:23:26 -07:00
Peter Eckersley f66334a782 chmod a+x 2015-10-23 17:22:26 -07:00
Peter Eckersley a567c0578f Pass plugin errors back out to the user.
Closes: #971
2015-10-23 17:17:23 -07:00
Peter Eckersley 49a26ad013 Merge remote-tracking branch 'origin/master' into devdocs 2015-10-23 16:44:30 -07:00
Peter Eckersley e19e0dc2e9 This section is now redundant 2015-10-23 16:18:08 -07:00
Peter Eckersley 096b5ec32a Back out ./letsencrypt-dev; document "activate" more clearly 2015-10-23 16:12:33 -07:00
Peter Eckersley ad56bbbceb Cleanup plugin docs 2015-10-23 15:00:00 -07:00
Peter Eckersley 027a7d755d Update developer docs
- Discuss letsencrypt-dev
 - Be clearer in general
2015-10-23 15:00:00 -07:00
Peter Eckersley 1c215d0c67 Sphinxify
also pythonic str instead of string
2015-10-21 23:10:55 -07:00
Peter Eckersley 8a09e616c2 its it's 2015-10-21 22:58:18 -07:00
Peter Eckersley cf5cb9d3ff Satisfy pylint... sort of 2015-10-21 21:16:35 -07:00
Peter Eckersley ccfeeb9fe5 Fix test cases; along the way, have --csr save fullchain.pem 2015-10-21 21:00:30 -07:00
Peter Eckersley c2db967a93 Merge remote-tracking branch 'origin/master' into fullchain-doc 2015-10-21 17:24:48 -07:00
Peter Eckersley 6382b184f0 Update documentation of tested platforms 2015-10-21 16:59:54 -07:00
Peter Eckersley 7ce1da56d5 Point the user to fullchain.pem, not cert.pem
Closes: #1024
2015-10-21 16:48:33 -07:00
Peter Eckersley db1f0a6688 Fix pip / nginx heisenbug
Closes: #1072
2015-10-21 13:54:29 -07:00
Peter Eckersley 41a59c0e15 typo 2015-10-21 12:27:22 -07:00
Peter Eckersley 059ca6dbce Make debian bootstrapper more agnostic about venv packaging
Closes: #1061
2015-10-21 12:23:30 -07:00
Peter Eckersley f130cb470c Don't find "-v" in "--version"
Fixes #1065
2015-10-21 10:58:36 -07:00
Peter Eckersley e7182848a0 Keep @bmw's sense of aesthetics happy :) 2015-10-20 14:04:58 -07:00
Peter Eckersley b01bf571ca more typos 2015-10-20 14:03:06 -07:00
Peter Eckersley 05293cd597 typosquash 2015-10-20 14:01:29 -07:00
Peter Eckersley dde3e685f0 Fix stray --standalone help
And a few layout nits
2015-10-20 13:49:44 -07:00
Peter Eckersley 738684d437 Revert to "run" as the default in all cases 2015-10-20 13:28:56 -07:00
Peter Eckersley 719cbdb488 --apache etc should be documented in the "plugins" section 2015-10-20 10:58:47 -07:00
Peter Eckersley 2c4d4a8169 "letsencrypt everything" is not yet implemented :/ 2015-10-20 10:35:17 -07:00
Peter Eckersley efe51e02be Explain the --standalone change in defaults 2015-10-20 10:34:31 -07:00
Peter Eckersley 54a738492b Fix typo 2015-10-20 01:22:04 -07:00
Peter Eckersley adcb0052a1 Implement --standalone as specified.
Closes #1036
2015-10-20 00:30:44 -07:00
Peter Eckersley 363dffd8a6 Comment out a test that requires slightly doubtful infrastructure 2015-10-19 19:51:02 -07:00
Peter Eckersley 51ed2b681f We're not mocking out plugins
So we don't need infrastructure for it
2015-10-19 19:41:37 -07:00
Peter Eckersley e384a1fe28 Catch some excessive policing of installers 2015-10-19 19:35:53 -07:00
Peter Eckersley 72589bcae3 Lint 2015-10-19 19:31:09 -07:00
Peter Eckersley 6460a3b50e Dial back the "authenticator doesn't make sense in install mode" message
Since it was breaking integration tests
2015-10-19 19:27:36 -07:00
Peter Eckersley eeeb66e58a document -d domain
Closes: #285 #787

we may want to implement the other thing soon, but for now documenting what we
have
2015-10-19 19:15:11 -07:00
Peter Eckersley 484e8ef6fe Not trying to mock out plugins just yet 2015-10-19 19:11:05 -07:00
Peter Eckersley eac513d73b Offer more specific help if no installer is present
Fixes: #896
2015-10-19 17:21:47 -07:00
Peter Eckersley 26e7037794 Fix a mock type error 2015-10-19 12:15:11 -07:00
Peter Eckersley 39ae9bdf43 Document a somewhat cryptic function 2015-10-19 12:06:39 -07:00
Peter Eckersley 6e69e58402 Make more tests run regardless of local plugin state 2015-10-19 12:03:11 -07:00
Peter Eckersley e05073c33e debugging 2015-10-19 10:37:39 -07:00