starred/certbot-certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-08-01 19:02:52 +02:00
Code Issues Packages Projects Releases Wiki Activity
4,159 Commits 878 Branches 157 Tags
8e7104698680b20b29d8c646bc2a68c2cead2d3e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Peter Eckersley 1a4dd56f71 Address review comments 
(sometimes less less is more)
 2015-12-01 18:13:38 -08:00
Peter Eckersley e27e891615 nginx detail 2015-12-01 17:50:46 -08:00
Peter Eckersley 49efc489fc fixes 2015-12-01 17:49:49 -08:00
Peter Eckersley f15c4125d3 More-or-less-final README.rst 2015-12-01 17:39:33 -08:00
Peter Eckersley f4dd660403 Oops! 
- Finish a partial commit, providing what are perhaps excessively detailed and
  mystical errors in improbable cases.
 2015-12-01 16:50:39 -08:00
Peter Eckersley 06e273413b Fix nits and address review comments 2015-12-01 16:33:35 -08:00
Peter Eckersley 0b7552ef8b Begin cleaning up README.md 2015-12-01 15:16:17 -08:00
Peter Eckersley 2befb2d5c1 remove python2.7ism 2015-11-30 21:27:41 -08:00
Peter Eckersley 6b122a044a Too many lines? 
(That's probably true)
 2015-11-30 21:08:23 -08:00
Peter Eckersley 6c9ddf34e6 Merge remote-tracking branch 'origin/master' into webroot 2015-11-30 20:57:27 -08:00
Peter Eckersley ffd30d8c1e lint 2015-11-30 20:57:07 -08:00
Peter Eckersley bbc9cf3b6e Start a library of apache2 conf files for tests 
With examples of passing and failing conf files sourced from our github
tickets.
 2015-11-30 19:49:23 -08:00
Peter Eckersley 77778e85cc Restore --domain compatibility 
It probably should never have lapsed...
 2015-11-30 18:24:52 -08:00
Peter Eckersley 328f8cdc5b Document --webroot-path 2015-11-30 18:24:40 -08:00
Peter Eckersley 2b87d6f700 Do not accept -d first in the presence of multiple -w flags 
* informal testing suggested that many people found this behaviour confusing
 2015-11-30 18:15:07 -08:00
Peter Eckersley dcca05e537 py26reqs.txt needs to be path-relative 
Fixes: #1630
 2015-11-27 10:30:23 -08:00
Peter Eckersley c48ee677df Merge Augeas lens fix for backslashes in regexps 
https://github.com/hercules-team/augeas/issues/307
https://github.com/hercules-team/augeas/commit/155746c72f76937a21b1a035da5c56090a54ed13
 2015-11-26 16:59:06 -08:00
Peter Eckersley b3851edb73 Since --webroot-map is not elegant, do not document it 2015-11-24 14:02:21 -08:00
Peter Eckersley a3b0588cea lintmonster 2015-11-21 11:50:13 -08:00
Peter Eckersley 544fe8d708 Fix webroot tests 2015-11-21 11:23:53 -08:00
Peter Eckersley 5beccc080d Test for CLI --webroot-map parsing 2015-11-21 11:23:53 -08:00
Peter Eckersley 3cc8e7e019 Webroot cli now passes some tests! 2015-11-21 11:23:53 -08:00
Peter Eckersley 6a50a98ebe unoneline 2015-11-21 11:23:53 -08:00
Peter Eckersley d5e92289fc Test case for webroot_map construction 2015-11-21 11:22:43 -08:00
Peter Eckersley f48ef6ded9 lint 2015-11-21 10:59:15 -08:00
Peter Eckersley f2f9d33e03 Update _path_for_achall 
Borrowing from @grubberr's changes at:
https://github.com/letsencrypt/letsencrypt/pull/1284/files#diff-522ab130649a0ce14df40114d4ccd0b5L111
 2015-11-21 10:59:15 -08:00
Peter Eckersley ffe6226edc Switch webroot.prepare() to use config.webroot_map 2015-11-21 10:59:15 -08:00
Peter Eckersley e1f0fcca8f Move --webroot-path processing into cli.py 
Since it is now interdependent with --domains

(This is much more elegant than trying to APIify the interaction)
 2015-11-21 10:59:15 -08:00
Peter Eckersley 19f348b416 First implementation of -w for multi-webroot specification 
* Will need tests and cleanup
 2015-11-21 10:59:15 -08:00
Peter Eckersley c3e2c58272 Fix comment nits 2015-11-20 19:02:50 -08:00
Peter Eckersley 1a4d7c1445 Lintmonster 2015-11-20 19:02:50 -08:00
Peter Eckersley ec267cf215 "Compute" the minimum height needed to reasonably display input 2015-11-20 19:02:50 -08:00
Peter Eckersley c35c4f3fbe Extra docstring 2015-11-20 19:02:50 -08:00
Peter Eckersley 5829e25804 Always use the specified GPG for signing everything. 2015-11-18 14:26:01 -08:00
Peter Eckersley 1e09d7e2ff Also implement --manual 2015-11-17 17:11:03 -08:00
Peter Eckersley ec18196511 lintmonster 2015-11-17 16:50:03 -08:00
Peter Eckersley 9a8e6feb54 Implement --webroot 2015-11-17 16:29:06 -08:00
Peter Eckersley 981b9dd3bc Add test case for trying to register without email 2015-11-17 16:06:56 -08:00
Peter Eckersley 6d497b8076 Track recent boulder error change 2015-11-17 16:06:56 -08:00
Peter Eckersley f74da52320 Avoid hacky --email "" case for integration tests 2015-11-17 16:06:49 -08:00
Peter Eckersley c6bb119d43 Test perform_registration recursion 2015-11-16 17:52:06 -08:00
Peter Eckersley c265fb5fb9 Fix bugs and test cases 2015-11-16 17:28:56 -08:00
Peter Eckersley 2d07c017b2 Test cases for get_email 2015-11-16 16:57:48 -08:00
Peter Eckersley 371e57fc51 If the server rejects an email address, ask again rather than erroring 
This is essentially symmetrical with cases where the client itself can tell
that what the user entered isn't an email address.
 2015-11-16 16:57:48 -08:00
Peter Eckersley 77f2a29bfe Show the message about unsafe registration only conditionally 
- If the user enters a blank email, or one that doesn't check out
 2015-11-16 16:57:48 -08:00
Peter Eckersley d8a32eeeb5 Chase all the mock threads all over the place 2015-11-13 17:38:55 -08:00
Peter Eckersley 2433de8cba Attempt to update revoke() cases [not yet working] 2015-11-13 12:48:44 -08:00
Peter Eckersley 7e1a59ab29 Address review comments 2015-11-13 12:48:38 -08:00
Peter Eckersley e8cf095ef3 Fix merge glitch 
(somehow this was lost from the previous commit)
 2015-11-13 09:56:50 -08:00
Peter Eckersley a45de558de Merge remote-tracking branch 'origin/master' into useragent 2015-11-13 01:39:27 -08:00
Peter Eckersley 3551ffbd64 Replace "which" with "command -v" 
Since the latter is at least semi-POSIX compliant:

http://pubs.opengroup.org/onlinepubs/009696899/utilities/command.html

Avoids the need for #1486
 2015-11-13 01:31:14 -08:00
Peter Eckersley 3687197db8 Move user agent selection into client.py 
Along the way refactoring revocation and recording of chosen plugins.
 2015-11-12 19:52:32 -08:00
Peter Eckersley 1bfd44ea34 Address review comments: 
- make --user-agent a general CLI option
 - get_os_info return type
 2015-11-12 17:31:32 -08:00
Peter Eckersley fa970916a2 Merge remote-tracking branch 'origin/master' into amazonlinux 2015-11-12 14:57:19 -08:00
Peter Eckersley eda5b71a78 Merge remote-tracking branch 'origin/master' into comment 2015-11-11 23:53:42 -08:00
Peter Eckersley 9d68cda93f Merge remote-tracking branch 'origin/master' into auto 2015-11-11 23:53:21 -08:00
Peter Eckersley 79646dc42d Fix misplaced verbosity from pip 2015-11-11 12:59:36 -08:00
Peter Eckersley b26a87a33c Comments on SUDO 2015-11-11 12:57:32 -08:00
Peter Eckersley 5ce9240200 Improve comments for letsencrypt-auto 2015-11-11 12:42:07 -08:00
Peter Eckersley 28ef1eae8d Highly experimental Amazon Linux bootstrapping 2015-11-11 11:24:41 -08:00
Peter Eckersley 0a72ebb379 get_os_info review fixes 
- handle broken platform.linux_distribution()
 - document return type
 2015-11-10 20:13:44 -08:00
Peter Eckersley 7dcf8a32f4 Only send the major version of OS X 2015-11-10 16:50:58 -08:00
Peter Eckersley 8b9a271900 "Really" finalise User Agent tests 
- Add an extra test for the default UA string
 - Fixes: get_os_info() is returning a tuple, not a string
 - Workaround: Argument preprocessing is dangerous for test cases
 2015-11-10 16:50:58 -08:00
Peter Eckersley a4885e491a Finish user agent changes: 
- revert changes to acme/, instead living with its current baroque API
 - add an extremely mockable test case
 2015-11-10 16:50:57 -08:00
Peter Eckersley baaeab5fa1 Fix lints & glitches 2015-11-09 22:44:26 -08:00
Peter Eckersley 88cc01301a Creation & plumbing for user agent 2015-11-09 22:17:38 -08:00
Peter Eckersley 7b352d3d80 Handle FreeBSD and Windows 2015-11-09 18:21:39 -08:00
Peter Eckersley 6c3ea0d2a1 Merge branch 'config_sanity' 2015-11-09 16:19:21 -08:00
Peter Eckersley d29ab2a523 Make final tweaks for landing #1421 2015-11-09 16:18:51 -08:00
Peter Eckersley 01c733bed1 Fix ExperimentalBootstrap on Mac 
Fixes: #1408
 2015-11-07 20:36:30 -08:00
Peter Eckersley a6a00c108b Update test to reflect name change. 2015-11-07 03:02:32 -08:00
Peter Eckersley 63135be7c2 Downgrade a very excitable security comment to an XXX 
Resolves: #1400

Also note that this function will need to become more sophisticated as we
support autoupdating of config options (eg those changed in #1390)
 2015-11-06 19:36:22 -08:00
Peter Eckersley 291c5c7132 Remove nonsensical Apache config directives 
- AcceptPathInfo Off was breaking things (fixes: #1274)
- Enabling DEFLATE compression for HTML and XML may make the site vulnerable to BREACH!
 2015-11-06 12:42:13 -08:00
Peter Eckersley 24651e6b3f Handle py2.6 correctly ; be precise in documentation 2015-11-05 19:42:13 -08:00
Peter Eckersley c0dd6e1dc8 Document --debug voodoo :) 2015-11-05 19:09:40 -08:00
Peter Eckersley 987840a539 Archlinux is tested 2015-11-05 19:09:38 -08:00
Peter Eckersley 573f32c748 React badly to python <= 2.5; let the user set LE_PYTHON 2015-11-04 18:09:05 -08:00
Peter Eckersley 167cf008d0 Merge the streams fully: python2.6 triggers --debug requirement 2015-11-04 17:13:38 -08:00
Peter Eckersley 3faa93ab28 Merge remote-tracking branch 'kuba/auto-2.6-squeeze' into both 
Combining the --debug gating changes with Kuba's 2.6 support
 2015-11-04 17:09:44 -08:00
Peter Eckersley abfa6db83f elif nit 2015-11-04 16:51:13 -08:00
Peter Eckersley d2f1ae9c38 Require --debug for letsencrypt-auto on platforms thare aren't regularly tested 
Mitigates: #1270 #1196
 2015-11-04 13:59:50 -08:00
Peter Eckersley 21bfe5b983 Remove stray variable 2015-11-01 22:48:58 -08:00
Peter Eckersley a5e815008e Factor out all the stdout wrangling from help tests 2015-10-30 15:22:05 -07:00
Peter Eckersley f00280f71a Testiness 2015-10-30 15:12:54 -07:00
Peter Eckersley e4b10f76f9 Delint 2015-10-30 14:59:30 -07:00
Peter Eckersley 3356ce7558 This is a pretty silly lint warning that we're hitting a lot 2015-10-30 14:59:30 -07:00
Peter Eckersley fa7aed4d63 Ensure that mandatory flags are displayed under the relevant verb help topics 
Closes: #996

In part our problem was trying to pick a single topic ("paths") for flags that
become essential in some cases.  But we were also calling _paths_parser before
all the topic groups had been created.
 2015-10-30 14:58:43 -07:00
Peter Eckersley 0d12ded6fe Alias "everything" correctly 2015-10-28 19:19:06 -07:00
Peter Eckersley 28071a3e72 Fix stray ref 2015-10-28 19:19:06 -07:00
Peter Eckersley 8476efe86b Inversion: make certonly the real verb, and "auth" an alias for it 2015-10-28 19:19:06 -07:00
Peter Eckersley 7e717a7a15 lint 2015-10-28 19:19:06 -07:00
Peter Eckersley 60a0b01d59 Don't initialise plugins super early 
Also extra unit testing
 2015-10-28 19:19:06 -07:00
Peter Eckersley 01fabbe893 Also make apache docs conditional? 2015-10-28 19:19:06 -07:00
Peter Eckersley ed69ae0292 Don't suggest that --nginx is available if it isn't 
Fixes: #932
 2015-10-28 19:19:05 -07:00
Peter Eckersley 00dcff6de9 Also slip in some extra conditional plugin cli unit tests 2015-10-28 19:19:05 -07:00
Peter Eckersley 9a6ecbe669 Test case for new verb variant 2015-10-28 19:19:05 -07:00
Peter Eckersley 84dad86d61 Update the help for modern verbiage 2015-10-28 19:19:05 -07:00
Peter Eckersley ec25612d60 For now, use the absolutely minimal implementation of verb synonyms 
Under the hood, everything can remain "run" and "auth" for now.
 2015-10-28 19:19:05 -07:00
Peter Eckersley 585e6cee6c Make "everything" a synonym for "run" 2015-10-28 19:19:05 -07:00
Peter Eckersley c93512d2e1 Make "certonly" a synonym for "auth", and document it 
Closes: #657
 2015-10-28 19:19:05 -07:00