Commit Graph
7916 Commits
Author SHA1 Message Date
Noah SwartzandGitHub bb6a22b985 Merge pull request #4943 from certbot/issue_4520
add deprecation warning
2017-07-19 15:51:51 -07:00
Noah SwartzandGitHub 7f19ac5e3d Merge pull request #4941 from certbot/issue_4866
add disable pip version check flag
2017-07-19 15:36:29 -07:00
Noah Swartz 9878f15966 leave macos unchanged 2017-07-19 11:55:53 -07:00
Noah Swartz 1cf8c5a586 add changes to template 2017-07-18 16:37:03 -07:00
Noah Swartz 56ce87db27 Merge branch 'master' into issue_4866 2017-07-18 16:34:35 -07:00
Noah Swartz fa74a32245 updated letsencrypt-auto.template 2017-07-18 16:27:33 -07:00
Jacob Hoffman-AndrewsandBrad Warren b3004fe6cf Handle critical SAN extension. (#4931)
* Handle critical SAN extension.

* Add testdata/critical-san.pem.
2017-07-18 15:57:00 -07:00
Noah SwartzandBrad Warren 278194fe6d add log rotation info (#4942) 2017-07-18 15:50:23 -07:00
Jacob Hoffman-AndrewsandBrad Warren d327c1c28f Tweak non-root error message. (#4944)
For most people, the right answer will be "run as root," so we should emphasize
that over the "how to run as non-root" instructions.
2017-07-18 12:47:10 -07:00
yomnaandGitHub 7d0e4d7bad Merge pull request #4915 from Baeumla/master
Check keys if revoke certificate by private key
2017-07-17 15:54:47 -07:00
Noah Swartz d962b2605a add deprecation warning 2017-07-17 15:27:48 -07:00
Brad WarrenandGitHub c779be8b88 Merge pull request #4863 from certbot/bmw-nginx-compatibility-tests
Nginx compatibility test
2017-07-17 14:32:39 -07:00
Noah Swartz f5580598cd add disable pip version check flag 2017-07-17 13:08:52 -07:00
Noah SwartzandGitHub 7ad41dc3ef Merge pull request #4939 from cj-dev/4893
Enhancement #4893. More copypastable output, including private key location on disk
2017-07-17 10:58:11 -07:00
Chris J a8b5dfc76c Enhancement #4893. More copypastable output, including private key location on disk 2017-07-16 22:38:21 -04:00
Baime 0f30f9e96f Added test to check revoke cert by key mismatch 2017-07-15 15:17:25 +02:00
Noah SwartzandGitHub 6090fe9651 Merge pull request #4899 from jonasbn/master
Added missing rst files as described in issue #4736
2017-07-14 18:47:31 -07:00
Noah SwartzandGitHub de1f9c4fe3 Merge pull request #4876 from tchollingsworth/combining-plugins-docs
docs: explain how to combine plugins
2017-07-14 18:42:06 -07:00
jonasbn 7ed2e91cc7 Removed null.rst as by request 2017-07-14 12:52:25 +02:00
r5dandohemorange 331d12ed50 certbot: Update storage.get_link_target (#4750) (#4923)
* certbot: Update storage.get_link_target (#4750)

* The `get_link_target` function raises `errors.CertStorageError` when
  link does not exists.

* certbot: Fix typo in storage.get_link_target.
2017-07-13 10:13:59 -07:00
Brad WarrenandGitHub 29d80f334f Merge pull request #4907 from certbot/backup-count
Make Certbot's log rotation configurable
2017-07-13 08:56:24 -05:00
Noah SwartzandGitHub 6ede309c6a Merge pull request #4865 from certbot/irc-notifications
Turn on IRC notifications for Travis failures in master
2017-07-12 13:03:37 -07:00
Noah SwartzandGitHub 7efa213b22 Merge pull request #4814 from certbot/improve-apache-error-message
Correct message about vhost ambiguity
2017-07-12 07:53:36 -07:00
Brad Warren a7a8e060e3 Finish adding configurable log rotation
* Update log backupCount name and description.

* Add additional error handling to --log-backups

* test --log-backups flag

* Pass log_backups value to RotatingFileHandler

* Test that log_backups is properly used

* add _test_success_common

* Add test_success_with_rollover

* Add test_success_without_rollover

* mock stderr in cli tests

* Set log_backups in PostArgParseSetupTest

* Rename "log backups" to "max log backups"
2017-07-11 21:14:18 -05:00
yomnaandBrad Warren bc3765d6d0 No longer mask failed challenge errors with encoding errors (#4867)
*     no longer masker failed challenge errors with encoding errors

* simplifying through type-checking

* bytes
2017-07-10 21:05:52 -05:00
John HarlanandBrad Warren fad1a4b576 Add flags to configure log rotation
* Add & enable --disable-log-rotation

* Add --max-log-count

* Correct max-log-count: remove action=store_true add type=int

* Add logging to cli argument groups.

* Add logging group to HELP_TOPICS in __init__

* Adjust line length

* test simplifying to one argument
2017-07-10 19:43:28 -05:00
Baime 368beee8bf Use correct key/cert for revoke by key test 2017-07-09 12:10:35 +02:00
Baime 3a9150a7ba Fix for revoke cert by key process 2017-07-08 19:36:39 +02:00
Baime ab286e0887 fixed path errors in revoking by key process 2017-07-08 18:00:33 +02:00
Baime 62bdf663f2 Check keys if revoke certificate by private key 2017-07-08 16:20:12 +02:00
Florian Mutterandohemorange 48ef16ab0d Align domain names output to command line input (#4874)
The command line takes a comma separated list of domain names. To be able to use the list of existing domain names it would be helpful to get a list that is also comma separated.

Sample use case: If you would like to add a new domain to an existing certificate you need to list all existing domain names.

Makes certbot certificates use comma-separated domain names instead of space-separated.
2017-07-07 12:46:30 -07:00
Felix YanandBrad Warren d0ecf739bd Add new DNS authenticator plugins in 0.16 (#4911) 2017-07-07 07:46:09 -04:00
ohemorangeandGitHub 57e56cc97b Candidate 0.16.0 (#4908)
* Release 0.16.0

* Bump version to 0.17.0
2017-07-06 15:57:11 -07:00
yomnaandGitHub 1f3b028398 Merge pull request #4895 from certbot/deploy-hook
Deploy hook
2017-07-06 15:56:55 -07:00
Brad WarrenandGitHub b23384438f update changelog for 0.16.0 release (#4906) 2017-07-06 15:46:21 -04:00
Brad Warren c3c1609fa0 no more renew(al) hook(s) 2017-07-06 14:59:28 -04:00
Brad Warren f314ea1d33 s/renew-hook/deploy-hook docs/using.rst 2017-07-06 10:30:29 -04:00
Felix YanandBrad Warren 6bb95c6596 Fix a typo: enviroment -> environment (#4898) 2017-07-05 12:59:23 -04:00
Brad WarrenandGitHub 5318945267 Hide exceptions that occur during session.close() (#4891)
* Hide exceptions that occur during session.close()

This fixes #4840. Exceptions that are raised out of __del__ methods are caught
and printed to stderr. By catching any exceptions that occur, we now prevent
this from happening.

Alternative solutions to this would have been either not calling
session.close() at all or adding a close() method to acme.client.ClientNetwork,
acme.client.Client, and certbot.client.Client and using certbot.client.Client
in a context manager to ensure close() is called. The former means that users
of the ACME library never properly close their connections until their program
exits and the latter adds a lot of complexity and nesting of client code for
little benefit.

* Only catch Exceptions
2017-07-05 09:25:44 -04:00
jonasbn 72c480ef18 Removed files with test in name after review comment from @ynasser 2017-07-04 23:52:24 +02:00
jonasbn 054873034c Added missed rst file 2017-07-02 00:31:58 +02:00
jonasbn d118acf524 Correction to module name 2017-07-02 00:16:15 +02:00
jonasbn ec35828b9a Added missing rst files after doing an inspection of the file structure 2017-07-02 00:12:16 +02:00
ohemorangeandGitHub 97b22da1b6 Replace the easy v. secure prompt with more clear choices (#4897)
* Replace the easy v. secure prompt with more clear choices
2017-06-30 17:12:09 -07:00
Brad Warren 62327b49c3 Test hook validation order 2017-06-30 11:40:34 -04:00
Brad Warren 4c19d19cf5 Test that deploy and renew hooks are saved right
It is important that both renew and deploy hooks are saved as renew_hook in
renewal configuration files to preserve forwards compatibility.
2017-06-30 11:30:21 -04:00
Brad Warren 6dedfa62b6 Test renew and deploy hooks are run properly 2017-06-30 11:06:51 -04:00
Brad Warren 8a664622ea Call deploy_hook during certonly and run 2017-06-30 10:33:49 -04:00
Brad Warren 1b65ba88d8 test hooks.deploy_hook 2017-06-30 10:30:33 -04:00
Brad Warren e94ee31a6f add hooks.deploy_hook 2017-06-30 10:24:00 -04:00