Commit Graph
7553 Commits
Author SHA1 Message Date
Jacob Hoffman-AndrewsandGitHub d5f1edf2bb Dump Boulder logs on integration test failures. (#4442)
Might help debug #4363.

Also:

make "bash" vs "sh" explicit
move the paranoia flags (-ex) from the shebang into the body
add -u (fail on unset variables)
change _common to work with -u
remove some env vars that were no longer used
remove shebang from _common.sh because it's meant to be sourced, not run
2017-03-29 16:48:08 -07:00
Yen Chi HsuanandBrad Warren 6fb78dab67 Fix Docker IP detection with different ifconfig output formats (#4376) 2017-03-29 13:34:09 -07:00
Zach ShepherdandBrad Warren 67e11ae1d8 tests: deduplicate temporary directory code (#4078) (#4297)
Introduce a test class to deduplicate temporary directory setup and teardown in
testing code and update existing test code to use this new class.
2017-03-29 10:01:16 -07:00
Noah SwartzandGitHub 446509620f Merge pull request #4420 from certbot/issue4331
Ensure --fullchain-path gets put under paths in --help all
2017-03-28 14:08:56 -07:00
Erica PortnoyandGitHub ece68a1864 Update Nginx ciphersuites to use Mozilla Intermediate (#4426)
* Update Nginx ciphersuites to use Mozilla intermediate

* update tests to match new behavior
2017-03-27 15:19:03 -07:00
Erica PortnoyandGitHub e9608945c3 Change registering unsafely without email logging level to info (#4425)
* Change registering unsafely without email logging level to info

* update test with new behavior
2017-03-27 14:47:14 -07:00
Erica Portnoy b7bb75886e Merge branch 'master' into issue4331 2017-03-27 14:08:39 -07:00
Zach ShepherdandBrad Warren 1c51ae2588 Pin python-augeas version to avoid error with 1.0.0 (#4422)
When running ./tools/venv.sh with 1.0.0 (now the latest version), I encountered:
    build/temp.linux-x86_64-2.7/augeas.c:434:35: fatal error: augeas.h: No such file or directory
2017-03-27 13:58:17 -07:00
Erica Portnoy 7d57e3104a Ensure --fulchain-path gets put under paths in --help all 2017-03-27 12:20:51 -07:00
Damien TournoudandJacob Hoffman-Andrews 5c93ceb675 acme: Make the network timeout configurable (#4237)
This follows up on https://github.com/certbot/certbot/pull/4217, but allows users to override the default setting.
2017-03-27 09:24:05 -07:00
Noah SwartzandGitHub 272a81b400 Merge pull request #4304 from certbot/package-guide
Improve packaging guide.
2017-03-27 08:53:26 -07:00
Jacob Hoffman-Andrews 2e102ec9f7 Review feedback. 2017-03-25 11:39:19 -07:00
Erica PortnoyandGitHub 7be2e79025 Fix nginx parser (#4296)
* rewrite nginx parser to allow everything that nginx does

* also make changes in tls_sni_01.py

* add test case with

* allow embedded variables

* allow empty ${} variable

* fix quotes

* un-special case if

* update all tests to reflect current parsing

* escape in QuotedString after merge

* add test cases for variable weirdness that are almost certainly nginx bugs

* update regex for correct variable rules

* close paren doesn't invoke last_space

* Make test file valid Nginx syntax
2017-03-24 19:45:53 -07:00
Noah SwartzandGitHub 09377437dc Merge pull request #4387 from dhuang/shh-apache-version
Do not output apache version when deploying cert
2017-03-21 16:39:31 -07:00
Brad WarrenandGitHub bf45cea7cd Ensure a SHA2 hash algorithm is used when signing releases (#4384)
* use gpg2

* explictly use sha256
2017-03-20 18:00:50 -07:00
Brad WarrenandGitHub b7d282309d Save hyphenated plugin params for renewal (#4281)
* fix plugin namespace check

* Add test to prevent regressions
2017-03-20 17:57:09 -07:00
Brad WarrenandPeter Eckersley 32122cfa21 Add a global lock file to Certbot (#4369)
* add fasteners as a dependency

* add LOCK_FILE constant

* Add lock file to Certbot

* Move code to _run_subcommand

* move lock file path into CLI_CONSTANTS

* add --lock-path flag

* move locking code to separate function

* Add TestAcquireFileLock

* assert we log

* test lock contention

* add fasteners to certbot-auto

* Use a different lock file for each test in MainTest
2017-03-20 15:48:39 -07:00
dokazakiandBrad Warren 8011fb2879 Add mypy (#4386)
* Initial configuration of mypy in box, correction of base mypy errors.

* Move mypy install to toe

* Add pylint comments for typing imports.

* Remove typing module for Python 2.6 compatibility.
2017-03-18 19:10:10 -07:00
Daniel Huang 1e36783986 Still include apache version in debug logging 2017-03-18 21:37:37 -04:00
Daniel HuangandBrad Warren 679887f691 Add --debug-challenges flag (#1684) (#4385)
* Add --debug-challenges flag (#1684)

* Specify None as topic for --debug-challenges
2017-03-18 18:33:29 -07:00
Daniel Huang b9121a8a37 Do not output apache version when deploying cert (#4023) 2017-03-18 21:14:53 -04:00
Yen Chi HsuanandBrad Warren 97db9e646a Fix _get_runtime_cfg on Python 3 (#4262) 2017-03-18 18:06:32 -07:00
Daniel HuangandBrad Warren d54d3eba78 Retry fetch chain errors (#4196) (#4383)
* Retry fetch chain errors (#4196)

* Trying to avoid confusing pylint

* Pylint disable

* Typo certz->certr

* Move pylint disable, log when fetch chain fails
2017-03-18 17:04:16 -07:00
Daniel HuangandBrad Warren e034b50363 Don't save keys/csr on dry run (#4380)
* Don't save keys/csr on dry run (#2495)

* Replace assertIsNone for py26

* Fix config defaults for compat tests
2017-03-18 13:42:54 -07:00
Brad WarrenandGitHub 6f979a4808 upgrade pip and setuptools before installing packages (#4378) 2017-03-18 13:40:01 -07:00
Brad WarrenandGitHub c439057efa install python3-dev for python3 tests in docker (#4381) 2017-03-18 13:25:02 -07:00
Erica PortnoyandGitHub 050d272272 Merge pull request #4347 from kernelpanek/master
Fixes nginxparser to allow multiline quoted strings
2017-03-17 16:48:32 -07:00
Piotr KasprzykandPeter Eckersley fd789b4e4b Fix choose, remove spaces (#4364) 2017-03-17 14:11:52 -07:00
Jacob Hoffman-AndrewsandPeter Eckersley b23a1377e0 Clarify documentation for low-memory machines. (#4305)
* Clarify documentation for low-memory machines.

* Restore py26/py27 requirement.
2017-03-17 13:17:08 -07:00
Jacob Hoffman-AndrewsandPeter Eckersley 672f206309 Improve plugin-writing docs. (#4329)
Move "Writing your own plugin" under Code components and layout, with the other
plugin docs.

Include instructions on how to install a plugin into a virtualenv and how to check
for its presence.

Document that users can install third-party plugins systemwide, but not with
certbot-auto.

Remove obsolete information from Authenticators section and make the section
more informative.

Remove IDisplay sub-section since it repeats information in the main "Plugin
architecture" section.
2017-03-17 13:13:45 -07:00
Yen Chi HsuanandPeter Eckersley 4cad594b4b Python 3 compatibility for all tests (#4358) 2017-03-17 13:10:02 -07:00
Brad WarrenandPeter Eckersley edcfc49303 Use setattr in NamespaceConfig (#4362)
* set setattr in NamespaceConfig

* remove unnecessary uses of .namespace

* add simple test to ensure it works
2017-03-17 13:02:41 -07:00
Noah SwartzandGitHub 57f527f818 Merge pull request #4345 from certbot/use-dockerhub
Use docker hub URL
2017-03-16 13:08:54 -07:00
Erica PortnoyandGitHub 5fa2080558 If we fail to reload Nginx, write to temporary files instead of piping output (#4333)
Due to issues with piping and Nginx on Arch.
2017-03-15 17:05:52 -07:00
Richard PanekandGitHub f791af5afe New switch for QuotedStrings allows retainer of quotes but my test fails 2017-03-15 02:13:09 -06:00
kernelpanek e715b49dd2 Don't unquote the results of the parse 2017-03-15 01:26:16 -06:00
kernelpanek 5758b1687d Fixes issue when parsing an Nginx configuration file containing multiline quoted strings 2017-03-15 00:25:26 -06:00
Jacob Hoffman-AndrewsandBrad Warren 018a304cd6 Remove Link rel=next for authzs and new-certs. (#4303)
An early version of the spec indicated that clients should process issuance
sequentially, following Link rel=next from an account URL to an authz URL, to a
new-cert URL. However, the spec has long since moved to putting these URLs in
the directory.

Certbot nominally supports either; This change consolidates on always using the
directory, simplifying things and making the transition to the latest ACME spec
easier.

* Revert "Revert "Remove Link rel=next for authzs and new-certs." (#4277)"

This reverts commit 11ec1eb911.

* Save new_authzr_uri with account for older clients.

* Add test that new_authzr_uri exists in regr.

* Restore backwards compatibility for new_authzr_uri.

* Fix account_test.

* Add test for deprecated URI argument to request_challenges.

* Review feedback.

* Fix test

* Add omitempty to new_cert_uri.
2017-03-14 21:44:57 -07:00
Brad Warren da1459df0d use docker hub in install guide 2017-03-14 16:36:39 -07:00
Noah SwartzandGitHub f11d7b3f0c Merge pull request #4269 from osirisinferi/docs-update-standalone-manual-plugins
Deprecated standalone-preferred-challenges
2017-03-14 10:52:01 -07:00
Brad WarrenandGitHub 7b34e73752 Merge pull request #4295 from certbot/dockerfile++
Rewrite our Dockerfile
2017-03-13 20:25:45 -07:00
Noah SwartzandGitHub 25bda6177e Merge branch 'master' into docs-update-standalone-manual-plugins 2017-03-13 13:48:48 -07:00
Amjad MashaalandBrad Warren 0e735e360c remove unnecessary whitespace from tools/release.sh 2017-03-10 18:09:39 -08:00
Brad WarrenandGitHub 91f4b2b571 Improve macOS contributor instructions (#4327)
* remove instructions about removed Vagrantfile

* rewrite docker instructions

* say where docker-compose can be run

* give better intro for macOS devs

* prompt people for permission to install OS packages

* reword awkward sentence

* Change WORKDIR to /opt/certbot/src

This change is OK because all paths used in Dockerfile-dev are absolute paths.

* remove 'cd src' instructions for Dockerfile-dev

* Improve docker-compose testing instructions
2017-03-10 17:27:09 -08:00
Brad WarrenandGitHub 662c323b55 Build wheels correctly for Python 2.6 (#4313)
* stop conditionally pinning mock version in acme

* stop conditionally pinning mock version in certbot

* stop conditionally pinning mock version in apache

* stop conditionally pinning mock version in nginx

* stop conditionally pinning mock version in letshelp

* stop conditionally pinning mock version in compatibility-test
2017-03-10 10:58:03 -08:00
Erik RoseandBrad Warren 8f10103496 Make argparse dependency unconditional. (#2249)
The primary motivation is to avoid a branch, giving bugs one fewer place to hide. But, as a bonus, more people get a more bugfixed version of argparse. (To use the example from the argparse docs, people stuck on Python 3.2.3 can get bugfixes that made it into the stdlib only in 3.2.4.)
2017-03-08 17:10:12 -08:00
陈三andBrad Warren 6669b95a4e Updated the deprecated arguments (#4306) 2017-03-07 11:19:55 -08:00
Brad Warren ca42e99222 add certbot wrapper to Dockerfile-old 2017-03-06 19:31:42 -08:00
Brad Warren eb1e3c4cb3 add docker-warning script 2017-03-06 19:31:42 -08:00
Brad Warren fb9b62a282 add Dockerfile-old 2017-03-06 19:31:38 -08:00