Commit Graph
17 Commits
Author SHA1 Message Date
Marius Gedminas f5c8a63c18 Tests for --disable-hook-validation 2016-06-03 09:44:12 +03:00
Marius Gedminas d21f8fa657 Add --disable-hook-validation
As discussed in #3020.
2016-05-29 22:20:47 +03:00
Marius Gedminas 321a806b91 Hook validation: skip leading spaces/newlines
Improves the situation with #3020 a bit.

Does nothing about other valid shell commands that the current
validation would reject:

  - shell builtins like --post-hook 'if [ -x /my/script ]; then /my/script; fi'
  - variable assignments like --post-hook 'ENV_VAR=value command'
  - comments
  - redirections like --post-hook '<infile command'
  - I'm sure I'm missing many other exciting possibilities
2016-05-18 11:57:50 +03:00
Marius Gedminas 279cb35256 Oops, ReST syntax is weird 2016-05-18 11:05:23 +03:00
Marius Gedminas f55ef8e286 Renewal hooks mean this note is outdated 2016-05-18 11:03:18 +03:00
Marius Gedminas 63c79f98ca Remove dangling footnote
This footnote has no references!
2016-05-18 10:59:58 +03:00
Marius Gedminas d73e2e68ac Add a test for #2906 2016-05-02 11:45:07 +03:00
Marius Gedminas 8b4f48556d Catch the right exception
Conrary to the docstring of choose_vhost(), when you run non-interactive
certificate renewals and the Apache plugin fails to discover the correct
vhost, it raises MissingCommandlineFlag and not PluginError.
2016-05-02 09:45:27 +03:00
Marius Gedminas 528a816f70 Don't fail authentication when vhost cannot be found
Should fix #677 and #2600.
2016-05-02 09:30:32 +03:00
Marius Gedminas 73878f2457 Abort when no Pythons are found
It seems ill-advised to continue without setting the LE_PYTHON variable, when the very next command tries to use it.
2015-12-08 11:30:13 +02:00
Marius Gedminas 869c3741c5 Typo: Apacche -> Apache 2015-12-04 12:03:33 +02:00
Marius Gedminas 85dc829d9f Order imports alphabetically 2015-12-03 10:51:16 +02:00
Marius Gedminas 51f17115c6 Allow older ConfigArgParse for users of modern Pythons
(I think this is a bad idea because of
https://github.com/pypa/pip/issues/3025, but letsencrypt maintainers
insist, so *shrug*.  Also the same problem exists for the versioned
'mock' dependency, so I'm not introducing a new one here.)
2015-12-03 10:22:50 +02:00
Marius Gedminas 9fbec030a2 Require ConfigArgParse >= 0.10 for Python 2.6 support 2015-12-03 10:07:31 +02:00
Marius Gedminas afb6d2813a git+https://* is no longer used 2015-12-03 10:07:31 +02:00
Marius Gedminas e268e718a0 Remove py26reqs.txt
ConfigArgParse 0.10 from PyPI supports Python 2.6, so there's no more
need to install a fixed version directly from a git branch.
2015-12-03 10:07:31 +02:00
Marius Gedminas c7dbf8aa24 Avoid trailing whitespace in pretty-printed JSON
Fixes a failing test on Python 3.3:

    ======================================================================
    FAIL: test_json_dumps_pretty (acme.jose.interfaces_test.JSONDeSerializableTest)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/mg/src/letsencrypt/acme/acme/jose/interfaces_test.py", line 97, in test_json_dumps_pretty
        '[\n    "foo1",{0}\n    "foo2"\n]'.format(filler))
    AssertionError: '[\n    "foo1", \n    "foo2"\n]' != '[\n    "foo1",\n    "foo2"\n]'
      [
    -     "foo1",
    ?            -
    +     "foo1",
          "foo2"
      ]

    ----------------------------------------------------------------------

(The test expected trailing whitespace on Python < 3.0, while it
should've been checking for Python < 3.4.)
2015-12-03 09:52:59 +02:00