mirror of
https://github.com/certbot/certbot.git
synced 2026-07-27 16:29:55 +02:00
ohemorangeandGitHub
4c61a450d4
This should fix our failing tests. Python 3.14.3 has the following in its changelog: > [gh-142651](https://github.com/python/cpython/issues/142651): [unittest.mock](https://docs.python.org/3/library/unittest.mock.html#module-unittest.mock): fix a thread safety issue where [Mock.call_count](https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.call_count) may return inaccurate values when the mock is called concurrently from multiple threads. As a result, we have to call `reset_mock()` instead of using `.call_count = 0`. See example [here](https://github.com/matplotlib/matplotlib/pull/31153). Tests on my machine showing that this change fixes things, and it's the only place to fix: ```bash $ brew upgrade pyenv $ pyenv install 3.14.3 $ pyenv global 3.14.3 $ tools/venv.py $ source venv/bin/activate $ pytest certbot -k "test_rollback_too_many" ====================================================================== test session starts ======================================================================= platform darwin -- Python 3.14.3, pytest-9.0.2, pluggy-1.6.0 rootdir: /Users/erica/certbot configfile: pytest.ini plugins: anyio-4.12.1, xdist-3.8.0, cov-7.0.0 collected 1039 items / 1038 deselected / 1 selected certbot/src/certbot/_internal/tests/reverter_test.py . [100%] =============================================================== 1 passed, 1038 deselected in 2.94s =============================================================== $ git grep 'call_count = 0' $ git checkout main $ pytest certbot -k "test_rollback_too_many" ====================================================================== test session starts ======================================================================= platform darwin -- Python 3.14.3, pytest-9.0.2, pluggy-1.6.0 rootdir: /Users/erica/certbot configfile: pytest.ini plugins: anyio-4.12.1, xdist-3.8.0, cov-7.0.0 collected 1039 items / 1038 deselected / 1 selected certbot/src/certbot/_internal/tests/reverter_test.py F [100%] ============================================================================ FAILURES ============================================================================ _______________________________________________________ TestFullCheckpointsReverter.test_rollback_too_many _______________________________________________________ self = <certbot._internal.tests.reverter_test.TestFullCheckpointsReverter testMethod=test_rollback_too_many> mock_logger = <MagicMock name='logger' id='4463351456'> > ??? E AssertionError: assert 2 == 1 E + where 2 = <MagicMock name='logger.warning' id='4463351792'>.call_count E + where <MagicMock name='logger.warning' id='4463351792'> = <MagicMock name='logger' id='4463351456'>.warning certbot/src/certbot/_internal/tests/reverter_test.py:363: AssertionError ==================================================================== short test summary info ===================================================================== FAILED certbot/src/certbot/_internal/tests/reverter_test.py::TestFullCheckpointsReverter::test_rollback_too_many - AssertionError: assert 2 == 1 =============================================================== 1 failed, 1038 deselected in 0.48s =============================================================== $ git grep 'call_count = 0' certbot/src/certbot/_internal/tests/reverter_test.py: mock_logger.warning.call_count = 0 ```
.. This file contains a series of comments that are used to include sections of this README in other files. Do not modify these comments unless you know what you are doing. tag:intro-begin |build-status| .. |build-status| image:: https://img.shields.io/azure-devops/build/certbot/ba534f81-a483-4b9b-9b4e-a60bec8fee72/5/main :target: https://dev.azure.com/certbot/certbot/_build?definitionId=5 :alt: Azure Pipelines CI status .. image:: https://raw.githubusercontent.com/EFForg/design/master/logos/certbot/eff-certbot-lockup.png :width: 200 :alt: EFF Certbot Logo Certbot is part of EFF’s effort to encrypt the entire Internet. Secure communication over the Web relies on HTTPS, which requires the use of a digital certificate that lets browsers verify the identity of web servers (e.g., is that really google.com?). Web servers obtain their certificates from trusted third parties called certificate authorities (CAs). Certbot is an easy-to-use client that fetches a certificate from Let’s Encrypt—an open certificate authority launched by the EFF, Mozilla, and others—and deploys it to a web server. Anyone who has gone through the trouble of setting up a secure website knows what a hassle getting and maintaining a certificate is. Certbot and Let’s Encrypt can automate away the pain and let you turn on and manage HTTPS with simple commands. Using Certbot and Let's Encrypt is free. .. _installation: Getting Started --------------- The best way to get started is to use our `interactive guide <https://certbot.eff.org>`_. It generates instructions based on your configuration settings. In most cases, you’ll need `root or administrator access <https://certbot.eff.org/faq/#does-certbot-require-root-administrator-privileges>`_ to your web server to run Certbot. Certbot is meant to be run directly on your web server on the command line, not on your personal computer. If you’re using a hosted service and don’t have direct access to your web server, you might not be able to use Certbot. Check with your hosting provider for documentation about uploading certificates or using certificates issued by Let’s Encrypt. Contributing ------------ If you'd like to contribute to this project please read `Developer Guide <https://certbot.eff.org/docs/contributing.html>`_. This project is governed by `EFF's Public Projects Code of Conduct <https://www.eff.org/pages/eppcode>`_. Links ===== .. Do not modify this comment unless you know what you're doing. tag:links-begin Documentation: https://certbot.eff.org/docs Software project: https://github.com/certbot/certbot Changelog: https://github.com/certbot/certbot/blob/main/certbot/CHANGELOG.md For Contributors: https://certbot.eff.org/docs/contributing.html For Users: https://certbot.eff.org/docs/using.html Main Website: https://certbot.eff.org Let's Encrypt Website: https://letsencrypt.org Community: https://community.letsencrypt.org ACME spec: `RFC 8555 <https://tools.ietf.org/html/rfc8555>`_ ACME working area in github (archived): https://github.com/ietf-wg-acme/acme .. Do not modify this comment unless you know what you're doing. tag:links-end .. Do not modify this comment unless you know what you're doing. tag:intro-end .. Do not modify this comment unless you know what you're doing. tag:features-begin Current Features ===================== * Supports multiple web servers: - Apache 2.4+ - nginx/0.8.48+ - webroot (adds files to webroot directories in order to prove control of domains and obtain certificates) - standalone (runs its own simple webserver to prove you control a domain) - other server software via `third party plugins <https://certbot.eff.org/docs/using.html#third-party-plugins>`_ * The private key is generated locally on your system. * Can talk to the Let's Encrypt CA or optionally to other ACME compliant services. * Can get domain-validated (DV) certificates. * Can revoke certificates. * Supports ECDSA (default) and RSA certificate private keys. * Can optionally install a http -> https redirect, so your site effectively runs https only. * Fully automated. * Configuration changes are logged and can be reverted. .. Do not modify this comment unless you know what you're doing. tag:features-end