starred/certbot-certbot-2
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-07-27 16:19:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

certbot: demote manual's preference for dns-persist-01

Browse Source 
This'll avoid breaking things for users relying on http-01's
most-preferred status.
This commit is contained in:
Will Greenberg
2026-04-30 13:32:57 -07:00
parent 8723380611
commit 0e2b0643a9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
certbot/src/certbot/_internal/plugins/manual.py
+1 -1
View File
@@ -171,7 +171,7 @@ permitted by DNS standards.)
def get_chall_pref(self, identifier: str) -> Iterable[type[challenges.Challenge]]:
# pylint: disable=unused-argument,missing-function-docstring
return [challenges.DNSPersist01, challenges.HTTP01, challenges.DNS01]
return [challenges.HTTP01, challenges.DNS01, challenges.DNSPersist01]
def perform(self, achalls: list[achallenges.AnnotatedChallenge]
) -> list[challenges.ChallengeResponse]: # pylint: disable=missing-function-docstring
certbot/src/certbot/_internal/tests/plugins/manual_test.py
+1 -1
View File
@@ -74,7 +74,7 @@ class AuthenticatorTest(test_util.TempDirTestCase):
def test_get_chall_pref(self):
assert self.auth.get_chall_pref('example.org') == \
[challenges.DNSPersist01, challenges.HTTP01, challenges.DNS01]
[challenges.HTTP01, challenges.DNS01, challenges.DNSPersist01]
def test_script_perform(self):
self.config.manual_auth_hook = (